[jira] [Commented] (HDFS-2786) Fix host-based token incompatibilities in DFSUtil

["Jitendra Nath Pandey (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-2786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13198543#comment-13198543 ] 

Jitendra Nath Pandey commented on HDFS-2786:
--------------------------------------------

{code}
-    String namenodeHost = namenodeAddress.getHostName();
+    String namenodeHost = NetUtils.createSocketAddr(nnAddr).getHostName();
     out.print("<br><a href=\"http://"
         + InetAddress.getByName(namenodeHost).getCanonicalHostName() + ":"
         + namenodeInfoPort + "/dfshealth.jsp\">Go back to DFS home</a>");
{code}

The namenodeHost is used only to obtain the InetAddress. We could just get it as in following
NetUtils.createSocketAddr(nnAddr).getAddress().getCanonicalHostName().
                
> Fix host-based token incompatibilities in DFSUtil
> -------------------------------------------------
>
>                 Key: HDFS-2786
>                 URL: https://issues.apache.org/jira/browse/HDFS-2786
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node, security
>    Affects Versions: 0.24.0, 0.23.1
>            Reporter: Daryn Sharp
>            Assignee: Kihwal Lee
>         Attachments: hdfs-2786.patch
>
>
> DFSUtil introduces new static methods that duplicate functionality in NetUtils.  These new methods lack the logic necessary for host-based tokens to work.  After speaking with Suresh, the approach being taken is:
> * DFSUtil.getSocketAddress will be removed.  Callers will be reverted to using the NetUtils version.
> * DFSUtil.getDFSClient will changed to take accept a uri/host:port string instead of an InetSocketAddress.  The method will internal call NetUtils.createSocketAddr. This alleviates the callers from being required to call NetUtils.createSocketAddr and reduce the opportunity for error that will break host-based tokens.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira