You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@apache.org> on 2019/10/01 15:41:14 UTC
Re: Review Request 71559: Added early exit in reviewbot if nothing to
review.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71559/#review218009
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Sept. 30, 2019, 1:06 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71559/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2019, 1:06 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The current reviewbot setup always makes sure that the `master` branch
> can be built before verifying any reviews. This takes considerable time.
>
> With this patch we now avoid any builds if no reviews need to be
> verified. While detecting reviews requiring verification takes some
> time, it is currently much faster than building Mesos. With this setup
> we should now finish this job much faster in the usual case (nothing
> needs verification) while taking only on the order of a minute longer
> otherwise.
>
>
> Diffs
> -----
>
> support/jenkins/reviewbot.sh c5b497634cb9754fa19c5af3f579ceae25ab912d
>
>
> Diff: https://reviews.apache.org/r/71559/diff/1/
>
>
> Testing
> -------
>
> Verified early exit by running locally.
>
>
> Thanks,
>
> Benjamin Bannier
>
>