You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by jithinchandranj <gi...@git.apache.org> on 2017/12/15 06:52:26 UTC

[GitHub] zeppelin pull request #2704: ZEPPELIN-3061: Updated the SecurityUtils to add...

GitHub user jithinchandranj opened a pull request:

    https://github.com/apache/zeppelin/pull/2704

    ZEPPELIN-3061: Updated the SecurityUtils to add Shiro's custom realm functionality

    security functionality for CAS implementation.
    
    ### What is this PR for?
    Updated the security functionality to retrieve roles for a logged in user, when the security is implemented using Shiro's custom realm implementation.
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-3061
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jithinchandranj/zeppelin ZEPPELIN-3061

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2704.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2704
    
----
commit e25fe1076e67d1abb5ae09c01cf78082f511748a
Author: Jithin Chandran J <ji...@ibsplc.com>
Date:   2017-12-15T06:04:23Z

    ZEPPELIN-3061: Updated the SecurityUtils to add Shiro's custom realm
    security functionality for CAS implementation.

----


---

[GitHub] zeppelin issue #2704: ZEPPELIN-3061: Updated the SecurityUtils to add Shiro'...

Posted by jithinchandranj <gi...@git.apache.org>.
Github user jithinchandranj commented on the issue:

    https://github.com/apache/zeppelin/pull/2704
  
    Thank @tinkoff-dwh , latest commits are merged to the branch, and the PR is updated but one jenkins job is still failing for some reason that is not relevant I guess.


---

[GitHub] zeppelin issue #2704: ZEPPELIN-3061: Updated the SecurityUtils to add Shiro'...

Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:

    https://github.com/apache/zeppelin/pull/2704
  
    Thanks @jithinchandranj. Could you add test case for new functionality?


---

[GitHub] zeppelin issue #2704: ZEPPELIN-3061: Updated the SecurityUtils to add Shiro'...

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/2704
  
    @prabhjyotsingh 


---

[GitHub] zeppelin pull request #2704: ZEPPELIN-3061: Updated the SecurityUtils to add...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2704


---

[GitHub] zeppelin issue #2704: ZEPPELIN-3061: Updated the SecurityUtils to add Shiro'...

Posted by jithinchandranj <gi...@git.apache.org>.
Github user jithinchandranj commented on the issue:

    https://github.com/apache/zeppelin/pull/2704
  
    Hi @prabhjyotsingh ,
    
    Note is updated and PR is raised:
    https://github.com/apache/zeppelin/pull/2720



---

[GitHub] zeppelin issue #2704: ZEPPELIN-3061: Updated the SecurityUtils to add Shiro'...

Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:

    https://github.com/apache/zeppelin/pull/2704
  
    check jobs in Jenkins. try to merge the latest changes from master.


---

[GitHub] zeppelin issue #2704: ZEPPELIN-3061: Updated the SecurityUtils to add Shiro'...

Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/2704
  
    This looks OK to me.
    @jithinchandranj  can you add some a small note [here](https://github.com/apache/zeppelin/blob/master/docs/setup/security/shiro_authentication.md#configure-realm-optional), on how to use CAS as well.


---

[GitHub] zeppelin issue #2704: ZEPPELIN-3061: Updated the SecurityUtils to add Shiro'...

Posted by jithinchandranj <gi...@git.apache.org>.
Github user jithinchandranj commented on the issue:

    https://github.com/apache/zeppelin/pull/2704
  
    Hi @tinkoff-dwh ,
    Attached test case for the custom realm functionality.


---

[GitHub] zeppelin issue #2704: ZEPPELIN-3061: Updated the SecurityUtils to add Shiro'...

Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/2704
  
    Looks good.


---