You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2013/01/25 02:36:12 UTC
Review Request: SQOOP-852 Sqoop2: Mapreduce submission engine is not closing
opened JobClient object
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9107/
-----------------------------------------------------------
Review request for Sqoop.
Description
-------
I've added explicit close() call to shutdown hook.
This addresses bug SQOOP-852.
https://issues.apache.org/jira/browse/SQOOP-852
Diffs
-----
submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 1a144d09b3368f9ca1ad11c0be52614c0dcf928d
submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionError.java 9296717b1e2d7479ff542c9fb500660b23fc3e61
Diff: https://reviews.apache.org/r/9107/diff/
Testing
-------
Unit tests seems to be passing and I've tested it on real cluster (no issues found).
Thanks,
Jarek Cecho
Re: Review Request: SQOOP-852 Sqoop2: Mapreduce submission engine is not
closing opened JobClient object
Posted by Cheolsoo Park <ch...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9107/#review15903
-----------------------------------------------------------
Ship it!
Ship It!
- Cheolsoo Park
On Jan. 25, 2013, 1:36 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9107/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2013, 1:36 a.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've added explicit close() call to shutdown hook.
>
>
> This addresses bug SQOOP-852.
> https://issues.apache.org/jira/browse/SQOOP-852
>
>
> Diffs
> -----
>
> submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 1a144d09b3368f9ca1ad11c0be52614c0dcf928d
> submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionError.java 9296717b1e2d7479ff542c9fb500660b23fc3e61
>
> Diff: https://reviews.apache.org/r/9107/diff/
>
>
> Testing
> -------
>
> Unit tests seems to be passing and I've tested it on real cluster (no issues found).
>
>
> Thanks,
>
> Jarek Cecho
>
>