You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Changming Sun (Created) (JIRA)" <ji...@apache.org> on 2012/02/20 10:29:34 UTC
[jira] [Created] (HADOOP-8093) HadoopRpcRequestProto should not be
serialize twice
HadoopRpcRequestProto should not be serialize twice
---------------------------------------------------
Key: HADOOP-8093
URL: https://issues.apache.org/jira/browse/HADOOP-8093
Project: Hadoop Common
Issue Type: Improvement
Components: ipc
Affects Versions: 0.24.0
Environment: Windows 7
Reporter: Changming Sun
@Override
public void write(DataOutput out) throws IOException {
out.writeInt(message.toByteArray().length);
out.write(message.toByteArray());
}
The code is not effective.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8093) HadoopRpcRequestProto should not
be serialize twice
Posted by "Changming Sun (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212326#comment-13212326 ]
Changming Sun commented on HADOOP-8093:
---------------------------------------
em... you are right. let's close this issue.
> HadoopRpcRequestProto should not be serialize twice
> ---------------------------------------------------
>
> Key: HADOOP-8093
> URL: https://issues.apache.org/jira/browse/HADOOP-8093
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.24.0, 0.23.2
> Environment: Windows 7
> Reporter: Changming Sun
> Attachments: HADOOP-8093.patch
>
> Original Estimate: 1m
> Remaining Estimate: 1m
>
> @Override
> public void write(DataOutput out) throws IOException {
> out.writeInt(message.toByteArray().length);
> out.write(message.toByteArray());
> }
> The code is not effective.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8093) HadoopRpcRequestProto should not be
serialize twice
Posted by "Changming Sun (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Changming Sun updated HADOOP-8093:
----------------------------------
Attachment: HADOOP-8093.patch
> HadoopRpcRequestProto should not be serialize twice
> ---------------------------------------------------
>
> Key: HADOOP-8093
> URL: https://issues.apache.org/jira/browse/HADOOP-8093
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.24.0
> Environment: Windows 7
> Reporter: Changming Sun
> Attachments: HADOOP-8093.patch
>
> Original Estimate: 1m
> Remaining Estimate: 1m
>
> @Override
> public void write(DataOutput out) throws IOException {
> out.writeInt(message.toByteArray().length);
> out.write(message.toByteArray());
> }
> The code is not effective.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8093) HadoopRpcRequestProto should not be
serialize twice
Posted by "Suresh Srinivas (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-8093:
------------------------------------
Target Version/s: 0.24.0, 0.23.2 (was: 0.24.0)
Affects Version/s: 0.23.2
> HadoopRpcRequestProto should not be serialize twice
> ---------------------------------------------------
>
> Key: HADOOP-8093
> URL: https://issues.apache.org/jira/browse/HADOOP-8093
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.24.0, 0.23.2
> Environment: Windows 7
> Reporter: Changming Sun
> Attachments: HADOOP-8093.patch
>
> Original Estimate: 1m
> Remaining Estimate: 1m
>
> @Override
> public void write(DataOutput out) throws IOException {
> out.writeInt(message.toByteArray().length);
> out.write(message.toByteArray());
> }
> The code is not effective.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8093) HadoopRpcRequestProto should not
be serialize twice
Posted by "Suresh Srinivas (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211743#comment-13211743 ]
Suresh Srinivas commented on HADOOP-8093:
-----------------------------------------
Good catch. +1 for the patchy. Will commit it after jenkins posts resullts.
> HadoopRpcRequestProto should not be serialize twice
> ---------------------------------------------------
>
> Key: HADOOP-8093
> URL: https://issues.apache.org/jira/browse/HADOOP-8093
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.24.0, 0.23.2
> Environment: Windows 7
> Reporter: Changming Sun
> Attachments: HADOOP-8093.patch
>
> Original Estimate: 1m
> Remaining Estimate: 1m
>
> @Override
> public void write(DataOutput out) throws IOException {
> out.writeInt(message.toByteArray().length);
> out.write(message.toByteArray());
> }
> The code is not effective.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8093) HadoopRpcRequestProto should not
be serialize twice
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211747#comment-13211747 ]
Hadoop QA commented on HADOOP-8093:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12515231/HADOOP-8093.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/613//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/613//console
This message is automatically generated.
> HadoopRpcRequestProto should not be serialize twice
> ---------------------------------------------------
>
> Key: HADOOP-8093
> URL: https://issues.apache.org/jira/browse/HADOOP-8093
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.24.0, 0.23.2
> Environment: Windows 7
> Reporter: Changming Sun
> Attachments: HADOOP-8093.patch
>
> Original Estimate: 1m
> Remaining Estimate: 1m
>
> @Override
> public void write(DataOutput out) throws IOException {
> out.writeInt(message.toByteArray().length);
> out.write(message.toByteArray());
> }
> The code is not effective.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8093) HadoopRpcRequestProto should not
be serialize twice
Posted by "Todd Lipcon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212307#comment-13212307 ]
Todd Lipcon commented on HADOOP-8093:
-------------------------------------
This seems like a dup of HADOOP-8084, but the implementation in 8084 actually avoids one more copy than this.
> HadoopRpcRequestProto should not be serialize twice
> ---------------------------------------------------
>
> Key: HADOOP-8093
> URL: https://issues.apache.org/jira/browse/HADOOP-8093
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.24.0, 0.23.2
> Environment: Windows 7
> Reporter: Changming Sun
> Attachments: HADOOP-8093.patch
>
> Original Estimate: 1m
> Remaining Estimate: 1m
>
> @Override
> public void write(DataOutput out) throws IOException {
> out.writeInt(message.toByteArray().length);
> out.write(message.toByteArray());
> }
> The code is not effective.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8093) HadoopRpcRequestProto should not be
serialize twice
Posted by "Changming Sun (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Changming Sun updated HADOOP-8093:
----------------------------------
Status: Patch Available (was: Open)
> HadoopRpcRequestProto should not be serialize twice
> ---------------------------------------------------
>
> Key: HADOOP-8093
> URL: https://issues.apache.org/jira/browse/HADOOP-8093
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.24.0
> Environment: Windows 7
> Reporter: Changming Sun
> Attachments: HADOOP-8093.patch
>
> Original Estimate: 1m
> Remaining Estimate: 1m
>
> @Override
> public void write(DataOutput out) throws IOException {
> out.writeInt(message.toByteArray().length);
> out.write(message.toByteArray());
> }
> The code is not effective.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8093) HadoopRpcRequestProto should not be
serialize twice
Posted by "Suresh Srinivas (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-8093:
------------------------------------
Resolution: Duplicate
Target Version/s: 0.24.0, 0.23.2 (was: 0.23.2, 0.24.0)
Status: Resolved (was: Patch Available)
Duplicate of HADOOP-8084
> HadoopRpcRequestProto should not be serialize twice
> ---------------------------------------------------
>
> Key: HADOOP-8093
> URL: https://issues.apache.org/jira/browse/HADOOP-8093
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.24.0, 0.23.2
> Environment: Windows 7
> Reporter: Changming Sun
> Attachments: HADOOP-8093.patch
>
> Original Estimate: 1m
> Remaining Estimate: 1m
>
> @Override
> public void write(DataOutput out) throws IOException {
> out.writeInt(message.toByteArray().length);
> out.write(message.toByteArray());
> }
> The code is not effective.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira