[3/4] kudu git commit: KUDU-2652: deflake TsRecoveryITest.TestNoBlockIDReuseIfMissingBlocks

[ad...@apache.org]

KUDU-2652: deflake TsRecoveryITest.TestNoBlockIDReuseIfMissingBlocks

The test waits for a write workload to generate some orphaned blocks.
With the default write pattern, this could sometimes take a while and
cause the test to hit an error. This patch makes orphaned block
generation faster by making the workload update a single row.

Before this, I looped the test in debug mode with 32 stress threads and
it failed 15/100 times. With the fix, this passed 1000/1000.

Change-Id: I24a689702d29a744be8c113fedafec0307a90b1c
Reviewed-on: http://gerrit.cloudera.org:8080/12166
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Mike Percy <mp...@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/11479211
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/11479211
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/11479211

Branch: refs/heads/master
Commit: 1147921160738f690615026afe44452e1a5bdb6c
Parents: 7ca5fc6
Author: Andrew Wong <aw...@cloudera.com>
Authored: Fri Jan 4 17:16:55 2019 -0800
Committer: Andrew Wong <aw...@cloudera.com>
Committed: Wed Jan 9 05:41:30 2019 +0000

----------------------------------------------------------------------
 src/kudu/integration-tests/ts_recovery-itest.cc | 3 +++
 1 file changed, 3 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/11479211/src/kudu/integration-tests/ts_recovery-itest.cc
----------------------------------------------------------------------
diff --git a/src/kudu/integration-tests/ts_recovery-itest.cc b/src/kudu/integration-tests/ts_recovery-itest.cc
index 37899c2..67a0a76 100644
--- a/src/kudu/integration-tests/ts_recovery-itest.cc
+++ b/src/kudu/integration-tests/ts_recovery-itest.cc
@@ -254,6 +254,9 @@ TEST_P(TsRecoveryITest, TestNoBlockIDReuseIfMissingBlocks) {
     write_workload->set_table_name(table_name);
     write_workload->set_num_tablets(1);
     write_workload->set_num_replicas(1);
+    // We want to generate orphaned blocks, so use a workload that we expect to
+    // cause a lot of delta compaction.
+    write_workload->set_write_pattern(TestWorkload::UPDATE_ONE_ROW);
     write_workload->Setup();
     write_workload->Start();
     return write_workload;