[GitHub] [hbase] nyl3532016 commented on a change in pull request #3266: HBASE-25830 HBaseCluster support CompactionServer for UTs

[GitBox <gi...@apache.org>]

nyl3532016 commented on a change in pull request #3266:
URL: https://github.com/apache/hbase/pull/3266#discussion_r633308440



##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java
##########
@@ -253,6 +256,12 @@ private void init(final int nMasterNodes, final int numAlwaysStandByMasters,
         hbaseCluster.addRegionServer(rsConf, i, user);
       }
 
+      // manually add the compaction servers as other users
+      for (int i = 0; i < numCompactionServers; i++) {

Review comment:
       You mean the compaction server and test code move to an independent module hbase-compaction-server, and this module depend on hbase-server module. I agree it's necessary.
   Maybe we need introduce a wrap class `MiniHBaseClusterWithExtraServer` in module hbase-server, it combine `MiniHBaseCluster` and `AbstractServer`(can be compaction server or replication server).And `MiniHBaseClusterWithExtraServer` can be used in hbase-compaction-server and hbase-replication-server module.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org