You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/06 23:33:49 UTC
[GitHub] [flink-statefun] sjwiesman opened a new pull request #273: [FLINK-24464][core] Metrics sometimes report negative backlog
sjwiesman opened a new pull request #273:
URL: https://github.com/apache/flink-statefun/pull/273
The backlog metric sometimes reports a negative value. This is because the current count is stored in an in-memory variable, while the value used to decrement the count as the backlog clears is stored in Flink state. In the case of a job restart, the in-memory variable is reset to zero (it is a new instance) while the numbers in state are retained.
Reseting the count after a restore would require iterating over all keys, so instead we simply prevent negative backlogs from being reported to not publish non-sensical values to reporters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-statefun] igalshilman commented on a change in pull request #273: [FLINK-24464][core] Metrics sometimes report negative backlog
Posted by GitBox <gi...@apache.org>.
igalshilman commented on a change in pull request #273:
URL: https://github.com/apache/flink-statefun/pull/273#discussion_r723750424
##########
File path: statefun-flink/statefun-flink-core/src/test/java/org/apache/flink/statefun/flink/core/metrics/NonNegativeCounterTest.java
##########
@@ -0,0 +1,27 @@
+package org.apache.flink.statefun.flink.core.metrics;
Review comment:
Missing header
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-statefun] sjwiesman closed pull request #273: [FLINK-24464][core] Metrics sometimes report negative backlog
Posted by GitBox <gi...@apache.org>.
sjwiesman closed pull request #273:
URL: https://github.com/apache/flink-statefun/pull/273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-statefun] sjwiesman commented on pull request #273: [FLINK-24464][core] Metrics sometimes report negative backlog
Posted by GitBox <gi...@apache.org>.
sjwiesman commented on pull request #273:
URL: https://github.com/apache/flink-statefun/pull/273#issuecomment-937327204
I'll fix the header while merging, grazi!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-statefun] sjwiesman commented on pull request #273: [FLINK-24464][core] Metrics sometimes report negative backlog
Posted by GitBox <gi...@apache.org>.
sjwiesman commented on pull request #273:
URL: https://github.com/apache/flink-statefun/pull/273#issuecomment-937327204
I'll fix the header while merging, grazi!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-statefun] igalshilman commented on a change in pull request #273: [FLINK-24464][core] Metrics sometimes report negative backlog
Posted by GitBox <gi...@apache.org>.
igalshilman commented on a change in pull request #273:
URL: https://github.com/apache/flink-statefun/pull/273#discussion_r723750424
##########
File path: statefun-flink/statefun-flink-core/src/test/java/org/apache/flink/statefun/flink/core/metrics/NonNegativeCounterTest.java
##########
@@ -0,0 +1,27 @@
+package org.apache.flink.statefun.flink.core.metrics;
Review comment:
Missing header
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-statefun] sjwiesman closed pull request #273: [FLINK-24464][core] Metrics sometimes report negative backlog
Posted by GitBox <gi...@apache.org>.
sjwiesman closed pull request #273:
URL: https://github.com/apache/flink-statefun/pull/273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org