You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/22 10:18:39 UTC
[GitHub] [flink] zentol opened a new pull request #11184:
[FLINK-16232][hive][build] Remove log4j2 exclusions
zentol opened a new pull request #11184: [FLINK-16232][hive][build] Remove log4j2 exclusions
URL: https://github.com/apache/flink/pull/11184
Now unnecessary since we switched to log4j2.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11184:
[FLINK-16232][hive][build] Remove log4j2 exclusions
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11184: [FLINK-16232][hive][build] Remove log4j2 exclusions
URL: https://github.com/apache/flink/pull/11184#issuecomment-589943033
<!--
Meta data
Hash:ca6f62c83856ef95953118cd6c7bae7111c1795b Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:ca6f62c83856ef95953118cd6c7bae7111c1795b
-->
## CI report:
* ca6f62c83856ef95953118cd6c7bae7111c1795b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on issue #11184:
[FLINK-16232][hive][build] Remove log4j2 exclusions
Posted by GitBox <gi...@apache.org>.
zentol commented on issue #11184: [FLINK-16232][hive][build] Remove log4j2 exclusions
URL: https://github.com/apache/flink/pull/11184#issuecomment-591398061
The log4j2 versions are defined in the dependency management in the root pom and are consistent across the entire project.
Because of that the exclusion is just noise.
I also prefer the dependency graph of transitive dependencies to stick close to the original. Right now we claim that hive doesn't require log4j, but this only works since Flink _by chance_ uses log4j as well.
If we were to switch to a different logging backend the hive tests would suddenly fail with ClassNotFoundExceptions since neither log4j1 or 2 are on the classpath, but the dependency graph did not indicate that it actually needed them.
Issues like this should be apparent in the build system imo, and should not require running anything.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol edited a comment on issue #11184:
[FLINK-16232][hive][build] Remove log4j2 exclusions
Posted by GitBox <gi...@apache.org>.
zentol edited a comment on issue #11184: [FLINK-16232][hive][build] Remove log4j2 exclusions
URL: https://github.com/apache/flink/pull/11184#issuecomment-591398061
The log4j2 versions are defined in the dependency management in the root pom and are consistent across the entire project.
Because of that the exclusion is just noise.
I also prefer the dependency graph of transitive dependencies to stick close to the original. Right now we claim that hive doesn't require log4j, but this only works since Flink "by chance" uses log4j as well.
If we were to switch to a different logging backend the hive tests would suddenly fail with ClassNotFoundExceptions since neither log4j1 or 2 are on the classpath, but the dependency graph did not indicate that it actually needed them.
Issues like this should be apparent in the build system imo, and should not require running anything.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11184:
[FLINK-16232][hive][build] Remove log4j2 exclusions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11184: [FLINK-16232][hive][build] Remove log4j2 exclusions
URL: https://github.com/apache/flink/pull/11184#issuecomment-589943033
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ca6f62c83856ef95953118cd6c7bae7111c1795b",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150138384",
"triggerID" : "ca6f62c83856ef95953118cd6c7bae7111c1795b",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f62c83856ef95953118cd6c7bae7111c1795b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5458",
"triggerID" : "ca6f62c83856ef95953118cd6c7bae7111c1795b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ca6f62c83856ef95953118cd6c7bae7111c1795b Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150138384) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5458)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] StephanEwen commented on issue #11184:
[FLINK-16232][hive][build] Remove log4j2 exclusions
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on issue #11184: [FLINK-16232][hive][build] Remove log4j2 exclusions
URL: https://github.com/apache/flink/pull/11184#issuecomment-591353370
Not sure I understand this. Doesn't the exclusion still help with avoiding dependency conflicts / dependency conversion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11184:
[FLINK-16232][hive][build] Remove log4j2 exclusions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11184: [FLINK-16232][hive][build] Remove log4j2 exclusions
URL: https://github.com/apache/flink/pull/11184#issuecomment-589943033
<!--
Meta data
Hash:ca6f62c83856ef95953118cd6c7bae7111c1795b Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/150138384 TriggerType:PUSH TriggerID:ca6f62c83856ef95953118cd6c7bae7111c1795b
Hash:ca6f62c83856ef95953118cd6c7bae7111c1795b Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5458 TriggerType:PUSH TriggerID:ca6f62c83856ef95953118cd6c7bae7111c1795b
-->
## CI report:
* ca6f62c83856ef95953118cd6c7bae7111c1795b Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150138384) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5458)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11184:
[FLINK-16232][hive][build] Remove log4j2 exclusions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11184: [FLINK-16232][hive][build] Remove log4j2 exclusions
URL: https://github.com/apache/flink/pull/11184#issuecomment-589943033
<!--
Meta data
Hash:ca6f62c83856ef95953118cd6c7bae7111c1795b Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/150138384 TriggerType:PUSH TriggerID:ca6f62c83856ef95953118cd6c7bae7111c1795b
Hash:ca6f62c83856ef95953118cd6c7bae7111c1795b Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5458 TriggerType:PUSH TriggerID:ca6f62c83856ef95953118cd6c7bae7111c1795b
-->
## CI report:
* ca6f62c83856ef95953118cd6c7bae7111c1795b Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150138384) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5458)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11184:
[FLINK-16232][hive][build] Remove log4j2 exclusions
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11184: [FLINK-16232][hive][build] Remove log4j2 exclusions
URL: https://github.com/apache/flink/pull/11184#issuecomment-589941043
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit ca6f62c83856ef95953118cd6c7bae7111c1795b (Fri Feb 28 21:48:00 UTC 2020)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol closed pull request #11184:
[FLINK-16232][hive][build] Remove log4j2 exclusions
Posted by GitBox <gi...@apache.org>.
zentol closed pull request #11184: [FLINK-16232][hive][build] Remove log4j2 exclusions
URL: https://github.com/apache/flink/pull/11184
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11184:
[FLINK-16232][hive][build] Remove log4j2 exclusions
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11184: [FLINK-16232][hive][build] Remove log4j2 exclusions
URL: https://github.com/apache/flink/pull/11184#issuecomment-589941043
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit ca6f62c83856ef95953118cd6c7bae7111c1795b (Sat Feb 22 10:21:50 UTC 2020)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services