You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/09/01 06:52:48 UTC
[GitHub] [cloudstack-primate] Pearl1594 opened a new pull request #649: Filter vms based on zones for attaching volumes
Pearl1594 opened a new pull request #649:
URL: https://github.com/apache/cloudstack-primate/pull/649
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #649: Filter vms based on zones for attaching volumes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #649:
URL: https://github.com/apache/cloudstack-primate/pull/649#issuecomment-688915780
@Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #649: Filter vms based on zones for attaching volumes
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #649:
URL: https://github.com/apache/cloudstack-primate/pull/649#issuecomment-688158597
@davidjumani @Pearl1594 - can you advise if this works/break for a project view, thnx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #649: Filter vms based on zones for attaching volumes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #649:
URL: https://github.com/apache/cloudstack-primate/pull/649#issuecomment-684485550
@Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #649: Filter vms based on zones for attaching volumes
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #649:
URL: https://github.com/apache/cloudstack-primate/pull/649#issuecomment-686968184
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #649: Filter vms based on zones for attaching volumes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #649:
URL: https://github.com/apache/cloudstack-primate/pull/649#issuecomment-686972367
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/649 (JID-3425)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #649: Filter vms based on zones for attaching volumes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #649:
URL: https://github.com/apache/cloudstack-primate/pull/649#issuecomment-686907400
@Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #649: Filter vms based on zones for attaching volumes
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #649:
URL: https://github.com/apache/cloudstack-primate/pull/649#issuecomment-685673519
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #649: Filter vms based on zones for attaching volumes
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #649:
URL: https://github.com/apache/cloudstack-primate/pull/649#issuecomment-684483340
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #649: Filter vms based on zones for attaching volumes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #649:
URL: https://github.com/apache/cloudstack-primate/pull/649#issuecomment-684500471
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/649 (JID-3408)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #649: Filter vms based on zones for attaching volumes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #649:
URL: https://github.com/apache/cloudstack-primate/pull/649#issuecomment-689325055
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/649 (JID-3446)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #649: Filter vms based on zones for attaching volumes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #649:
URL: https://github.com/apache/cloudstack-primate/pull/649#issuecomment-686968443
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #649: Filter vms based on zones for attaching volumes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #649:
URL: https://github.com/apache/cloudstack-primate/pull/649#issuecomment-689439082
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/649 (JID-3448)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #649: Filter vms based on zones for attaching volumes
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #649:
URL: https://github.com/apache/cloudstack-primate/pull/649#discussion_r484818035
##########
File path: src/config/section/storage.js
##########
@@ -101,6 +101,26 @@ export default {
label: 'label.action.attach.disk',
message: 'message.confirm.attach.disk',
args: ['virtualmachineid'],
+ mapping: {
Review comment:
If we were to only show Vms in stopped/running state, then please create a new component
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #649: Filter vms based on zones for attaching volumes
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #649:
URL: https://github.com/apache/cloudstack-primate/pull/649#issuecomment-688915224
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #649: Filter vms based on zones for attaching volumes
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #649:
URL: https://github.com/apache/cloudstack-primate/pull/649#issuecomment-685446569
ping @davidjumani @Pearl1594 - can you advise if this works/break for a project view, thnx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #649: Filter vms based on zones for attaching volumes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #649:
URL: https://github.com/apache/cloudstack-primate/pull/649#issuecomment-688921886
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/649 (JID-3442)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on a change in pull request #649: Filter vms based on zones for attaching volumes
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #649:
URL: https://github.com/apache/cloudstack-primate/pull/649#discussion_r481901720
##########
File path: src/config/section/storage.js
##########
@@ -101,6 +101,12 @@ export default {
label: 'label.action.attach.disk',
message: 'message.confirm.attach.disk',
args: ['virtualmachineid'],
+ mapping: {
+ virtualmachineid: {
+ api: 'listVirtualMachines',
+ params: (record) => { return { zoneid: record.zoneid, domainid: record.domainid, account: record.account, hypervisor: record.hypervisor } }
Review comment:
This will require some additional checks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #649: Filter vms based on zones for attaching volumes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #649:
URL: https://github.com/apache/cloudstack-primate/pull/649#issuecomment-689433763
@Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #649: Filter vms based on zones for attaching volumes
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #649:
URL: https://github.com/apache/cloudstack-primate/pull/649#issuecomment-688159561
@rhtyd it works now for project view too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #649: Filter vms based on zones for attaching volumes
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #649:
URL: https://github.com/apache/cloudstack-primate/pull/649#discussion_r480935441
##########
File path: src/config/section/storage.js
##########
@@ -101,6 +101,12 @@ export default {
label: 'label.action.attach.disk',
message: 'message.confirm.attach.disk',
args: ['virtualmachineid'],
+ mapping: {
+ virtualmachineid: {
+ api: 'listVirtualMachines',
+ params: (record) => { return { zoneid: record.zoneid, domainid: record.domainid, account: record.account, hypervisor: record.hypervisor } }
Review comment:
@Pearl1594 can you check if this causes regression in case of a project; i.e. select a project and test the case and see if that works?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #649: Filter vms based on zones for attaching volumes
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #649:
URL: https://github.com/apache/cloudstack-primate/pull/649#issuecomment-689433255
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #649: Filter vms based on zones for attaching volumes
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #649:
URL: https://github.com/apache/cloudstack-primate/pull/649#issuecomment-688779313
@davidjumani can you review as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #649: Filter vms based on zones for attaching volumes
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #649:
URL: https://github.com/apache/cloudstack-primate/pull/649#issuecomment-689320721
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #649: Filter vms based on zones for attaching volumes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #649:
URL: https://github.com/apache/cloudstack-primate/pull/649#issuecomment-689321173
@Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #649: Filter vms based on zones for attaching volumes
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #649:
URL: https://github.com/apache/cloudstack-primate/pull/649
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org