You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Peter Major (JIRA)" <ji...@apache.org> on 2011/01/24 16:57:44 UTC

[jira] Created: (WICKET-3379) Allow custom timestamp strategies for resources

Allow custom timestamp strategies for resources
-----------------------------------------------

                 Key: WICKET-3379
                 URL: https://issues.apache.org/jira/browse/WICKET-3379
             Project: Wicket
          Issue Type: Improvement
          Components: wicket
            Reporter: Peter Major


Currently the timestamp is appended to filenames if caching is enabled, like <filename>-ts<epoch>.<extension>
During the process of migrating wicketstuff-tinymce to Wicket 1.5 it occured to me, that tinymce recognizes it's baseurl based on it's filename:
https://github.com/wicketstuff/core/blob/master/jdk-1.5-parent/tinymce-parent/tinymce/src/main/java/wicket/contrib/tinymce/tiny_mce/tiny_mce_src.js#L53

It would be nice if the cache naming strategy would be pluggable, so by implementing a class you could actually have resources like: <filename>.<extension>?<epoch>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-3379) Allow custom timestamp strategies for resources

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985758#action_12985758 ] 

Martin Grigorov commented on WICKET-3379:
-----------------------------------------

Hm.
Now tinymce will expect url like : <filename>.ext?<epoch>, another component library will expect <filename>-ts<epoch>.js and these two cannot be used together in one application...

> Allow custom timestamp strategies for resources
> -----------------------------------------------
>
>                 Key: WICKET-3379
>                 URL: https://issues.apache.org/jira/browse/WICKET-3379
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Peter Major
>
> Currently the timestamp is appended to filenames if caching is enabled, like <filename>-ts<epoch>.<extension>
> During the process of migrating wicketstuff-tinymce to Wicket 1.5 it occured to me, that tinymce recognizes it's baseurl based on it's filename:
> https://github.com/wicketstuff/core/blob/master/jdk-1.5-parent/tinymce-parent/tinymce/src/main/java/wicket/contrib/tinymce/tiny_mce/tiny_mce_src.js#L53
> It would be nice if the cache naming strategy would be pluggable, so by implementing a class you could actually have resources like: <filename>.<extension>?<epoch>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-3379) Allow custom timestamp strategies for resources

Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986722#action_12986722 ] 

Peter Ertl commented on WICKET-3379:
------------------------------------

Please take a look at WICKET-3389 which should fix that issue

> Allow custom timestamp strategies for resources
> -----------------------------------------------
>
>                 Key: WICKET-3379
>                 URL: https://issues.apache.org/jira/browse/WICKET-3379
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Peter Major
>
> Currently the timestamp is appended to filenames if caching is enabled, like <filename>-ts<epoch>.<extension>
> During the process of migrating wicketstuff-tinymce to Wicket 1.5 it occured to me, that tinymce recognizes it's baseurl based on it's filename:
> https://github.com/wicketstuff/core/blob/master/jdk-1.5-parent/tinymce-parent/tinymce/src/main/java/wicket/contrib/tinymce/tiny_mce/tiny_mce_src.js#L53
> It would be nice if the cache naming strategy would be pluggable, so by implementing a class you could actually have resources like: <filename>.<extension>?<epoch>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-3379) Allow custom timestamp strategies for resources

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985769#action_12985769 ] 

Igor Vaynberg commented on WICKET-3379:
---------------------------------------

i dont think any library will expect -ts<epoch>. i think all libraries have to deal with the fact that their script will be served with a query string.

anyways, i dont think we need to go as far as needing custom strategies. the caching setting should simply be an enum with off/filename/querystring

> Allow custom timestamp strategies for resources
> -----------------------------------------------
>
>                 Key: WICKET-3379
>                 URL: https://issues.apache.org/jira/browse/WICKET-3379
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Peter Major
>
> Currently the timestamp is appended to filenames if caching is enabled, like <filename>-ts<epoch>.<extension>
> During the process of migrating wicketstuff-tinymce to Wicket 1.5 it occured to me, that tinymce recognizes it's baseurl based on it's filename:
> https://github.com/wicketstuff/core/blob/master/jdk-1.5-parent/tinymce-parent/tinymce/src/main/java/wicket/contrib/tinymce/tiny_mce/tiny_mce_src.js#L53
> It would be nice if the cache naming strategy would be pluggable, so by implementing a class you could actually have resources like: <filename>.<extension>?<epoch>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-3379) Allow custom timestamp strategies for resources

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov resolved WICKET-3379.
-------------------------------------

    Resolution: Duplicate
      Assignee: Peter Ertl

Duplicate of WICKET-3389

> Allow custom timestamp strategies for resources
> -----------------------------------------------
>
>                 Key: WICKET-3379
>                 URL: https://issues.apache.org/jira/browse/WICKET-3379
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Peter Major
>            Assignee: Peter Ertl
>
> Currently the timestamp is appended to filenames if caching is enabled, like <filename>-ts<epoch>.<extension>
> During the process of migrating wicketstuff-tinymce to Wicket 1.5 it occured to me, that tinymce recognizes it's baseurl based on it's filename:
> https://github.com/wicketstuff/core/blob/master/jdk-1.5-parent/tinymce-parent/tinymce/src/main/java/wicket/contrib/tinymce/tiny_mce/tiny_mce_src.js#L53
> It would be nice if the cache naming strategy would be pluggable, so by implementing a class you could actually have resources like: <filename>.<extension>?<epoch>

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (WICKET-3379) Allow custom timestamp strategies for resources

Posted by "Peter Major (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985767#action_12985767 ] 

Peter Major commented on WICKET-3379:
-------------------------------------

Then the solution could be to set a default timestamp naming strategy in Application, and you can override it through a ResourceReference. What about that?

> Allow custom timestamp strategies for resources
> -----------------------------------------------
>
>                 Key: WICKET-3379
>                 URL: https://issues.apache.org/jira/browse/WICKET-3379
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Peter Major
>
> Currently the timestamp is appended to filenames if caching is enabled, like <filename>-ts<epoch>.<extension>
> During the process of migrating wicketstuff-tinymce to Wicket 1.5 it occured to me, that tinymce recognizes it's baseurl based on it's filename:
> https://github.com/wicketstuff/core/blob/master/jdk-1.5-parent/tinymce-parent/tinymce/src/main/java/wicket/contrib/tinymce/tiny_mce/tiny_mce_src.js#L53
> It would be nice if the cache naming strategy would be pluggable, so by implementing a class you could actually have resources like: <filename>.<extension>?<epoch>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (WICKET-3379) Allow custom timestamp strategies for resources

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985758#action_12985758 ] 

Martin Grigorov edited comment on WICKET-3379 at 1/24/11 11:02 AM:
-------------------------------------------------------------------

Hm.
Now tinymce will expect url like : <filename>.ext?<epoch>, another component library will expect <filename>-ts<epoch>.js and these two cannot be used together in one application...

This is if the strategy is on application level, of course.

      was (Author: mgrigorov):
    Hm.
Now tinymce will expect url like : <filename>.ext?<epoch>, another component library will expect <filename>-ts<epoch>.js and these two cannot be used together in one application...
  
> Allow custom timestamp strategies for resources
> -----------------------------------------------
>
>                 Key: WICKET-3379
>                 URL: https://issues.apache.org/jira/browse/WICKET-3379
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Peter Major
>
> Currently the timestamp is appended to filenames if caching is enabled, like <filename>-ts<epoch>.<extension>
> During the process of migrating wicketstuff-tinymce to Wicket 1.5 it occured to me, that tinymce recognizes it's baseurl based on it's filename:
> https://github.com/wicketstuff/core/blob/master/jdk-1.5-parent/tinymce-parent/tinymce/src/main/java/wicket/contrib/tinymce/tiny_mce/tiny_mce_src.js#L53
> It would be nice if the cache naming strategy would be pluggable, so by implementing a class you could actually have resources like: <filename>.<extension>?<epoch>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-3379) Allow custom timestamp strategies for resources

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985770#action_12985770 ] 

Igor Vaynberg commented on WICKET-3379:
---------------------------------------

either that or we have to be smart enough to strip ts<epoch> inside paths, not just in the filename

> Allow custom timestamp strategies for resources
> -----------------------------------------------
>
>                 Key: WICKET-3379
>                 URL: https://issues.apache.org/jira/browse/WICKET-3379
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Peter Major
>
> Currently the timestamp is appended to filenames if caching is enabled, like <filename>-ts<epoch>.<extension>
> During the process of migrating wicketstuff-tinymce to Wicket 1.5 it occured to me, that tinymce recognizes it's baseurl based on it's filename:
> https://github.com/wicketstuff/core/blob/master/jdk-1.5-parent/tinymce-parent/tinymce/src/main/java/wicket/contrib/tinymce/tiny_mce/tiny_mce_src.js#L53
> It would be nice if the cache naming strategy would be pluggable, so by implementing a class you could actually have resources like: <filename>.<extension>?<epoch>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.