You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by daan Hoogland <da...@gmail.com> on 2013/05/07 15:33:46 UTC
Review Request: generalisation of network code (needed for CLOUDSTACK-1532)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10970/
-----------------------------------------------------------
Review request for cloudstack.
Description
-------
converting vlan id to uri to support a broader range of networks in for instance vpc gateway connections
Diffs
-----
api/src/com/cloud/agent/api/to/IpAddressTO.java 82c7d99
api/src/com/cloud/agent/api/to/NetworkTO.java 3edd4c0
api/src/com/cloud/network/NetworkService.java 5d4fd67
api/src/com/cloud/network/Networks.java f085e9f
api/src/com/cloud/network/vpc/PrivateIp.java eb68433
api/src/com/cloud/network/vpc/StaticRouteProfile.java 54aa6e4
api/src/com/cloud/network/vpc/VpcGateway.java e3530d0
api/src/com/cloud/network/vpc/VpcService.java 23e2764
api/src/org/apache/cloudstack/api/command/admin/vpc/CreatePrivateGatewayCmd.java 2055695
api/test/com/cloud/agent/api/to/NetworkTOTest.java PRE-CREATION
core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java b9bda4d
engine/schema/src/com/cloud/network/vpc/VpcGatewayVO.java e8dcb46
plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetaNetworkGuru.java 6d14e3f
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java b897df2
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 8fe8c88
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/OvsVifDriver.java 37761aa
plugins/hypervisors/ovm/src/com/cloud/ovm/hypervisor/OvmResourceBase.java a626e31
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 030eff0
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java bac361d
plugins/network-elements/cisco-vnmc/test/com/cloud/network/element/CiscoVnmcElementTest.java a16733b
plugins/network-elements/f5/src/com/cloud/network/resource/F5BigIpResource.java 1733712
plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java a0068c3
plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java 98e1461
plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java b1ecaac
server/src/com/cloud/api/ApiResponseHelper.java d7eaa26
server/src/com/cloud/configuration/ConfigurationManagerImpl.java 37ca793
server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java 4a90a77
server/src/com/cloud/network/ExternalLoadBalancerDeviceManagerImpl.java 686f5bc
server/src/com/cloud/network/ExternalLoadBalancerUsageManagerImpl.java d405382
server/src/com/cloud/network/NetworkManager.java 4af716c
server/src/com/cloud/network/NetworkManagerImpl.java a995661
server/src/com/cloud/network/NetworkServiceImpl.java 5e8be92
server/src/com/cloud/network/guru/PrivateNetworkGuru.java 2e266e7
server/src/com/cloud/network/guru/PublicNetworkGuru.java a83cdb3
server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java ebf2d42
server/src/com/cloud/network/vpc/PrivateGatewayProfile.java 20947db
server/src/com/cloud/network/vpc/PrivateIpAddress.java 2f3cf53
server/src/com/cloud/network/vpc/VpcManagerImpl.java a7f06e9
server/test/com/cloud/network/MockNetworkManagerImpl.java 2f717c8
server/test/com/cloud/vpc/MockNetworkManagerImpl.java f884ba1
server/test/com/cloud/vpc/MockVpcManagerImpl.java baccbd0
setup/db/db/schema-410to420.sql c8ac1ec
Diff: https://reviews.apache.org/r/10970/diff/
Testing
-------
Thanks,
daan Hoogland
Re: Review Request: generalisation of network code (needed for
CLOUDSTACK-1532)
Posted by daan Hoogland <da...@gmail.com>.
> On May 30, 2013, 8:56 a.m., Hugo Trippaers wrote:
> > Daan,
> >
> > I noticed quite a few tabs in your patch. The CloudStack standard is to use spaces instead of tabs. Can you change the patch to fix this?
> >
> > Other comments below.
> >
> > Can you explain what tests you executed to test the existing vlan functionality (besides the unittests)?
> >
tabs where removed (not rigorously)
I will submit a new patch for this and the pvlan configuration issue below.
aside from unit tests, manual testing of private gateway functionality (crud) has been performed for vlan flavor.
> On May 30, 2013, 8:56 a.m., Hugo Trippaers wrote:
> > api/src/com/cloud/network/Networks.java, line 94
> > <https://reviews.apache.org/r/10970/diff/4/?file=297128#file297128line94>
> >
> > Why not use value.getScheme() != null ?
a value can be a not=null string containing no ':', but for instance only a uuid/name/number. In these cases we want to load the scheme and the value into one uri
> On May 30, 2013, 8:56 a.m., Hugo Trippaers wrote:
> > core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java, line 639
> > <https://reviews.apache.org/r/10970/diff/4/?file=297135#file297135line639>
> >
> > Dead code can be removed.
will do
> On May 30, 2013, 8:56 a.m., Hugo Trippaers wrote:
> > server/src/com/cloud/api/ApiResponseHelper.java, line 1292
> > <https://reviews.apache.org/r/10970/diff/4/?file=297149#file297149line1292>
> >
> > Does this have anything to do anything with your changes?
unused but not my code -> reapplied
> On May 30, 2013, 8:56 a.m., Hugo Trippaers wrote:
> > server/src/com/cloud/api/ApiResponseHelper.java, line 2132
> > <https://reviews.apache.org/r/10970/diff/4/?file=297149#file297149line2132>
> >
> > Why did this need to go?
unused but not my code -> reapplied
> On May 30, 2013, 8:56 a.m., Hugo Trippaers wrote:
> > server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java, line 479
> > <https://reviews.apache.org/r/10970/diff/4/?file=297160#file297160line479>
> >
> > Did you answer this question? Why it it here?
removed comment
> On May 30, 2013, 8:56 a.m., Hugo Trippaers wrote:
> > server/src/com/cloud/configuration/ConfigurationManagerImpl.java, line 2711
> > <https://reviews.apache.org/r/10970/diff/4/?file=297150#file297150line2711>
> >
> > Is this split covered in your code?
created conditional on uri.scheme to allow for this split.
- daan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10970/#review21191
-----------------------------------------------------------
On May 28, 2013, 9:43 a.m., daan Hoogland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10970/
> -----------------------------------------------------------
>
> (Updated May 28, 2013, 9:43 a.m.)
>
>
> Review request for cloudstack, Murali Reddy, Hugo Trippaers, and Chiradeep Vittal.
>
>
> Description
> -------
>
> converting vlan id to uri to support a broader range of networks in for instance vpc gateway connections
>
>
> Diffs
> -----
>
> api/src/com/cloud/agent/api/to/IpAddressTO.java 82c7d99
> api/src/com/cloud/agent/api/to/NetworkTO.java 3edd4c0
> api/src/com/cloud/network/NetworkService.java 59702a2
> api/src/com/cloud/network/Networks.java 5aede05
> api/src/com/cloud/network/vpc/PrivateIp.java eb68433
> api/src/com/cloud/network/vpc/StaticRouteProfile.java 54aa6e4
> api/src/com/cloud/network/vpc/VpcGateway.java 5d278e9
> api/src/com/cloud/network/vpc/VpcService.java 7a444c0
> api/src/org/apache/cloudstack/api/command/admin/vpc/CreatePrivateGatewayCmd.java 22dfb9e
> api/src/org/apache/cloudstack/api/response/PrivateGatewayResponse.java c5c7df5
> core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 8b996d1
> engine/schema/src/com/cloud/network/vpc/VpcGatewayVO.java 7df2dfd
> plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetaNetworkGuru.java 6d14e3f
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java b897df2
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java f979cfe
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/OvsVifDriver.java eac3248
> plugins/hypervisors/ovm/src/com/cloud/ovm/hypervisor/OvmResourceBase.java a626e31
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 630d1b4
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 4680fde
> plugins/network-elements/cisco-vnmc/test/com/cloud/network/element/CiscoVnmcElementTest.java a16733b
> plugins/network-elements/f5/src/com/cloud/network/resource/F5BigIpResource.java 1733712
> plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java fd065d5
> plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java c0d4599
> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java b1ecaac
> server/src/com/cloud/api/ApiResponseHelper.java 89739cf
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 214e292
> server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java 9d24e47
> server/src/com/cloud/network/ExternalLoadBalancerDeviceManagerImpl.java f93bf7a
> server/src/com/cloud/network/ExternalLoadBalancerUsageManagerImpl.java 2c8031c
> server/src/com/cloud/network/NetworkManager.java 05bc26e
> server/src/com/cloud/network/NetworkManagerImpl.java 254510b
> server/src/com/cloud/network/NetworkServiceImpl.java 1533ca9
> server/src/com/cloud/network/guru/DirectPodBasedNetworkGuru.java cf27986
> server/src/com/cloud/network/guru/PrivateNetworkGuru.java 2e266e7
> server/src/com/cloud/network/guru/PublicNetworkGuru.java a83cdb3
> server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java 9992b7c
> server/src/com/cloud/network/vpc/PrivateGatewayProfile.java d6480cd
> server/src/com/cloud/network/vpc/PrivateIpAddress.java 2f3cf53
> server/src/com/cloud/network/vpc/VpcManagerImpl.java 1aab732
> server/test/com/cloud/network/CreatePrivateNetworkTest.java PRE-CREATION
> server/test/com/cloud/network/MockNetworkManagerImpl.java e5d34fb
> server/test/com/cloud/vpc/MockNetworkManagerImpl.java 7129273
> server/test/com/cloud/vpc/MockVpcManagerImpl.java 921321f
> setup/db/db/schema-410to420.sql 1c9a8c1
>
> Diff: https://reviews.apache.org/r/10970/diff/
>
>
> Testing
> -------
>
> the NetworkTO is tested to accept uris with several initial states.
> createPrivateNetwork in NetworkServiceImpl is tested (to accept only vlan or lswitch based networks for now)
> test code that used to use 'vlan://#' now uses 'vlan:#'
>
>
> Thanks,
>
> daan Hoogland
>
>
Re: Review Request: generalisation of network code (needed for
CLOUDSTACK-1532)
Posted by Hugo Trippaers <ht...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10970/#review21191
-----------------------------------------------------------
Daan,
I noticed quite a few tabs in your patch. The CloudStack standard is to use spaces instead of tabs. Can you change the patch to fix this?
Other comments below.
Can you explain what tests you executed to test the existing vlan functionality (besides the unittests)?
api/src/com/cloud/network/Networks.java
<https://reviews.apache.org/r/10970/#comment44007>
Why not use value.getScheme() != null ?
core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java
<https://reviews.apache.org/r/10970/#comment44008>
Dead code can be removed.
server/src/com/cloud/api/ApiResponseHelper.java
<https://reviews.apache.org/r/10970/#comment44009>
Does this have anything to do anything with your changes?
server/src/com/cloud/api/ApiResponseHelper.java
<https://reviews.apache.org/r/10970/#comment44010>
Why did this need to go?
server/src/com/cloud/configuration/ConfigurationManagerImpl.java
<https://reviews.apache.org/r/10970/#comment44011>
Is this split covered in your code?
server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java
<https://reviews.apache.org/r/10970/#comment44012>
Did you answer this question? Why it it here?
- Hugo Trippaers
On May 28, 2013, 9:43 a.m., daan Hoogland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10970/
> -----------------------------------------------------------
>
> (Updated May 28, 2013, 9:43 a.m.)
>
>
> Review request for cloudstack, Murali Reddy, Hugo Trippaers, and Chiradeep Vittal.
>
>
> Description
> -------
>
> converting vlan id to uri to support a broader range of networks in for instance vpc gateway connections
>
>
> Diffs
> -----
>
> api/src/com/cloud/agent/api/to/IpAddressTO.java 82c7d99
> api/src/com/cloud/agent/api/to/NetworkTO.java 3edd4c0
> api/src/com/cloud/network/NetworkService.java 59702a2
> api/src/com/cloud/network/Networks.java 5aede05
> api/src/com/cloud/network/vpc/PrivateIp.java eb68433
> api/src/com/cloud/network/vpc/StaticRouteProfile.java 54aa6e4
> api/src/com/cloud/network/vpc/VpcGateway.java 5d278e9
> api/src/com/cloud/network/vpc/VpcService.java 7a444c0
> api/src/org/apache/cloudstack/api/command/admin/vpc/CreatePrivateGatewayCmd.java 22dfb9e
> api/src/org/apache/cloudstack/api/response/PrivateGatewayResponse.java c5c7df5
> core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 8b996d1
> engine/schema/src/com/cloud/network/vpc/VpcGatewayVO.java 7df2dfd
> plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetaNetworkGuru.java 6d14e3f
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java b897df2
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java f979cfe
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/OvsVifDriver.java eac3248
> plugins/hypervisors/ovm/src/com/cloud/ovm/hypervisor/OvmResourceBase.java a626e31
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 630d1b4
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 4680fde
> plugins/network-elements/cisco-vnmc/test/com/cloud/network/element/CiscoVnmcElementTest.java a16733b
> plugins/network-elements/f5/src/com/cloud/network/resource/F5BigIpResource.java 1733712
> plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java fd065d5
> plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java c0d4599
> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java b1ecaac
> server/src/com/cloud/api/ApiResponseHelper.java 89739cf
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 214e292
> server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java 9d24e47
> server/src/com/cloud/network/ExternalLoadBalancerDeviceManagerImpl.java f93bf7a
> server/src/com/cloud/network/ExternalLoadBalancerUsageManagerImpl.java 2c8031c
> server/src/com/cloud/network/NetworkManager.java 05bc26e
> server/src/com/cloud/network/NetworkManagerImpl.java 254510b
> server/src/com/cloud/network/NetworkServiceImpl.java 1533ca9
> server/src/com/cloud/network/guru/DirectPodBasedNetworkGuru.java cf27986
> server/src/com/cloud/network/guru/PrivateNetworkGuru.java 2e266e7
> server/src/com/cloud/network/guru/PublicNetworkGuru.java a83cdb3
> server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java 9992b7c
> server/src/com/cloud/network/vpc/PrivateGatewayProfile.java d6480cd
> server/src/com/cloud/network/vpc/PrivateIpAddress.java 2f3cf53
> server/src/com/cloud/network/vpc/VpcManagerImpl.java 1aab732
> server/test/com/cloud/network/CreatePrivateNetworkTest.java PRE-CREATION
> server/test/com/cloud/network/MockNetworkManagerImpl.java e5d34fb
> server/test/com/cloud/vpc/MockNetworkManagerImpl.java 7129273
> server/test/com/cloud/vpc/MockVpcManagerImpl.java 921321f
> setup/db/db/schema-410to420.sql 1c9a8c1
>
> Diff: https://reviews.apache.org/r/10970/diff/
>
>
> Testing
> -------
>
> the NetworkTO is tested to accept uris with several initial states.
> createPrivateNetwork in NetworkServiceImpl is tested (to accept only vlan or lswitch based networks for now)
> test code that used to use 'vlan://#' now uses 'vlan:#'
>
>
> Thanks,
>
> daan Hoogland
>
>
Re: Review Request: generalisation of network code (needed for
CLOUDSTACK-1532)
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10970/
-----------------------------------------------------------
(Updated June 13, 2013, 1:09 p.m.)
Review request for cloudstack, Murali Reddy, Hugo Trippaers, and Chiradeep Vittal.
Changes
-------
added test scenario's that where used to develop the code
uploaded yet another rebased version diff
Description
-------
converting vlan id to uri to support a broader range of networks in for instance vpc gateway connections
Diffs (updated)
-----
api/src/com/cloud/agent/api/to/IpAddressTO.java 82c7d99
api/src/com/cloud/agent/api/to/NetworkTO.java 3edd4c0
api/src/com/cloud/network/NetworkService.java 405cecd
api/src/com/cloud/network/Networks.java 5aede05
api/src/com/cloud/network/vpc/PrivateIp.java eb68433
api/src/com/cloud/network/vpc/StaticRouteProfile.java 54aa6e4
api/src/com/cloud/network/vpc/VpcGateway.java 5d278e9
api/src/com/cloud/network/vpc/VpcService.java 7a444c0
api/src/org/apache/cloudstack/api/command/admin/vpc/CreatePrivateGatewayCmd.java 22dfb9e
api/src/org/apache/cloudstack/api/response/PrivateGatewayResponse.java c5c7df5
core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java dae1c85
engine/schema/src/com/cloud/network/vpc/VpcGatewayVO.java 7df2dfd
plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetaNetworkGuru.java 6d14e3f
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java b897df2
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java bab53bc
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/OvsVifDriver.java eac3248
plugins/hypervisors/ovm/src/com/cloud/ovm/hypervisor/OvmResourceBase.java a626e31
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 1af4239
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 5e8283a
plugins/network-elements/cisco-vnmc/src/com/cloud/network/element/CiscoVnmcElement.java 553325c
plugins/network-elements/cisco-vnmc/test/com/cloud/network/element/CiscoVnmcElementTest.java a16733b
plugins/network-elements/f5/src/com/cloud/network/resource/F5BigIpResource.java 1733712
plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java fd065d5
plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java 263e13b
plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java b1ecaac
server/src/com/cloud/api/ApiResponseHelper.java 94c5d6c
server/src/com/cloud/configuration/ConfigurationManagerImpl.java b684e01
server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java 9b190aa
server/src/com/cloud/network/ExternalLoadBalancerDeviceManagerImpl.java 829ad3f
server/src/com/cloud/network/ExternalLoadBalancerUsageManagerImpl.java 2c8031c
server/src/com/cloud/network/NetworkManager.java bc43daa
server/src/com/cloud/network/NetworkManagerImpl.java d6a6450
server/src/com/cloud/network/NetworkServiceImpl.java 024c969
server/src/com/cloud/network/guru/DirectPodBasedNetworkGuru.java f21e352
server/src/com/cloud/network/guru/PrivateNetworkGuru.java 2e266e7
server/src/com/cloud/network/guru/PublicNetworkGuru.java a83cdb3
server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java 7115499
server/src/com/cloud/network/vpc/PrivateGatewayProfile.java d6480cd
server/src/com/cloud/network/vpc/PrivateIpAddress.java 2f3cf53
server/src/com/cloud/network/vpc/VpcManagerImpl.java b41003a
server/test/com/cloud/network/CreatePrivateNetworkTest.java PRE-CREATION
server/test/com/cloud/network/MockNetworkManagerImpl.java 077395f
server/test/com/cloud/vpc/MockNetworkManagerImpl.java b609022
server/test/com/cloud/vpc/MockVpcManagerImpl.java 7e40083
setup/db/db/schema-410to420.sql bcfbcc9
Diff: https://reviews.apache.org/r/10970/diff/
Testing
-------
the NetworkTO is tested to accept uris with several initial states.
createPrivateNetwork in NetworkServiceImpl is tested (to accept only vlan or lswitch based networks for now)
test code that used to use 'vlan://#' now uses 'vlan:#'
Thanks,
daan Hoogland
Re: Review Request: generalisation of network code (needed for
CLOUDSTACK-1532)
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10970/
-----------------------------------------------------------
(Updated June 10, 2013, 9:20 a.m.)
Review request for cloudstack, Murali Reddy, Hugo Trippaers, and Chiradeep Vittal.
Changes
-------
getHost() changed to getSchemeSpecificPart() in CiscoVnmcElement
Description
-------
converting vlan id to uri to support a broader range of networks in for instance vpc gateway connections
Diffs (updated)
-----
api/src/com/cloud/agent/api/to/IpAddressTO.java 82c7d99
api/src/com/cloud/agent/api/to/NetworkTO.java 3edd4c0
api/src/com/cloud/network/NetworkService.java 405cecd
api/src/com/cloud/network/Networks.java 5aede05
api/src/com/cloud/network/vpc/PrivateIp.java eb68433
api/src/com/cloud/network/vpc/StaticRouteProfile.java 54aa6e4
api/src/com/cloud/network/vpc/VpcGateway.java 5d278e9
api/src/com/cloud/network/vpc/VpcService.java 7a444c0
api/src/org/apache/cloudstack/api/command/admin/vpc/CreatePrivateGatewayCmd.java 22dfb9e
api/src/org/apache/cloudstack/api/response/PrivateGatewayResponse.java c5c7df5
core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 8b996d1
engine/schema/src/com/cloud/network/vpc/VpcGatewayVO.java 7df2dfd
plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetaNetworkGuru.java 6d14e3f
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java b897df2
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java f979cfe
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/OvsVifDriver.java eac3248
plugins/hypervisors/ovm/src/com/cloud/ovm/hypervisor/OvmResourceBase.java a626e31
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 0a15d4b
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 7626d12
plugins/network-elements/cisco-vnmc/src/com/cloud/network/element/CiscoVnmcElement.java 9118bad
plugins/network-elements/cisco-vnmc/test/com/cloud/network/element/CiscoVnmcElementTest.java a16733b
plugins/network-elements/f5/src/com/cloud/network/resource/F5BigIpResource.java 1733712
plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java fd065d5
plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java c0d4599
plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java b1ecaac
server/src/com/cloud/api/ApiResponseHelper.java cf79ff8
server/src/com/cloud/configuration/ConfigurationManagerImpl.java 59e70cf
server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java 9d24e47
server/src/com/cloud/network/ExternalLoadBalancerDeviceManagerImpl.java 04f9682
server/src/com/cloud/network/ExternalLoadBalancerUsageManagerImpl.java 2c8031c
server/src/com/cloud/network/NetworkManager.java 8627251
server/src/com/cloud/network/NetworkManagerImpl.java b92ef4b
server/src/com/cloud/network/NetworkServiceImpl.java 9899284
server/src/com/cloud/network/guru/DirectPodBasedNetworkGuru.java cf27986
server/src/com/cloud/network/guru/PrivateNetworkGuru.java 2e266e7
server/src/com/cloud/network/guru/PublicNetworkGuru.java a83cdb3
server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java 9992b7c
server/src/com/cloud/network/vpc/PrivateGatewayProfile.java d6480cd
server/src/com/cloud/network/vpc/PrivateIpAddress.java 2f3cf53
server/src/com/cloud/network/vpc/VpcManagerImpl.java 380a95e
server/test/com/cloud/network/CreatePrivateNetworkTest.java PRE-CREATION
server/test/com/cloud/network/MockNetworkManagerImpl.java 7ab322b
server/test/com/cloud/vpc/MockNetworkManagerImpl.java d46be7c
server/test/com/cloud/vpc/MockVpcManagerImpl.java 921321f
setup/db/db/schema-410to420.sql 196706f
Diff: https://reviews.apache.org/r/10970/diff/
Testing
-------
the NetworkTO is tested to accept uris with several initial states.
createPrivateNetwork in NetworkServiceImpl is tested (to accept only vlan or lswitch based networks for now)
test code that used to use 'vlan://#' now uses 'vlan:#'
Thanks,
daan Hoogland
Re: Review Request: generalisation of network code (needed for
CLOUDSTACK-1532)
Posted by Hugo Trippaers <ht...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10970/#review21417
-----------------------------------------------------------
plugins/network-elements/cisco-vnmc/test/com/cloud/network/element/CiscoVnmcElementTest.java
<https://reviews.apache.org/r/10970/#comment44340>
Daan,
The change from vlan://# to vlan:# introduces problems in other parts of the code. Quite regularly the URI.getHost() function is used. This function will return null when the URI is vlan:# instead of returning the vlanid when the URI is vlan://#.
This needs to be fixed before we can commit this change.
- Hugo Trippaers
On May 30, 2013, 11:58 a.m., daan Hoogland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10970/
> -----------------------------------------------------------
>
> (Updated May 30, 2013, 11:58 a.m.)
>
>
> Review request for cloudstack, Murali Reddy, Hugo Trippaers, and Chiradeep Vittal.
>
>
> Description
> -------
>
> converting vlan id to uri to support a broader range of networks in for instance vpc gateway connections
>
>
> Diffs
> -----
>
> api/src/com/cloud/agent/api/to/IpAddressTO.java 82c7d99
> api/src/com/cloud/agent/api/to/NetworkTO.java 3edd4c0
> api/src/com/cloud/network/NetworkService.java 405cecd
> api/src/com/cloud/network/Networks.java 5aede05
> api/src/com/cloud/network/vpc/PrivateIp.java eb68433
> api/src/com/cloud/network/vpc/StaticRouteProfile.java 54aa6e4
> api/src/com/cloud/network/vpc/VpcGateway.java 5d278e9
> api/src/com/cloud/network/vpc/VpcService.java 7a444c0
> api/src/org/apache/cloudstack/api/command/admin/vpc/CreatePrivateGatewayCmd.java 22dfb9e
> api/src/org/apache/cloudstack/api/response/PrivateGatewayResponse.java c5c7df5
> core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 8b996d1
> engine/schema/src/com/cloud/network/vpc/VpcGatewayVO.java 7df2dfd
> plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetaNetworkGuru.java 6d14e3f
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java b897df2
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java f979cfe
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/OvsVifDriver.java eac3248
> plugins/hypervisors/ovm/src/com/cloud/ovm/hypervisor/OvmResourceBase.java a626e31
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 0a15d4b
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 7626d12
> plugins/network-elements/cisco-vnmc/test/com/cloud/network/element/CiscoVnmcElementTest.java a16733b
> plugins/network-elements/f5/src/com/cloud/network/resource/F5BigIpResource.java 1733712
> plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java fd065d5
> plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java c0d4599
> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java b1ecaac
> server/src/com/cloud/api/ApiResponseHelper.java cf79ff8
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 59e70cf
> server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java 9d24e47
> server/src/com/cloud/network/ExternalLoadBalancerDeviceManagerImpl.java 04f9682
> server/src/com/cloud/network/ExternalLoadBalancerUsageManagerImpl.java 2c8031c
> server/src/com/cloud/network/NetworkManager.java 8627251
> server/src/com/cloud/network/NetworkManagerImpl.java b92ef4b
> server/src/com/cloud/network/NetworkServiceImpl.java 9899284
> server/src/com/cloud/network/guru/DirectPodBasedNetworkGuru.java cf27986
> server/src/com/cloud/network/guru/PrivateNetworkGuru.java 2e266e7
> server/src/com/cloud/network/guru/PublicNetworkGuru.java a83cdb3
> server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java 9992b7c
> server/src/com/cloud/network/vpc/PrivateGatewayProfile.java d6480cd
> server/src/com/cloud/network/vpc/PrivateIpAddress.java 2f3cf53
> server/src/com/cloud/network/vpc/VpcManagerImpl.java 380a95e
> server/test/com/cloud/network/CreatePrivateNetworkTest.java PRE-CREATION
> server/test/com/cloud/network/MockNetworkManagerImpl.java 7ab322b
> server/test/com/cloud/vpc/MockNetworkManagerImpl.java d46be7c
> server/test/com/cloud/vpc/MockVpcManagerImpl.java 921321f
> setup/db/db/schema-410to420.sql 196706f
>
> Diff: https://reviews.apache.org/r/10970/diff/
>
>
> Testing
> -------
>
> the NetworkTO is tested to accept uris with several initial states.
> createPrivateNetwork in NetworkServiceImpl is tested (to accept only vlan or lswitch based networks for now)
> test code that used to use 'vlan://#' now uses 'vlan:#'
>
>
> Thanks,
>
> daan Hoogland
>
>
Re: Review Request: generalisation of network code (needed for
CLOUDSTACK-1532)
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10970/
-----------------------------------------------------------
(Updated May 30, 2013, 11:58 a.m.)
Review request for cloudstack, Murali Reddy, Hugo Trippaers, and Chiradeep Vittal.
Changes
-------
applied comment on pvlan configuration and fixed some formatting
Description
-------
converting vlan id to uri to support a broader range of networks in for instance vpc gateway connections
Diffs (updated)
-----
api/src/com/cloud/agent/api/to/IpAddressTO.java 82c7d99
api/src/com/cloud/agent/api/to/NetworkTO.java 3edd4c0
api/src/com/cloud/network/NetworkService.java 405cecd
api/src/com/cloud/network/Networks.java 5aede05
api/src/com/cloud/network/vpc/PrivateIp.java eb68433
api/src/com/cloud/network/vpc/StaticRouteProfile.java 54aa6e4
api/src/com/cloud/network/vpc/VpcGateway.java 5d278e9
api/src/com/cloud/network/vpc/VpcService.java 7a444c0
api/src/org/apache/cloudstack/api/command/admin/vpc/CreatePrivateGatewayCmd.java 22dfb9e
api/src/org/apache/cloudstack/api/response/PrivateGatewayResponse.java c5c7df5
core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 8b996d1
engine/schema/src/com/cloud/network/vpc/VpcGatewayVO.java 7df2dfd
plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetaNetworkGuru.java 6d14e3f
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java b897df2
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java f979cfe
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/OvsVifDriver.java eac3248
plugins/hypervisors/ovm/src/com/cloud/ovm/hypervisor/OvmResourceBase.java a626e31
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 0a15d4b
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 7626d12
plugins/network-elements/cisco-vnmc/test/com/cloud/network/element/CiscoVnmcElementTest.java a16733b
plugins/network-elements/f5/src/com/cloud/network/resource/F5BigIpResource.java 1733712
plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java fd065d5
plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java c0d4599
plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java b1ecaac
server/src/com/cloud/api/ApiResponseHelper.java cf79ff8
server/src/com/cloud/configuration/ConfigurationManagerImpl.java 59e70cf
server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java 9d24e47
server/src/com/cloud/network/ExternalLoadBalancerDeviceManagerImpl.java 04f9682
server/src/com/cloud/network/ExternalLoadBalancerUsageManagerImpl.java 2c8031c
server/src/com/cloud/network/NetworkManager.java 8627251
server/src/com/cloud/network/NetworkManagerImpl.java b92ef4b
server/src/com/cloud/network/NetworkServiceImpl.java 9899284
server/src/com/cloud/network/guru/DirectPodBasedNetworkGuru.java cf27986
server/src/com/cloud/network/guru/PrivateNetworkGuru.java 2e266e7
server/src/com/cloud/network/guru/PublicNetworkGuru.java a83cdb3
server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java 9992b7c
server/src/com/cloud/network/vpc/PrivateGatewayProfile.java d6480cd
server/src/com/cloud/network/vpc/PrivateIpAddress.java 2f3cf53
server/src/com/cloud/network/vpc/VpcManagerImpl.java 380a95e
server/test/com/cloud/network/CreatePrivateNetworkTest.java PRE-CREATION
server/test/com/cloud/network/MockNetworkManagerImpl.java 7ab322b
server/test/com/cloud/vpc/MockNetworkManagerImpl.java d46be7c
server/test/com/cloud/vpc/MockVpcManagerImpl.java 921321f
setup/db/db/schema-410to420.sql 196706f
Diff: https://reviews.apache.org/r/10970/diff/
Testing
-------
the NetworkTO is tested to accept uris with several initial states.
createPrivateNetwork in NetworkServiceImpl is tested (to accept only vlan or lswitch based networks for now)
test code that used to use 'vlan://#' now uses 'vlan:#'
Thanks,
daan Hoogland
Re: Review Request: generalisation of network code (needed for
CLOUDSTACK-1532)
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10970/
-----------------------------------------------------------
(Updated May 28, 2013, 9:43 a.m.)
Review request for cloudstack, Murali Reddy, Hugo Trippaers, and Chiradeep Vittal.
Changes
-------
on request
Description
-------
converting vlan id to uri to support a broader range of networks in for instance vpc gateway connections
Diffs
-----
api/src/com/cloud/agent/api/to/IpAddressTO.java 82c7d99
api/src/com/cloud/agent/api/to/NetworkTO.java 3edd4c0
api/src/com/cloud/network/NetworkService.java 59702a2
api/src/com/cloud/network/Networks.java 5aede05
api/src/com/cloud/network/vpc/PrivateIp.java eb68433
api/src/com/cloud/network/vpc/StaticRouteProfile.java 54aa6e4
api/src/com/cloud/network/vpc/VpcGateway.java 5d278e9
api/src/com/cloud/network/vpc/VpcService.java 7a444c0
api/src/org/apache/cloudstack/api/command/admin/vpc/CreatePrivateGatewayCmd.java 22dfb9e
api/src/org/apache/cloudstack/api/response/PrivateGatewayResponse.java c5c7df5
core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 8b996d1
engine/schema/src/com/cloud/network/vpc/VpcGatewayVO.java 7df2dfd
plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetaNetworkGuru.java 6d14e3f
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java b897df2
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java f979cfe
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/OvsVifDriver.java eac3248
plugins/hypervisors/ovm/src/com/cloud/ovm/hypervisor/OvmResourceBase.java a626e31
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 630d1b4
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 4680fde
plugins/network-elements/cisco-vnmc/test/com/cloud/network/element/CiscoVnmcElementTest.java a16733b
plugins/network-elements/f5/src/com/cloud/network/resource/F5BigIpResource.java 1733712
plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java fd065d5
plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java c0d4599
plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java b1ecaac
server/src/com/cloud/api/ApiResponseHelper.java 89739cf
server/src/com/cloud/configuration/ConfigurationManagerImpl.java 214e292
server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java 9d24e47
server/src/com/cloud/network/ExternalLoadBalancerDeviceManagerImpl.java f93bf7a
server/src/com/cloud/network/ExternalLoadBalancerUsageManagerImpl.java 2c8031c
server/src/com/cloud/network/NetworkManager.java 05bc26e
server/src/com/cloud/network/NetworkManagerImpl.java 254510b
server/src/com/cloud/network/NetworkServiceImpl.java 1533ca9
server/src/com/cloud/network/guru/DirectPodBasedNetworkGuru.java cf27986
server/src/com/cloud/network/guru/PrivateNetworkGuru.java 2e266e7
server/src/com/cloud/network/guru/PublicNetworkGuru.java a83cdb3
server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java 9992b7c
server/src/com/cloud/network/vpc/PrivateGatewayProfile.java d6480cd
server/src/com/cloud/network/vpc/PrivateIpAddress.java 2f3cf53
server/src/com/cloud/network/vpc/VpcManagerImpl.java 1aab732
server/test/com/cloud/network/CreatePrivateNetworkTest.java PRE-CREATION
server/test/com/cloud/network/MockNetworkManagerImpl.java e5d34fb
server/test/com/cloud/vpc/MockNetworkManagerImpl.java 7129273
server/test/com/cloud/vpc/MockVpcManagerImpl.java 921321f
setup/db/db/schema-410to420.sql 1c9a8c1
Diff: https://reviews.apache.org/r/10970/diff/
Testing
-------
the NetworkTO is tested to accept uris with several initial states.
createPrivateNetwork in NetworkServiceImpl is tested (to accept only vlan or lswitch based networks for now)
test code that used to use 'vlan://#' now uses 'vlan:#'
Thanks,
daan Hoogland
Re: Review Request: generalisation of network code (needed for
CLOUDSTACK-1532)
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10970/
-----------------------------------------------------------
(Updated May 28, 2013, 9:29 a.m.)
Review request for cloudstack, Murali Reddy and Hugo Trippaers.
Changes
-------
enabled the lswitch variant
Description
-------
converting vlan id to uri to support a broader range of networks in for instance vpc gateway connections
Diffs (updated)
-----
api/src/com/cloud/agent/api/to/IpAddressTO.java 82c7d99
api/src/com/cloud/agent/api/to/NetworkTO.java 3edd4c0
api/src/com/cloud/network/NetworkService.java 59702a2
api/src/com/cloud/network/Networks.java 5aede05
api/src/com/cloud/network/vpc/PrivateIp.java eb68433
api/src/com/cloud/network/vpc/StaticRouteProfile.java 54aa6e4
api/src/com/cloud/network/vpc/VpcGateway.java 5d278e9
api/src/com/cloud/network/vpc/VpcService.java 7a444c0
api/src/org/apache/cloudstack/api/command/admin/vpc/CreatePrivateGatewayCmd.java 22dfb9e
api/src/org/apache/cloudstack/api/response/PrivateGatewayResponse.java c5c7df5
core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 8b996d1
engine/schema/src/com/cloud/network/vpc/VpcGatewayVO.java 7df2dfd
plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetaNetworkGuru.java 6d14e3f
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java b897df2
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java f979cfe
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/OvsVifDriver.java eac3248
plugins/hypervisors/ovm/src/com/cloud/ovm/hypervisor/OvmResourceBase.java a626e31
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 630d1b4
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 4680fde
plugins/network-elements/cisco-vnmc/test/com/cloud/network/element/CiscoVnmcElementTest.java a16733b
plugins/network-elements/f5/src/com/cloud/network/resource/F5BigIpResource.java 1733712
plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java fd065d5
plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java c0d4599
plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java b1ecaac
server/src/com/cloud/api/ApiResponseHelper.java 89739cf
server/src/com/cloud/configuration/ConfigurationManagerImpl.java 214e292
server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java 9d24e47
server/src/com/cloud/network/ExternalLoadBalancerDeviceManagerImpl.java f93bf7a
server/src/com/cloud/network/ExternalLoadBalancerUsageManagerImpl.java 2c8031c
server/src/com/cloud/network/NetworkManager.java 05bc26e
server/src/com/cloud/network/NetworkManagerImpl.java 254510b
server/src/com/cloud/network/NetworkServiceImpl.java 1533ca9
server/src/com/cloud/network/guru/DirectPodBasedNetworkGuru.java cf27986
server/src/com/cloud/network/guru/PrivateNetworkGuru.java 2e266e7
server/src/com/cloud/network/guru/PublicNetworkGuru.java a83cdb3
server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java 9992b7c
server/src/com/cloud/network/vpc/PrivateGatewayProfile.java d6480cd
server/src/com/cloud/network/vpc/PrivateIpAddress.java 2f3cf53
server/src/com/cloud/network/vpc/VpcManagerImpl.java 1aab732
server/test/com/cloud/network/CreatePrivateNetworkTest.java PRE-CREATION
server/test/com/cloud/network/MockNetworkManagerImpl.java e5d34fb
server/test/com/cloud/vpc/MockNetworkManagerImpl.java 7129273
server/test/com/cloud/vpc/MockVpcManagerImpl.java 921321f
setup/db/db/schema-410to420.sql 1c9a8c1
Diff: https://reviews.apache.org/r/10970/diff/
Testing (updated)
-------
the NetworkTO is tested to accept uris with several initial states.
createPrivateNetwork in NetworkServiceImpl is tested (to accept only vlan or lswitch based networks for now)
test code that used to use 'vlan://#' now uses 'vlan:#'
Thanks,
daan Hoogland
Re: Review Request: generalisation of network code (needed for
CLOUDSTACK-1532)
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10970/
-----------------------------------------------------------
(Updated May 22, 2013, 11:21 a.m.)
Review request for cloudstack, Murali Reddy and Hugo Trippaers.
Changes
-------
This one's a good change to have but since it touches quite a bit of networking code it'd be nice to run a few tests on this change. Hugo @SchuberPhillis runs an integrated jenkins suite - can you check with him to run the patch through that? I'm happy to run bvt tests on this too.
Description
-------
converting vlan id to uri to support a broader range of networks in for instance vpc gateway connections
Diffs
-----
api/src/com/cloud/agent/api/to/IpAddressTO.java 82c7d99
api/src/com/cloud/agent/api/to/NetworkTO.java 3edd4c0
api/src/com/cloud/network/NetworkService.java 5d4fd67
api/src/com/cloud/network/Networks.java f085e9f
api/src/com/cloud/network/vpc/PrivateIp.java eb68433
api/src/com/cloud/network/vpc/StaticRouteProfile.java 54aa6e4
api/src/com/cloud/network/vpc/VpcGateway.java e3530d0
api/src/com/cloud/network/vpc/VpcService.java 23e2764
api/src/org/apache/cloudstack/api/command/admin/vpc/CreatePrivateGatewayCmd.java 2055695
api/src/org/apache/cloudstack/api/response/PrivateGatewayResponse.java ca76062
api/test/com/cloud/agent/api/to/NetworkTOTest.java PRE-CREATION
core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java b9bda4d
engine/schema/src/com/cloud/network/vpc/VpcGatewayVO.java e8dcb46
plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetaNetworkGuru.java 6d14e3f
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java b897df2
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 8fe8c88
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/OvsVifDriver.java 37761aa
plugins/hypervisors/ovm/src/com/cloud/ovm/hypervisor/OvmResourceBase.java a626e31
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 030eff0
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java bac361d
plugins/network-elements/cisco-vnmc/test/com/cloud/network/element/CiscoVnmcElementTest.java a16733b
plugins/network-elements/f5/src/com/cloud/network/resource/F5BigIpResource.java 1733712
plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java a0068c3
plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java 98e1461
plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java b1ecaac
server/src/com/cloud/api/ApiResponseHelper.java d7eaa26
server/src/com/cloud/configuration/ConfigurationManagerImpl.java 37ca793
server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java 4a90a77
server/src/com/cloud/network/ExternalLoadBalancerDeviceManagerImpl.java 686f5bc
server/src/com/cloud/network/ExternalLoadBalancerUsageManagerImpl.java d405382
server/src/com/cloud/network/NetworkManager.java 4af716c
server/src/com/cloud/network/NetworkManagerImpl.java 4fffbc1
server/src/com/cloud/network/NetworkServiceImpl.java 5e8be92
server/src/com/cloud/network/guru/DirectPodBasedNetworkGuru.java cf27986
server/src/com/cloud/network/guru/PrivateNetworkGuru.java 2e266e7
server/src/com/cloud/network/guru/PublicNetworkGuru.java a83cdb3
server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java ebf2d42
server/src/com/cloud/network/vpc/PrivateGatewayProfile.java 20947db
server/src/com/cloud/network/vpc/PrivateIpAddress.java 2f3cf53
server/src/com/cloud/network/vpc/VpcManagerImpl.java a7f06e9
server/test/com/cloud/network/CreatePrivateNetworkTest.java PRE-CREATION
server/test/com/cloud/network/MockNetworkManagerImpl.java 2f717c8
server/test/com/cloud/vpc/MockNetworkManagerImpl.java f884ba1
server/test/com/cloud/vpc/MockVpcManagerImpl.java baccbd0
setup/db/db/schema-410to420.sql c8ac1ec
Diff: https://reviews.apache.org/r/10970/diff/
Testing
-------
the NetworkTO is tested to accept uris with several initial states.
createPrivateNetwork in NetworkServiceImpl is tested (to accpet only vlan based networks for now)
Thanks,
daan Hoogland
Re: Review Request: generalisation of network code (needed for
CLOUDSTACK-1532)
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10970/
-----------------------------------------------------------
(Updated May 9, 2013, 1:02 p.m.)
Review request for cloudstack.
Changes
-------
new diff file with some ommisions added
Description
-------
converting vlan id to uri to support a broader range of networks in for instance vpc gateway connections
Diffs (updated)
-----
api/src/com/cloud/agent/api/to/IpAddressTO.java 82c7d99
api/src/com/cloud/agent/api/to/NetworkTO.java 3edd4c0
api/src/com/cloud/network/NetworkService.java 5d4fd67
api/src/com/cloud/network/Networks.java f085e9f
api/src/com/cloud/network/vpc/PrivateIp.java eb68433
api/src/com/cloud/network/vpc/StaticRouteProfile.java 54aa6e4
api/src/com/cloud/network/vpc/VpcGateway.java e3530d0
api/src/com/cloud/network/vpc/VpcService.java 23e2764
api/src/org/apache/cloudstack/api/command/admin/vpc/CreatePrivateGatewayCmd.java 2055695
api/src/org/apache/cloudstack/api/response/PrivateGatewayResponse.java ca76062
api/test/com/cloud/agent/api/to/NetworkTOTest.java PRE-CREATION
core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java b9bda4d
engine/schema/src/com/cloud/network/vpc/VpcGatewayVO.java e8dcb46
plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetaNetworkGuru.java 6d14e3f
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java b897df2
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 8fe8c88
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/OvsVifDriver.java 37761aa
plugins/hypervisors/ovm/src/com/cloud/ovm/hypervisor/OvmResourceBase.java a626e31
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 030eff0
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java bac361d
plugins/network-elements/cisco-vnmc/test/com/cloud/network/element/CiscoVnmcElementTest.java a16733b
plugins/network-elements/f5/src/com/cloud/network/resource/F5BigIpResource.java 1733712
plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java a0068c3
plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java 98e1461
plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java b1ecaac
server/src/com/cloud/api/ApiResponseHelper.java d7eaa26
server/src/com/cloud/configuration/ConfigurationManagerImpl.java 37ca793
server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java 4a90a77
server/src/com/cloud/network/ExternalLoadBalancerDeviceManagerImpl.java 686f5bc
server/src/com/cloud/network/ExternalLoadBalancerUsageManagerImpl.java d405382
server/src/com/cloud/network/NetworkManager.java 4af716c
server/src/com/cloud/network/NetworkManagerImpl.java 4fffbc1
server/src/com/cloud/network/NetworkServiceImpl.java 5e8be92
server/src/com/cloud/network/guru/DirectPodBasedNetworkGuru.java cf27986
server/src/com/cloud/network/guru/PrivateNetworkGuru.java 2e266e7
server/src/com/cloud/network/guru/PublicNetworkGuru.java a83cdb3
server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java ebf2d42
server/src/com/cloud/network/vpc/PrivateGatewayProfile.java 20947db
server/src/com/cloud/network/vpc/PrivateIpAddress.java 2f3cf53
server/src/com/cloud/network/vpc/VpcManagerImpl.java a7f06e9
server/test/com/cloud/network/CreatePrivateNetworkTest.java PRE-CREATION
server/test/com/cloud/network/MockNetworkManagerImpl.java 2f717c8
server/test/com/cloud/vpc/MockNetworkManagerImpl.java f884ba1
server/test/com/cloud/vpc/MockVpcManagerImpl.java baccbd0
setup/db/db/schema-410to420.sql c8ac1ec
Diff: https://reviews.apache.org/r/10970/diff/
Testing (updated)
-------
the NetworkTO is tested to accept uris with several initial states.
createPrivateNetwork in NetworkServiceImpl is tested (to accpet only vlan based networks for now)
Thanks,
daan Hoogland
Re: Review Request: generalisation of network code (needed for
CLOUDSTACK-1532)
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10970/
-----------------------------------------------------------
(Updated May 8, 2013, 11:09 a.m.)
Review request for cloudstack.
Changes
-------
new diff file with some ommisions added
Description
-------
converting vlan id to uri to support a broader range of networks in for instance vpc gateway connections
Diffs (updated)
-----
api/src/com/cloud/agent/api/to/IpAddressTO.java 82c7d99
api/src/com/cloud/agent/api/to/NetworkTO.java 3edd4c0
api/src/com/cloud/network/NetworkService.java 5d4fd67
api/src/com/cloud/network/Networks.java f085e9f
api/src/com/cloud/network/vpc/PrivateIp.java eb68433
api/src/com/cloud/network/vpc/StaticRouteProfile.java 54aa6e4
api/src/com/cloud/network/vpc/VpcGateway.java e3530d0
api/src/com/cloud/network/vpc/VpcService.java 23e2764
api/src/org/apache/cloudstack/api/command/admin/vpc/CreatePrivateGatewayCmd.java 2055695
api/src/org/apache/cloudstack/api/response/PrivateGatewayResponse.java ca76062
api/test/com/cloud/agent/api/to/NetworkTOTest.java PRE-CREATION
core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java b9bda4d
engine/schema/src/com/cloud/network/vpc/VpcGatewayVO.java e8dcb46
plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetaNetworkGuru.java 6d14e3f
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java b897df2
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 8fe8c88
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/OvsVifDriver.java 37761aa
plugins/hypervisors/ovm/src/com/cloud/ovm/hypervisor/OvmResourceBase.java a626e31
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 030eff0
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java bac361d
plugins/network-elements/cisco-vnmc/test/com/cloud/network/element/CiscoVnmcElementTest.java a16733b
plugins/network-elements/f5/src/com/cloud/network/resource/F5BigIpResource.java 1733712
plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java a0068c3
plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java 98e1461
plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java b1ecaac
server/src/com/cloud/api/ApiResponseHelper.java d7eaa26
server/src/com/cloud/configuration/ConfigurationManagerImpl.java 37ca793
server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java 4a90a77
server/src/com/cloud/network/ExternalLoadBalancerDeviceManagerImpl.java 686f5bc
server/src/com/cloud/network/ExternalLoadBalancerUsageManagerImpl.java d405382
server/src/com/cloud/network/NetworkManager.java 4af716c
server/src/com/cloud/network/NetworkManagerImpl.java 4fffbc1
server/src/com/cloud/network/NetworkServiceImpl.java 5e8be92
server/src/com/cloud/network/guru/DirectPodBasedNetworkGuru.java cf27986
server/src/com/cloud/network/guru/PrivateNetworkGuru.java 2e266e7
server/src/com/cloud/network/guru/PublicNetworkGuru.java a83cdb3
server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java ebf2d42
server/src/com/cloud/network/vpc/PrivateGatewayProfile.java 20947db
server/src/com/cloud/network/vpc/PrivateIpAddress.java 2f3cf53
server/src/com/cloud/network/vpc/VpcManagerImpl.java a7f06e9
server/test/com/cloud/network/MockNetworkManagerImpl.java 2f717c8
server/test/com/cloud/vpc/MockNetworkManagerImpl.java f884ba1
server/test/com/cloud/vpc/MockVpcManagerImpl.java baccbd0
setup/db/db/schema-410to420.sql c8ac1ec
Diff: https://reviews.apache.org/r/10970/diff/
Testing
-------
Thanks,
daan Hoogland
Re: Review Request: generalisation of network code (needed for
CLOUDSTACK-1532)
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10970/
-----------------------------------------------------------
(Updated May 7, 2013, 1:33 p.m.)
Review request for cloudstack.
Description
-------
converting vlan id to uri to support a broader range of networks in for instance vpc gateway connections
Diffs
-----
api/src/com/cloud/agent/api/to/IpAddressTO.java 82c7d99
api/src/com/cloud/agent/api/to/NetworkTO.java 3edd4c0
api/src/com/cloud/network/NetworkService.java 5d4fd67
api/src/com/cloud/network/Networks.java f085e9f
api/src/com/cloud/network/vpc/PrivateIp.java eb68433
api/src/com/cloud/network/vpc/StaticRouteProfile.java 54aa6e4
api/src/com/cloud/network/vpc/VpcGateway.java e3530d0
api/src/com/cloud/network/vpc/VpcService.java 23e2764
api/src/org/apache/cloudstack/api/command/admin/vpc/CreatePrivateGatewayCmd.java 2055695
api/test/com/cloud/agent/api/to/NetworkTOTest.java PRE-CREATION
core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java b9bda4d
engine/schema/src/com/cloud/network/vpc/VpcGatewayVO.java e8dcb46
plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetaNetworkGuru.java 6d14e3f
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java b897df2
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 8fe8c88
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/OvsVifDriver.java 37761aa
plugins/hypervisors/ovm/src/com/cloud/ovm/hypervisor/OvmResourceBase.java a626e31
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 030eff0
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java bac361d
plugins/network-elements/cisco-vnmc/test/com/cloud/network/element/CiscoVnmcElementTest.java a16733b
plugins/network-elements/f5/src/com/cloud/network/resource/F5BigIpResource.java 1733712
plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java a0068c3
plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java 98e1461
plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java b1ecaac
server/src/com/cloud/api/ApiResponseHelper.java d7eaa26
server/src/com/cloud/configuration/ConfigurationManagerImpl.java 37ca793
server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java 4a90a77
server/src/com/cloud/network/ExternalLoadBalancerDeviceManagerImpl.java 686f5bc
server/src/com/cloud/network/ExternalLoadBalancerUsageManagerImpl.java d405382
server/src/com/cloud/network/NetworkManager.java 4af716c
server/src/com/cloud/network/NetworkManagerImpl.java a995661
server/src/com/cloud/network/NetworkServiceImpl.java 5e8be92
server/src/com/cloud/network/guru/PrivateNetworkGuru.java 2e266e7
server/src/com/cloud/network/guru/PublicNetworkGuru.java a83cdb3
server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java ebf2d42
server/src/com/cloud/network/vpc/PrivateGatewayProfile.java 20947db
server/src/com/cloud/network/vpc/PrivateIpAddress.java 2f3cf53
server/src/com/cloud/network/vpc/VpcManagerImpl.java a7f06e9
server/test/com/cloud/network/MockNetworkManagerImpl.java 2f717c8
server/test/com/cloud/vpc/MockNetworkManagerImpl.java f884ba1
server/test/com/cloud/vpc/MockVpcManagerImpl.java baccbd0
setup/db/db/schema-410to420.sql c8ac1ec
Diff: https://reviews.apache.org/r/10970/diff/
Testing
-------
Thanks,
daan Hoogland