You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/29 18:57:26 UTC

[GitHub] [arrow] pachadotdev commented on a change in pull request #10615: ARROW-12967: [R] Add bindings for pmin() and pmax() #10497 #10613

pachadotdev commented on a change in pull request #10615:
URL: https://github.com/apache/arrow/pull/10615#discussion_r660884851



##########
File path: r/src/compute.cpp
##########
@@ -180,6 +180,15 @@ std::shared_ptr<arrow::compute::FunctionOptions> make_compute_options(
     return out;
   }
 
+  if (func_name == "element_wise_min" || func_name == "element_wise_max") {
+    using Options = arrow::compute::ElementWiseAggregateOptions;
+    bool skip_nulls = false;

Review comment:
       thanks, yes i went full R to the bottom fro the smae reason




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org