[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #5273: Externalize config to enable manually setting CPU topology on KVM VM

[GitBox <gi...@apache.org>]

GabrielBrascher commented on a change in pull request #5273:
URL: https://github.com/apache/cloudstack/pull/5273#discussion_r682547838



##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -4502,6 +4506,11 @@ public boolean isSecureMode(String bootMode) {
     }
 
     private void setCpuTopology(CpuModeDef cmd, int vcpus, Map<String, String> details) {
+        if (!enableManuallySettingCpuTopologyOnKvmVm) {
+            s_logger.info(String.format("Skipping manually setting CPU topology on VM's XML due to it is disabled in agent.properties {\"property\": \"%s\", \"value\": %s}.",

Review comment:
       This is good to be logged but, in my opinion, this log would match better with the `debug` level instead of `info`.
   
   This will be logged too many times confirming the default operation to KVM nodes. By having it in debug allows operators to choose to ignore such messages.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org