You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oltu.apache.org by "Ben Noordhuis (JIRA)" <ji...@apache.org> on 2011/03/03 17:45:36 UTC
[jira] Created: (AMBER-14) [oauth2-rs-filter] comma-separated
oauth.rs.tokens isn't parsed properly
[oauth2-rs-filter] comma-separated oauth.rs.tokens isn't parsed properly
------------------------------------------------------------------------
Key: AMBER-14
URL: https://issues.apache.org/jira/browse/AMBER-14
Project: Amber
Issue Type: Bug
Components: Server
Reporter: Ben Noordhuis
Quoting the commit log:
Bug fix: don't reallocate parameterStyles from within the assignment loop.
You end up with an all-null array except for the last entry. For example,
oauth.rs.tokens="HEADER,BODY,QUERY" produces [null,null,"QUERY"].
Color diff and raw patch:
https://github.com/bnoordhuis/amber/commit/5e74032
https://github.com/bnoordhuis/amber/commit/5e74032.patch
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (AMBER-14) [oauth2-rs-filter] comma-separated
oauth.rs.tokens isn't parsed properly
Posted by "Ben Noordhuis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMBER-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002072#comment-13002072 ]
Ben Noordhuis commented on AMBER-14:
------------------------------------
That was quick. Thanks, Tommaso!
> [oauth2-rs-filter] comma-separated oauth.rs.tokens isn't parsed properly
> ------------------------------------------------------------------------
>
> Key: AMBER-14
> URL: https://issues.apache.org/jira/browse/AMBER-14
> Project: Amber
> Issue Type: Bug
> Components: Server
> Reporter: Ben Noordhuis
>
> Quoting the commit log:
> Bug fix: don't reallocate parameterStyles from within the assignment loop.
> You end up with an all-null array except for the last entry. For example,
> oauth.rs.tokens="HEADER,BODY,QUERY" produces [null,null,"QUERY"].
> Color diff and raw patch:
> https://github.com/bnoordhuis/amber/commit/5e74032
> https://github.com/bnoordhuis/amber/commit/5e74032.patch
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (AMBER-14) [oauth2-rs-filter] comma-separated
oauth.rs.tokens isn't parsed properly
Posted by "Tommaso Teofili (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMBER-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002076#comment-13002076 ]
Tommaso Teofili commented on AMBER-14:
--------------------------------------
Looking forward for more contributions from you Ben ;-)
> [oauth2-rs-filter] comma-separated oauth.rs.tokens isn't parsed properly
> ------------------------------------------------------------------------
>
> Key: AMBER-14
> URL: https://issues.apache.org/jira/browse/AMBER-14
> Project: Amber
> Issue Type: Bug
> Components: Server
> Reporter: Ben Noordhuis
>
> Quoting the commit log:
> Bug fix: don't reallocate parameterStyles from within the assignment loop.
> You end up with an all-null array except for the last entry. For example,
> oauth.rs.tokens="HEADER,BODY,QUERY" produces [null,null,"QUERY"].
> Color diff and raw patch:
> https://github.com/bnoordhuis/amber/commit/5e74032
> https://github.com/bnoordhuis/amber/commit/5e74032.patch
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMBER-14) [oauth2-rs-filter] comma-separated
oauth.rs.tokens isn't parsed properly
Posted by "Tommaso Teofili (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMBER-14?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tommaso Teofili updated AMBER-14:
---------------------------------
Fix Version/s: 0.22
> [oauth2-rs-filter] comma-separated oauth.rs.tokens isn't parsed properly
> ------------------------------------------------------------------------
>
> Key: AMBER-14
> URL: https://issues.apache.org/jira/browse/AMBER-14
> Project: Amber
> Issue Type: Bug
> Components: Server
> Reporter: Ben Noordhuis
> Fix For: 0.22
>
>
> Quoting the commit log:
> Bug fix: don't reallocate parameterStyles from within the assignment loop.
> You end up with an all-null array except for the last entry. For example,
> oauth.rs.tokens="HEADER,BODY,QUERY" produces [null,null,"QUERY"].
> Color diff and raw patch:
> https://github.com/bnoordhuis/amber/commit/5e74032
> https://github.com/bnoordhuis/amber/commit/5e74032.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (AMBER-14) [oauth2-rs-filter] comma-separated
oauth.rs.tokens isn't parsed properly
Posted by "Tommaso Teofili (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMBER-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002060#comment-13002060 ]
Tommaso Teofili commented on AMBER-14:
--------------------------------------
Good catch Ben :-)
> [oauth2-rs-filter] comma-separated oauth.rs.tokens isn't parsed properly
> ------------------------------------------------------------------------
>
> Key: AMBER-14
> URL: https://issues.apache.org/jira/browse/AMBER-14
> Project: Amber
> Issue Type: Bug
> Components: Server
> Reporter: Ben Noordhuis
>
> Quoting the commit log:
> Bug fix: don't reallocate parameterStyles from within the assignment loop.
> You end up with an all-null array except for the last entry. For example,
> oauth.rs.tokens="HEADER,BODY,QUERY" produces [null,null,"QUERY"].
> Color diff and raw patch:
> https://github.com/bnoordhuis/amber/commit/5e74032
> https://github.com/bnoordhuis/amber/commit/5e74032.patch
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (AMBER-14) [oauth2-rs-filter] comma-separated
oauth.rs.tokens isn't parsed properly
Posted by "Antonio Sanso (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMBER-14?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Sanso closed AMBER-14.
------------------------------
> [oauth2-rs-filter] comma-separated oauth.rs.tokens isn't parsed properly
> ------------------------------------------------------------------------
>
> Key: AMBER-14
> URL: https://issues.apache.org/jira/browse/AMBER-14
> Project: Amber
> Issue Type: Bug
> Components: Server
> Reporter: Ben Noordhuis
> Fix For: 0.22
>
>
> Quoting the commit log:
> Bug fix: don't reallocate parameterStyles from within the assignment loop.
> You end up with an all-null array except for the last entry. For example,
> oauth.rs.tokens="HEADER,BODY,QUERY" produces [null,null,"QUERY"].
> Color diff and raw patch:
> https://github.com/bnoordhuis/amber/commit/5e74032
> https://github.com/bnoordhuis/amber/commit/5e74032.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (AMBER-14) [oauth2-rs-filter] comma-separated
oauth.rs.tokens isn't parsed properly
Posted by "Tommaso Teofili (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMBER-14?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tommaso Teofili resolved AMBER-14.
----------------------------------
Resolution: Fixed
Thanks Ben for your patch that resolves the bug
> [oauth2-rs-filter] comma-separated oauth.rs.tokens isn't parsed properly
> ------------------------------------------------------------------------
>
> Key: AMBER-14
> URL: https://issues.apache.org/jira/browse/AMBER-14
> Project: Amber
> Issue Type: Bug
> Components: Server
> Reporter: Ben Noordhuis
>
> Quoting the commit log:
> Bug fix: don't reallocate parameterStyles from within the assignment loop.
> You end up with an all-null array except for the last entry. For example,
> oauth.rs.tokens="HEADER,BODY,QUERY" produces [null,null,"QUERY"].
> Color diff and raw patch:
> https://github.com/bnoordhuis/amber/commit/5e74032
> https://github.com/bnoordhuis/amber/commit/5e74032.patch
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira