You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/12/04 01:04:56 UTC
Review Request 40941: Added a helper for HDFS client to shell out
commands.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40941/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Vinod Kone.
Repository: mesos
Description
-------
Added a helper for HDFS client to shell out commands.
Code is copied from https://reviews.apache.org/r/40559/.
Diffs
-----
src/hdfs/hdfs.cpp c32c2ae9d2ace5deb09f56dcec2bd366c2d07f6b
Diff: https://reviews.apache.org/r/40941/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 40941: Added a helper for HDFS client to shell out
commands.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40941/
-----------------------------------------------------------
(Updated Dec. 15, 2015, 1:26 a.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Changes
-------
No need for 'Future<tuple>' in .then
Bugs: MESOS-3951
https://issues.apache.org/jira/browse/MESOS-3951
Repository: mesos
Description
-------
Added a helper for HDFS client to shell out commands.
Code is copied from https://reviews.apache.org/r/40559/.
Diffs (updated)
-----
src/hdfs/hdfs.cpp c32c2ae9d2ace5deb09f56dcec2bd366c2d07f6b
Diff: https://reviews.apache.org/r/40941/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 40941: Added a helper for HDFS client to shell out
commands.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40941/
-----------------------------------------------------------
(Updated Dec. 4, 2015, 12:45 a.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Bugs: MESOS-3951
https://issues.apache.org/jira/browse/MESOS-3951
Repository: mesos
Description
-------
Added a helper for HDFS client to shell out commands.
Code is copied from https://reviews.apache.org/r/40559/.
Diffs
-----
src/hdfs/hdfs.cpp c32c2ae9d2ace5deb09f56dcec2bd366c2d07f6b
Diff: https://reviews.apache.org/r/40941/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 40941: Added a helper for HDFS client to shell out
commands.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40941/#review108916
-----------------------------------------------------------
Ship it!
src/hdfs/hdfs.cpp (line 52)
<https://reviews.apache.org/r/40941/#comment168374>
Add a TODO to eventually move this to subprocess?
src/hdfs/hdfs.cpp (lines 55 - 56)
<https://reviews.apache.org/r/40941/#comment168373>
instead of CHECKs why not return failed futures?
- Vinod Kone
On Dec. 4, 2015, 12:04 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40941/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2015, 12:04 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a helper for HDFS client to shell out commands.
>
> Code is copied from https://reviews.apache.org/r/40559/.
>
>
> Diffs
> -----
>
> src/hdfs/hdfs.cpp c32c2ae9d2ace5deb09f56dcec2bd366c2d07f6b
>
> Diff: https://reviews.apache.org/r/40941/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>