[jira] [Commented] (PIG-259) allow store to overwrite existing directroy

["Daniel Dai (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIG-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13890029#comment-13890029 ] 

Daniel Dai commented on PIG-259:
--------------------------------

[~nezihyigitbasi], thanks for the patch. Couple of comments:
1. Formatting: please use 4 space instead of tab
2. TestPigStorage.java: PigStorage(',', '\-overwrite true') => PigStorage(',', '--overwrite true'), -long_option only works in older version of common-cli
3. InputOutputFileValidator.java: I get a org.apache.hadoop.fs.FileAlreadyExistsException instead of org.apache.hadoop.mapred.FileAlreadyExistsException in Hadoop 2
4. PigOutputFormat.java: Seems we already did the cleanup in JobControlCompiler, any reason do it again here?

> allow store to overwrite existing directroy
> -------------------------------------------
>
>                 Key: PIG-259
>                 URL: https://issues.apache.org/jira/browse/PIG-259
>             Project: Pig
>          Issue Type: Sub-task
>            Reporter: Olga Natkovich
>            Assignee: Nezih Yigitbasi
>         Attachments: PIG-259.5.patch, Pig_259.patch, Pig_259_2.patch, Pig_259_3.patch, Pig_259_4.patch
>
>
> we have users who are asking for a flag to overwrite existing directory



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)