You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/08 15:54:44 UTC
[GitHub] [pulsar] nicoloboschi opened a new pull request, #17553: [ci] Enable required checks status for pulls to the master branch
nicoloboschi opened a new pull request, #17553:
URL: https://github.com/apache/pulsar/pull/17553
### Motivation
Add back the protection to the master branch. Basically it reverts https://github.com/apache/pulsar/pull/17547 but using the new job created in https://github.com/apache/pulsar/pull/17541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on a diff in pull request #17553: [ci] Enable required checks status for pulls to the master branch
Posted by GitBox <gi...@apache.org>.
lhotari commented on code in PR #17553:
URL: https://github.com/apache/pulsar/pull/17553#discussion_r966193532
##########
.asf.yaml:
##########
@@ -42,55 +42,27 @@ github:
# disable rebase button:
rebase: false
protected_branches:
-# master:
-# required_status_checks:
+ master:
+ required_status_checks:
# strict means "Require branches to be up to date before merging".
-# strict: false
+ strict: false
# Contexts are the names of checks that must pass.
# See ./github/workflows/README.md for more documentation on this list.
-# contexts:
-# - build
-# - cpp-tests
-# - Changed files check
-# - Build and License check
-# - CI - Unit - Brokers - Broker Group 1
-# - CI - Unit - Brokers - Broker Group 2
-# - CI - Unit - Brokers - Broker Group 3
-# - CI - Unit - Brokers - Client Api
-# - CI - Unit - Brokers - Client Impl
-# - CI - Unit - Other
-# - CI - Unit - Proxy
-# - Build Pulsar java-test-image docker image
-# - CI - Integration - Backwards Compatibility
-# - CI - Integration - Cli
-# - CI - Integration - Messaging
-# - CI - Integration - Shade on Java 8
-# - CI - Integration - Shade on Java 11
-# - CI - Integration - Shade on Java 17
-# - CI - Integration - Standalone
-# - CI - Integration - Transaction
-# - Build Pulsar docker image
-# - CI - System - Function
-# - CI - System - Pulsar Connectors - Process
-# - CI - System - Pulsar Connectors - Thread
-# - CI - System - Pulsar IO
-# - CI - System - Schema
-# - CI - System - Tiered FileSystem
-# - CI - System - Tiered JCloud
-# - CI - System - Sql
+ contexts:
+ - pulsar-ci-checks-completed
Review Comment:
this might not be correct. It's better to run the workflow once and then use the API to ensure that the correct check name is used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on a diff in pull request #17553: [ci] Enable required checks status for pulls to the master branch
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on code in PR #17553:
URL: https://github.com/apache/pulsar/pull/17553#discussion_r966160635
##########
.asf.yaml:
##########
@@ -42,55 +42,27 @@ github:
# disable rebase button:
rebase: false
protected_branches:
-# master:
-# required_status_checks:
+ master:
+ required_status_checks:
# strict means "Require branches to be up to date before merging".
-# strict: false
+ strict: false
# Contexts are the names of checks that must pass.
# See ./github/workflows/README.md for more documentation on this list.
-# contexts:
-# - build
-# - cpp-tests
-# - Changed files check
-# - Build and License check
-# - CI - Unit - Brokers - Broker Group 1
-# - CI - Unit - Brokers - Broker Group 2
-# - CI - Unit - Brokers - Broker Group 3
-# - CI - Unit - Brokers - Client Api
-# - CI - Unit - Brokers - Client Impl
-# - CI - Unit - Other
-# - CI - Unit - Proxy
-# - Build Pulsar java-test-image docker image
-# - CI - Integration - Backwards Compatibility
-# - CI - Integration - Cli
-# - CI - Integration - Messaging
-# - CI - Integration - Shade on Java 8
-# - CI - Integration - Shade on Java 11
-# - CI - Integration - Shade on Java 17
-# - CI - Integration - Standalone
-# - CI - Integration - Transaction
-# - Build Pulsar docker image
-# - CI - System - Function
-# - CI - System - Pulsar Connectors - Process
-# - CI - System - Pulsar Connectors - Thread
-# - CI - System - Pulsar IO
-# - CI - System - Schema
-# - CI - System - Tiered FileSystem
-# - CI - System - Tiered JCloud
-# - CI - System - Sql
+ contexts:
+ - pulsar-ci-checks-completed
+ - cpp-tests
Review Comment:
https://github.com/apache/pulsar/blob/8c7dc4e26f9d590cd8006092c5541c8c655ed33d/.github/workflows/pulsar-ci.yaml#L838
https://github.com/apache/pulsar/blob/8c7dc4e26f9d590cd8006092c5541c8c655ed33d/.github/workflows/ci-cpp.yaml#L38
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #17553: [ci] Enable required checks status for pulls to the master branch
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17553:
URL: https://github.com/apache/pulsar/pull/17553#discussion_r966150916
##########
.asf.yaml:
##########
@@ -42,55 +42,27 @@ github:
# disable rebase button:
rebase: false
protected_branches:
-# master:
-# required_status_checks:
+ master:
+ required_status_checks:
# strict means "Require branches to be up to date before merging".
-# strict: false
+ strict: false
# Contexts are the names of checks that must pass.
# See ./github/workflows/README.md for more documentation on this list.
-# contexts:
-# - build
-# - cpp-tests
-# - Changed files check
-# - Build and License check
-# - CI - Unit - Brokers - Broker Group 1
-# - CI - Unit - Brokers - Broker Group 2
-# - CI - Unit - Brokers - Broker Group 3
-# - CI - Unit - Brokers - Client Api
-# - CI - Unit - Brokers - Client Impl
-# - CI - Unit - Other
-# - CI - Unit - Proxy
-# - Build Pulsar java-test-image docker image
-# - CI - Integration - Backwards Compatibility
-# - CI - Integration - Cli
-# - CI - Integration - Messaging
-# - CI - Integration - Shade on Java 8
-# - CI - Integration - Shade on Java 11
-# - CI - Integration - Shade on Java 17
-# - CI - Integration - Standalone
-# - CI - Integration - Transaction
-# - Build Pulsar docker image
-# - CI - System - Function
-# - CI - System - Pulsar Connectors - Process
-# - CI - System - Pulsar Connectors - Thread
-# - CI - System - Pulsar IO
-# - CI - System - Schema
-# - CI - System - Tiered FileSystem
-# - CI - System - Tiered JCloud
-# - CI - System - Sql
+ contexts:
+ - pulsar-ci-checks-completed
+ - cpp-tests
Review Comment:
I don't find the related step. How can it be the correct name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi merged pull request #17553: [ci] Enable required checks status for pulls to the master branch
Posted by GitBox <gi...@apache.org>.
nicoloboschi merged PR #17553:
URL: https://github.com/apache/pulsar/pull/17553
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on a diff in pull request #17553: [ci] Enable required checks status for pulls to the master branch
Posted by GitBox <gi...@apache.org>.
lhotari commented on code in PR #17553:
URL: https://github.com/apache/pulsar/pull/17553#discussion_r966250316
##########
.asf.yaml:
##########
@@ -42,55 +42,27 @@ github:
# disable rebase button:
rebase: false
protected_branches:
-# master:
-# required_status_checks:
+ master:
+ required_status_checks:
# strict means "Require branches to be up to date before merging".
-# strict: false
+ strict: false
# Contexts are the names of checks that must pass.
# See ./github/workflows/README.md for more documentation on this list.
-# contexts:
-# - build
-# - cpp-tests
-# - Changed files check
-# - Build and License check
-# - CI - Unit - Brokers - Broker Group 1
-# - CI - Unit - Brokers - Broker Group 2
-# - CI - Unit - Brokers - Broker Group 3
-# - CI - Unit - Brokers - Client Api
-# - CI - Unit - Brokers - Client Impl
-# - CI - Unit - Other
-# - CI - Unit - Proxy
-# - Build Pulsar java-test-image docker image
-# - CI - Integration - Backwards Compatibility
-# - CI - Integration - Cli
-# - CI - Integration - Messaging
-# - CI - Integration - Shade on Java 8
-# - CI - Integration - Shade on Java 11
-# - CI - Integration - Shade on Java 17
-# - CI - Integration - Standalone
-# - CI - Integration - Transaction
-# - Build Pulsar docker image
-# - CI - System - Function
-# - CI - System - Pulsar Connectors - Process
-# - CI - System - Pulsar Connectors - Thread
-# - CI - System - Pulsar IO
-# - CI - System - Schema
-# - CI - System - Tiered FileSystem
-# - CI - System - Tiered JCloud
-# - CI - System - Sql
+ contexts:
+ - pulsar-ci-checks-completed
Review Comment:
```suggestion
- Pulsar CI checks completed
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org