[jira] Commented: (TUSCANY-2320) The contextPath init parameter for TuscanyServletFilter.

["Ilya Kanonirov (JIRA)" <tu...@ws.apache.org>]

    [ https://issues.apache.org/jira/browse/TUSCANY-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597134#action_12597134 ] 

Ilya Kanonirov commented on TUSCANY-2320:
-----------------------------------------

Thanks for quick reply. That patch works.

Also I found one more class where ServletContext is, as I assume, wrongly used to retrieve initial parameters:

modules/implementation-node-runtime/src/main/java/org/apache/tuscany/sca/implementation/node/webapp/NodeWebAppServletHost.java

Shell I open another issue?

> The contextPath init parameter for TuscanyServletFilter.
> --------------------------------------------------------
>
>                 Key: TUSCANY-2320
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-2320
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SCA Web App Integration
>    Affects Versions: Java-SCA-1.2
>            Reporter: Ilya Kanonirov
>            Assignee: ant elder
>         Attachments: tuscany-host-webapp-1.2-TUSCANY-2320.jar
>
>
> Current version of the component requires the contextPath initialization parameter to be specified in the Servlet Context, i.e. we need the following context-param in web.xml:
> <web-app
> ...
>     <context-param>
>         <param-name>contextPath</param-name>
>         <param-value>/ctx</param-value>
>     </context-param>
> ...
> </webapp>
> while the previous Java SCA 1.1 required that parameter at the filter description level:
> <web-app
> ...
>   <filter>
>     <filter-name>tuscany</filter-name>
>     <filter-class>org.apache.tuscany.sca.host.webapp.TuscanyServletFilter</filter-class>
>     <init-param>
>       <param-name>contextPath</param-name>
>       <param-value>/ctx</param-value>
>     </init-param>
>   </filter>
> ...
> </webapp>
> Is that parameter supposed to be there, defined at the Servlet Context level?
> If yes, I would suggest renaming the parameter to avoid confusing. For example, adding a package prefix might be enough.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.