You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Michael Osipov (Created) (JIRA)" <ji...@apache.org> on 2011/10/21 12:44:32 UTC
[jira] [Created] (DAEMON-220) Clean up configure/configure.in
scripts
Clean up configure/configure.in scripts
---------------------------------------
Key: DAEMON-220
URL: https://issues.apache.org/jira/browse/DAEMON-220
Project: Commons Daemon
Issue Type: Improvement
Components: Jsvc
Affects Versions: 1.0.7
Reporter: Michael Osipov
The current configure script has several deficiencies at the moment.No CPPFLAGS support, no detection of Java OS. Most can be taken from libtcnative.
Issue has been raised on the mailing list: http://www.mail-archive.com/user@commons.apache.org/msg07101.html
It needs a complete overhaul.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (DAEMON-220) Clean up
configure/configure.in scripts
Posted by "Michael Osipov (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DAEMON-220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141561#comment-13141561 ]
Michael Osipov edited comment on DAEMON-220 at 11/1/11 8:42 PM:
----------------------------------------------------------------
I was not refering to a JRE. I know that a JDK is necessary. That was my point: FIND_JAVA => FIND_JDK.
There is no need to drop it at all. Right now with the patch it does a good job and should cover 80 % of all cases. So we are good. Those who still need to customize can do anyway. Reasonable defaults are always a good starting point.
java in the path does not mean you will find the JDK. In my case your check failed and led to false results (FreeBSD 8.2).
was (Author: michael-o):
I was not refering to a JRE. I know that a JDK is necessary. That was my point: FIND_JAVA => FIND_JDK.
There is no need to drop it at all. Right now with the patch it does a good job and should cover 80 % of all cases. So we are good. Those who still need to customize can do anyway. Reasonable defaults are always a good starting point.
java in the path does not mean you will find the JDK. In my case your check failed and led to false results.
> Clean up configure/configure.in scripts
> ---------------------------------------
>
> Key: DAEMON-220
> URL: https://issues.apache.org/jira/browse/DAEMON-220
> Project: Commons Daemon
> Issue Type: Improvement
> Components: Jsvc
> Affects Versions: 1.0.7
> Reporter: Michael Osipov
> Assignee: Mladen Turk
> Attachments: DAEMON-220.patch
>
>
> The current configure script has several deficiencies at the moment.No CPPFLAGS support, no detection of Java OS. Most can be taken from libtcnative.
> Issue has been raised on the mailing list: http://www.mail-archive.com/user@commons.apache.org/msg07101.html
> It needs a complete overhaul.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (DAEMON-220) Clean up configure/configure.in
scripts
Posted by "Mladen Turk (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DAEMON-220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mladen Turk resolved DAEMON-220.
--------------------------------
Resolution: Fixed
It might cover 80% now, but next year this won't be the case any more.
What's worse the JDK it finds might not be the one that you wish to build upon.
To simplify the things I dropped the entire guessing mechanism.
JAVA_HOME or --with-java is more then enough.
INSTALL.txt already has that explained and I'll update it to contain the new --with-os-type directive
> Clean up configure/configure.in scripts
> ---------------------------------------
>
> Key: DAEMON-220
> URL: https://issues.apache.org/jira/browse/DAEMON-220
> Project: Commons Daemon
> Issue Type: Improvement
> Components: Jsvc
> Affects Versions: 1.0.7
> Reporter: Michael Osipov
> Assignee: Mladen Turk
> Attachments: DAEMON-220.patch
>
>
> The current configure script has several deficiencies at the moment.No CPPFLAGS support, no detection of Java OS. Most can be taken from libtcnative.
> Issue has been raised on the mailing list: http://www.mail-archive.com/user@commons.apache.org/msg07101.html
> It needs a complete overhaul.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DAEMON-220) Clean up configure/configure.in
scripts
Posted by "Michael Osipov (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DAEMON-220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141561#comment-13141561 ]
Michael Osipov commented on DAEMON-220:
---------------------------------------
I was not refering to a JRE. I know that a JDK is necessary. That was my point: FIND_JAVA => FIND_JDK.
There is no need to drop it at all. Right now with the patch it does a good job and should cover 80 % of all cases. So we are good. Those who still need to customize can do anyway. Reasonable defaults are always a good starting point.
java in the path does not mean you will find the JDK. In my case your check failed and led to false results.
> Clean up configure/configure.in scripts
> ---------------------------------------
>
> Key: DAEMON-220
> URL: https://issues.apache.org/jira/browse/DAEMON-220
> Project: Commons Daemon
> Issue Type: Improvement
> Components: Jsvc
> Affects Versions: 1.0.7
> Reporter: Michael Osipov
> Assignee: Mladen Turk
> Attachments: DAEMON-220.patch
>
>
> The current configure script has several deficiencies at the moment.No CPPFLAGS support, no detection of Java OS. Most can be taken from libtcnative.
> Issue has been raised on the mailing list: http://www.mail-archive.com/user@commons.apache.org/msg07101.html
> It needs a complete overhaul.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DAEMON-220) Clean up configure/configure.in
scripts
Posted by "Michael Osipov (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DAEMON-220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Osipov updated DAEMON-220:
----------------------------------
Attachment: DAEMON-220.patch
> Clean up configure/configure.in scripts
> ---------------------------------------
>
> Key: DAEMON-220
> URL: https://issues.apache.org/jira/browse/DAEMON-220
> Project: Commons Daemon
> Issue Type: Improvement
> Components: Jsvc
> Affects Versions: 1.0.7
> Reporter: Michael Osipov
> Assignee: Mladen Turk
> Attachments: DAEMON-220.patch
>
>
> The current configure script has several deficiencies at the moment.No CPPFLAGS support, no detection of Java OS. Most can be taken from libtcnative.
> Issue has been raised on the mailing list: http://www.mail-archive.com/user@commons.apache.org/msg07101.html
> It needs a complete overhaul.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DAEMON-220) Clean up configure/configure.in
scripts
Posted by "Michael Osipov (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DAEMON-220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141229#comment-13141229 ]
Michael Osipov commented on DAEMON-220:
---------------------------------------
Mladen,
AP_FIND_JAVA is still broken. It assumes with "which java" that the top dir is the JDK. Which might not be the case.
I have adapted the function from libtcnative just like you did with the include dir.
> Clean up configure/configure.in scripts
> ---------------------------------------
>
> Key: DAEMON-220
> URL: https://issues.apache.org/jira/browse/DAEMON-220
> Project: Commons Daemon
> Issue Type: Improvement
> Components: Jsvc
> Affects Versions: 1.0.7
> Reporter: Michael Osipov
> Assignee: Mladen Turk
> Attachments: DAEMON-220.patch
>
>
> The current configure script has several deficiencies at the moment.No CPPFLAGS support, no detection of Java OS. Most can be taken from libtcnative.
> Issue has been raised on the mailing list: http://www.mail-archive.com/user@commons.apache.org/msg07101.html
> It needs a complete overhaul.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DAEMON-220) Clean up configure/configure.in
scripts
Posted by "Michael Osipov (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DAEMON-220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141605#comment-13141605 ]
Michael Osipov commented on DAEMON-220:
---------------------------------------
Well, I don't think that this is necessary but this is your decision. I'd leave it. Although you simplified it, it still contains a bug in line 42 to 52. That's why I have provided a patch.
"which java"... does not yield a positive result. It is unreliable too.
which java on FreeBSD gives your /usr/local/bin/java. You traverse up and assume that /usr/local is the JDK home. This is incorrect. The following iterations at least did it.
> Clean up configure/configure.in scripts
> ---------------------------------------
>
> Key: DAEMON-220
> URL: https://issues.apache.org/jira/browse/DAEMON-220
> Project: Commons Daemon
> Issue Type: Improvement
> Components: Jsvc
> Affects Versions: 1.0.7
> Reporter: Michael Osipov
> Assignee: Mladen Turk
> Attachments: DAEMON-220.patch
>
>
> The current configure script has several deficiencies at the moment.No CPPFLAGS support, no detection of Java OS. Most can be taken from libtcnative.
> Issue has been raised on the mailing list: http://www.mail-archive.com/user@commons.apache.org/msg07101.html
> It needs a complete overhaul.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DAEMON-220) Clean up configure/configure.in
scripts
Posted by "Michael Osipov (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DAEMON-220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Osipov updated DAEMON-220:
----------------------------------
Comment: was deleted
(was: AP_FIND_JAVA is still incomplete)
> Clean up configure/configure.in scripts
> ---------------------------------------
>
> Key: DAEMON-220
> URL: https://issues.apache.org/jira/browse/DAEMON-220
> Project: Commons Daemon
> Issue Type: Improvement
> Components: Jsvc
> Affects Versions: 1.0.7
> Reporter: Michael Osipov
> Assignee: Mladen Turk
> Attachments: DAEMON-220.patch
>
>
> The current configure script has several deficiencies at the moment.No CPPFLAGS support, no detection of Java OS. Most can be taken from libtcnative.
> Issue has been raised on the mailing list: http://www.mail-archive.com/user@commons.apache.org/msg07101.html
> It needs a complete overhaul.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (DAEMON-220) Clean up configure/configure.in
scripts
Posted by "Mladen Turk (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DAEMON-220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mladen Turk resolved DAEMON-220.
--------------------------------
Resolution: Fixed
Backported JDK include directory detection form TC native
Removed archaic JVM's
> Clean up configure/configure.in scripts
> ---------------------------------------
>
> Key: DAEMON-220
> URL: https://issues.apache.org/jira/browse/DAEMON-220
> Project: Commons Daemon
> Issue Type: Improvement
> Components: Jsvc
> Affects Versions: 1.0.7
> Reporter: Michael Osipov
> Assignee: Mladen Turk
>
> The current configure script has several deficiencies at the moment.No CPPFLAGS support, no detection of Java OS. Most can be taken from libtcnative.
> Issue has been raised on the mailing list: http://www.mail-archive.com/user@commons.apache.org/msg07101.html
> It needs a complete overhaul.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (DAEMON-220) Clean up
configure/configure.in scripts
Posted by "Michael Osipov (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DAEMON-220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141229#comment-13141229 ]
Michael Osipov edited comment on DAEMON-220 at 11/1/11 8:14 PM:
----------------------------------------------------------------
Mladen,
AP_FIND_JAVA is still broken. It assumes with "which java" that the top dir is the JDK. Which might not be the case.
I have adapted the function from libtcnative just like you did with the include dir.
I'd rather call it AP_FIND_JDK because you are looking for a JDK and its include dirs rather than just some Java package (JRE or JDK).
was (Author: michael-o):
Mladen,
AP_FIND_JAVA is still broken. It assumes with "which java" that the top dir is the JDK. Which might not be the case.
I have adapted the function from libtcnative just like you did with the include dir.
> Clean up configure/configure.in scripts
> ---------------------------------------
>
> Key: DAEMON-220
> URL: https://issues.apache.org/jira/browse/DAEMON-220
> Project: Commons Daemon
> Issue Type: Improvement
> Components: Jsvc
> Affects Versions: 1.0.7
> Reporter: Michael Osipov
> Assignee: Mladen Turk
> Attachments: DAEMON-220.patch
>
>
> The current configure script has several deficiencies at the moment.No CPPFLAGS support, no detection of Java OS. Most can be taken from libtcnative.
> Issue has been raised on the mailing list: http://www.mail-archive.com/user@commons.apache.org/msg07101.html
> It needs a complete overhaul.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DAEMON-220) Clean up configure/configure.in
scripts
Posted by "Mladen Turk (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DAEMON-220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141539#comment-13141539 ]
Mladen Turk commented on DAEMON-220:
------------------------------------
Well first of all it has to be JDK. JRE doesn't have include files, so you cannot build daemon without JDK installed.
Think I'll drop FIND_JDK completely. It's simply useless and its never gonna be complete.
There will always be a distribution that will have its own directory layout and trying to catch and guess all
just makes no sense.
If there is no JAVA_HOME set, and java in the PATH doesn't point to the JDK, then the user will
have to use --with-java and --with-os-type.
> Clean up configure/configure.in scripts
> ---------------------------------------
>
> Key: DAEMON-220
> URL: https://issues.apache.org/jira/browse/DAEMON-220
> Project: Commons Daemon
> Issue Type: Improvement
> Components: Jsvc
> Affects Versions: 1.0.7
> Reporter: Michael Osipov
> Assignee: Mladen Turk
> Attachments: DAEMON-220.patch
>
>
> The current configure script has several deficiencies at the moment.No CPPFLAGS support, no detection of Java OS. Most can be taken from libtcnative.
> Issue has been raised on the mailing list: http://www.mail-archive.com/user@commons.apache.org/msg07101.html
> It needs a complete overhaul.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (DAEMON-220) Clean up configure/configure.in
scripts
Posted by "Michael Osipov (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DAEMON-220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Osipov reopened DAEMON-220:
-----------------------------------
AP_FIND_JAVA is still incomplete
> Clean up configure/configure.in scripts
> ---------------------------------------
>
> Key: DAEMON-220
> URL: https://issues.apache.org/jira/browse/DAEMON-220
> Project: Commons Daemon
> Issue Type: Improvement
> Components: Jsvc
> Affects Versions: 1.0.7
> Reporter: Michael Osipov
> Assignee: Mladen Turk
> Attachments: DAEMON-220.patch
>
>
> The current configure script has several deficiencies at the moment.No CPPFLAGS support, no detection of Java OS. Most can be taken from libtcnative.
> Issue has been raised on the mailing list: http://www.mail-archive.com/user@commons.apache.org/msg07101.html
> It needs a complete overhaul.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DAEMON-220) Clean up configure/configure.in
scripts
Posted by "Sebb (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DAEMON-220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb updated DAEMON-220:
------------------------
Fix Version/s: 1.0.8
> Clean up configure/configure.in scripts
> ---------------------------------------
>
> Key: DAEMON-220
> URL: https://issues.apache.org/jira/browse/DAEMON-220
> Project: Commons Daemon
> Issue Type: Improvement
> Components: Jsvc
> Affects Versions: 1.0.7
> Reporter: Michael Osipov
> Assignee: Mladen Turk
> Fix For: 1.0.8
>
> Attachments: DAEMON-220.patch
>
>
> The current configure script has several deficiencies at the moment.No CPPFLAGS support, no detection of Java OS. Most can be taken from libtcnative.
> Issue has been raised on the mailing list: http://www.mail-archive.com/user@commons.apache.org/msg07101.html
> It needs a complete overhaul.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira