You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Ashutosh Chauhan <ha...@apache.org> on 2014/02/20 20:21:02 UTC
Review Request 18318: HIVE-6474 : Only db owner can create table in db
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18318/
-----------------------------------------------------------
Review request for hive.
Bugs: HIVE-6474
https://issues.apache.org/jira/browse/HIVE-6474
Repository: hive-git
Description
-------
Only db owner is allowed to create table in db.
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/Operation2Privilege.java 7dfd574
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLAuthorizationUtils.java c59b403
ql/src/test/queries/clientnegative/authorize_create_tbl.q PRE-CREATION
ql/src/test/results/clientnegative/authorize_create_tbl.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/18318/diff/
Testing
-------
Added new test case.
Thanks,
Ashutosh Chauhan
Re: Review Request 18318: HIVE-6474 : Only db owner can create table in db
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18318/#review35122
-----------------------------------------------------------
Ship it!
Ship It!
- Thejas Nair
On Feb. 21, 2014, 12:56 a.m., Ashutosh Chauhan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18318/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2014, 12:56 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-6474
> https://issues.apache.org/jira/browse/HIVE-6474
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Only db owner is allowed to create table in db.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/Operation2Privilege.java 7dfd574
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLAuthorizationUtils.java c59b403
> ql/src/test/queries/clientnegative/authorize_create_tbl.q PRE-CREATION
> ql/src/test/results/clientnegative/authorize_create_tbl.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18318/diff/
>
>
> Testing
> -------
>
> Added new test case.
>
>
> Thanks,
>
> Ashutosh Chauhan
>
>
Re: Review Request 18318: HIVE-6474 : Only db owner can create table in db
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18318/
-----------------------------------------------------------
(Updated Feb. 21, 2014, 12:56 a.m.)
Review request for hive.
Changes
-------
Incorporated Thejas f/b.
Bugs: HIVE-6474
https://issues.apache.org/jira/browse/HIVE-6474
Repository: hive-git
Description
-------
Only db owner is allowed to create table in db.
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/Operation2Privilege.java 7dfd574
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLAuthorizationUtils.java c59b403
ql/src/test/queries/clientnegative/authorize_create_tbl.q PRE-CREATION
ql/src/test/results/clientnegative/authorize_create_tbl.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/18318/diff/
Testing
-------
Added new test case.
Thanks,
Ashutosh Chauhan
Re: Review Request 18318: HIVE-6474 : Only db owner can create table in db
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18318/#review35099
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLAuthorizationUtils.java
<https://reviews.apache.org/r/18318/#comment65504>
I think it is safer to do a case sensitive comparison, as hadoop usual configurations have case sensitive usernames.
Even if username is case insensitive we can expect the case usage to be consistent.
- Thejas Nair
On Feb. 20, 2014, 7:21 p.m., Ashutosh Chauhan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18318/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2014, 7:21 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-6474
> https://issues.apache.org/jira/browse/HIVE-6474
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Only db owner is allowed to create table in db.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/Operation2Privilege.java 7dfd574
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLAuthorizationUtils.java c59b403
> ql/src/test/queries/clientnegative/authorize_create_tbl.q PRE-CREATION
> ql/src/test/results/clientnegative/authorize_create_tbl.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18318/diff/
>
>
> Testing
> -------
>
> Added new test case.
>
>
> Thanks,
>
> Ashutosh Chauhan
>
>