You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/23 13:13:33 UTC
[GitHub] [flink] SteNicholas opened a new pull request #13775: [FLINK-19479][DataStream] Allow explicitly configuring time behaviour on KeyedStream.intervalJoin()
SteNicholas opened a new pull request #13775:
URL: https://github.com/apache/flink/pull/13775
## What is the purpose of the change
*With the deprecation of `StreamExecutionEnvironment.setStreamTimeCharacteristic()`, we need a way of explicitly configuring the time behaviour of these join operations. Currently, all join operations use the characteristic to configure themselves. `IntervalJoin` in `KeyedStream` could add `inProcessingTIme` and `inEventTime` that specify time behaviour to processing time or event time.*
## Brief change log
- *`IntervalJoin` adds `inProcessingTIme` and `inEventTime` method that specify time behaviour of join operations to processing time or event time.*
## Verifying this change
- *Modify `testExecutionFailsInProcessingTime` of `IntervalJoinITCase` test case to verify the `inProcessingTIme` of `IntervalJoin` whether could configure the time behaviour of join operations to processing time.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on a change in pull request #13775: [FLINK-19479][DataStream] Allow explicitly configuring time behaviour on KeyedStream.intervalJoin()
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #13775:
URL: https://github.com/apache/flink/pull/13775#discussion_r511985631
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java
##########
@@ -454,11 +479,7 @@ private static boolean isEnumType(TypeInformation<?> type) {
*/
@PublicEvolving
public IntervalJoined<T1, T2, KEY> between(Time lowerBound, Time upperBound) {
-
- TimeCharacteristic timeCharacteristic =
- streamOne.getExecutionEnvironment().getStreamTimeCharacteristic();
-
- if (timeCharacteristic != TimeCharacteristic.EventTime) {
+ if (timeBehaviour != TimeBehaviour.EventTime) {
Review comment:
It's interesting, we allow users to call `inProcessingTime()` but it will not work because of this. 😅 Maybe we should just document that an interval join is always in event time and don't allow configuring it for now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13775: [FLINK-19479][DataStream] Allow explicitly configuring time behaviour on KeyedStream.intervalJoin()
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13775:
URL: https://github.com/apache/flink/pull/13775#issuecomment-715405075
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "85cf8ada38ff8b98898ff1deb7e501a2d14bbd98",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8203",
"triggerID" : "85cf8ada38ff8b98898ff1deb7e501a2d14bbd98",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 85cf8ada38ff8b98898ff1deb7e501a2d14bbd98 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8203)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha closed pull request #13775: [FLINK-19479][DataStream] Allow explicitly configuring time behaviour on KeyedStream.intervalJoin()
Posted by GitBox <gi...@apache.org>.
aljoscha closed pull request #13775:
URL: https://github.com/apache/flink/pull/13775
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #13775: [FLINK-19479][DataStream] Allow explicitly configuring time behaviour on KeyedStream.intervalJoin()
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #13775:
URL: https://github.com/apache/flink/pull/13775#issuecomment-716513315
@aljoscha , please help to review this similar pull request if you are available.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on a change in pull request #13775: [FLINK-19479][DataStream] Allow explicitly configuring time behaviour on KeyedStream.intervalJoin()
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on a change in pull request #13775:
URL: https://github.com/apache/flink/pull/13775#discussion_r512446648
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java
##########
@@ -454,11 +479,7 @@ private static boolean isEnumType(TypeInformation<?> type) {
*/
@PublicEvolving
public IntervalJoined<T1, T2, KEY> between(Time lowerBound, Time upperBound) {
-
- TimeCharacteristic timeCharacteristic =
- streamOne.getExecutionEnvironment().getStreamTimeCharacteristic();
-
- if (timeCharacteristic != TimeCharacteristic.EventTime) {
+ if (timeBehaviour != TimeBehaviour.EventTime) {
Review comment:
@aljoscha I was worried about the other places make data stream with processing time configuration but this handle all interval join operations of data stream with event time at default. It's unreasonable that all join operations are defaultly configured with event time and no validation about this. What do you concern about that this don't allow configuring it for now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13775: [FLINK-19479][DataStream] Allow explicitly configuring time behaviour on KeyedStream.intervalJoin()
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13775:
URL: https://github.com/apache/flink/pull/13775#issuecomment-715405075
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "85cf8ada38ff8b98898ff1deb7e501a2d14bbd98",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "85cf8ada38ff8b98898ff1deb7e501a2d14bbd98",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 85cf8ada38ff8b98898ff1deb7e501a2d14bbd98 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #13775: [FLINK-19479][DataStream] Allow explicitly configuring time behaviour on KeyedStream.intervalJoin()
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #13775:
URL: https://github.com/apache/flink/pull/13775#issuecomment-717123629
Merging this... Good work! 🍵
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13775: [FLINK-19479][DataStream] Allow explicitly configuring time behaviour on KeyedStream.intervalJoin()
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13775:
URL: https://github.com/apache/flink/pull/13775#issuecomment-715334589
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 85cf8ada38ff8b98898ff1deb7e501a2d14bbd98 (Fri Oct 23 13:17:08 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13775: [FLINK-19479][DataStream] Allow explicitly configuring time behaviour on KeyedStream.intervalJoin()
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13775:
URL: https://github.com/apache/flink/pull/13775#issuecomment-715405075
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "85cf8ada38ff8b98898ff1deb7e501a2d14bbd98",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8203",
"triggerID" : "85cf8ada38ff8b98898ff1deb7e501a2d14bbd98",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 85cf8ada38ff8b98898ff1deb7e501a2d14bbd98 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8203)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on a change in pull request #13775: [FLINK-19479][DataStream] Allow explicitly configuring time behaviour on KeyedStream.intervalJoin()
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #13775:
URL: https://github.com/apache/flink/pull/13775#discussion_r512551970
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java
##########
@@ -454,11 +479,7 @@ private static boolean isEnumType(TypeInformation<?> type) {
*/
@PublicEvolving
public IntervalJoined<T1, T2, KEY> between(Time lowerBound, Time upperBound) {
-
- TimeCharacteristic timeCharacteristic =
- streamOne.getExecutionEnvironment().getStreamTimeCharacteristic();
-
- if (timeCharacteristic != TimeCharacteristic.EventTime) {
+ if (timeBehaviour != TimeBehaviour.EventTime) {
Review comment:
No, I'll merge this now. Good work!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on a change in pull request #13775: [FLINK-19479][DataStream] Allow explicitly configuring time behaviour on KeyedStream.intervalJoin()
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on a change in pull request #13775:
URL: https://github.com/apache/flink/pull/13775#discussion_r512531874
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java
##########
@@ -454,11 +479,7 @@ private static boolean isEnumType(TypeInformation<?> type) {
*/
@PublicEvolving
public IntervalJoined<T1, T2, KEY> between(Time lowerBound, Time upperBound) {
-
- TimeCharacteristic timeCharacteristic =
- streamOne.getExecutionEnvironment().getStreamTimeCharacteristic();
-
- if (timeCharacteristic != TimeCharacteristic.EventTime) {
+ if (timeBehaviour != TimeBehaviour.EventTime) {
Review comment:
@aljoscha , therefore any comments on other changes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on a change in pull request #13775: [FLINK-19479][DataStream] Allow explicitly configuring time behaviour on KeyedStream.intervalJoin()
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #13775:
URL: https://github.com/apache/flink/pull/13775#discussion_r512526777
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java
##########
@@ -454,11 +479,7 @@ private static boolean isEnumType(TypeInformation<?> type) {
*/
@PublicEvolving
public IntervalJoined<T1, T2, KEY> between(Time lowerBound, Time upperBound) {
-
- TimeCharacteristic timeCharacteristic =
- streamOne.getExecutionEnvironment().getStreamTimeCharacteristic();
-
- if (timeCharacteristic != TimeCharacteristic.EventTime) {
+ if (timeBehaviour != TimeBehaviour.EventTime) {
Review comment:
No concerns. I just found it funny. Let's leave it like this 👌
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on a change in pull request #13775: [FLINK-19479][DataStream] Allow explicitly configuring time behaviour on KeyedStream.intervalJoin()
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on a change in pull request #13775:
URL: https://github.com/apache/flink/pull/13775#discussion_r512531874
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java
##########
@@ -454,11 +479,7 @@ private static boolean isEnumType(TypeInformation<?> type) {
*/
@PublicEvolving
public IntervalJoined<T1, T2, KEY> between(Time lowerBound, Time upperBound) {
-
- TimeCharacteristic timeCharacteristic =
- streamOne.getExecutionEnvironment().getStreamTimeCharacteristic();
-
- if (timeCharacteristic != TimeCharacteristic.EventTime) {
+ if (timeBehaviour != TimeBehaviour.EventTime) {
Review comment:
@aljoscha , therefore any other comments on other changes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org