You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by Daan Hoogland <da...@gmail.com> on 2015/12/18 11:22:52 UTC

4.7.0 vote passed -> freeze is over

Committers, please keep in mind our quality standards when executing your
liberty to merge.

-- 
Daan

Re: 4.7.0 vote passed -> freeze is over

Posted by Remi Bergsma <RB...@schubergphilis.com>.

There’s an important difference between “The RM merges to release branches” and “The RM should test everything on its own and then merge”. It’s more like the latter currently.

Unfortunately not many people review and test so this is not scalable. I will be offline next week only, so we should be OK. Currently I see no PRs that are ready for merge and contain new features. Worst case PRs have to wait ~10 days before they get merged. There will be no release anyway, so I don’t see the problem. If people do see a problem, then indeed it’d be nice to have multiple RMs.

About the number of open PRs: we should close old/inactive ones. I’d estimate that at least half of them can be closed, probably more. That’s also why the number grows: a certain % will never be merged because they are not ready and now stay open.

Still hoping we get proper Github access for Christmas :-) Then I can close them, alter titles, label them etc.

Regards,
Remi

On 18/12/15 12:53, "Daan Hoogland" <da...@gmail.com> wrote:

>I had to let this sink in, Sebastien. I'm not at my 'I can' endurance
>condition at the moment, sorry.
>
>There is a consequence; Remi, our only RM has small kids and is on holidays
>during the holidays, I understand. For all intended purposes we have a
>freeze until January ;)
>
>
>On Fri, Dec 18, 2015 at 12:21 PM, sebgoa <ru...@gmail.com> wrote:
>
>>
>> On Dec 18, 2015, at 11:44 AM, Daan Hoogland <da...@gmail.com>
>> wrote:
>>
>> > Sebastien,
>> >
>> > On Fri, Dec 18, 2015 at 11:36 AM, sebgoa <ru...@gmail.com> wrote:
>> >
>> >> Releases branches should only be written to by RMs.
>> >>
>> > Knowing how you feel about the process you mean 'master' as much as
>> older
>> > branches, right?
>> >
>> > I would not want to be responsible for the growing number of PRs as RM.
>> > (the main reason I will quit this job). At the release of 4.7 the number
>> of
>> > open PRs grew instead of shrunk. That could be a good sign if it
>> coincided
>> > with the growth of our development community but it doesn't.
>> >  
>> > Our present way of working can not be maintained without people
>> > volunteering 1 fte.
>> >
>>
>> Mostly agree.
>>
>> Just wish we could let Christmas pass by without breaking all the good
>> work you guys did.
>> Then "sit down" and work on our next steps:
>>
>> - automated CI
>> - use of github
>>
>>
>> >
>> > On Dec 18, 2015, at 11:22 AM, Daan Hoogland <da...@gmail.com>
>> wrote:
>> >>
>> >>> Committers, please keep in mind our quality standards when executing
>> your
>> >>> liberty to merge.
>> >>>
>> >>> --
>> >>> Daan
>> >>
>> >>
>> >
>> >
>> > --
>> > Daan
>>
>>
>
>
>-- 
>Daan

Re: 4.7.0 vote passed -> freeze is over

Posted by Daan Hoogland <da...@gmail.com>.

I had to let this sink in, Sebastien. I'm not at my 'I can' endurance
condition at the moment, sorry.

There is a consequence; Remi, our only RM has small kids and is on holidays
during the holidays, I understand. For all intended purposes we have a
freeze until January ;)


On Fri, Dec 18, 2015 at 12:21 PM, sebgoa <ru...@gmail.com> wrote:

>
> On Dec 18, 2015, at 11:44 AM, Daan Hoogland <da...@gmail.com>
> wrote:
>
> > Sebastien,
> >
> > On Fri, Dec 18, 2015 at 11:36 AM, sebgoa <ru...@gmail.com> wrote:
> >
> >> Releases branches should only be written to by RMs.
> >>
> > Knowing how you feel about the process you mean 'master' as much as
> older
> > branches, right?
> >
> > I would not want to be responsible for the growing number of PRs as RM.
> > (the main reason I will quit this job). At the release of 4.7 the number
> of
> > open PRs grew instead of shrunk. That could be a good sign if it
> coincided
> > with the growth of our development community but it doesn't.
> >  
> > Our present way of working can not be maintained without people
> > volunteering 1 fte.
> >
>
> Mostly agree.
>
> Just wish we could let Christmas pass by without breaking all the good
> work you guys did.
> Then "sit down" and work on our next steps:
>
> - automated CI
> - use of github
>
>
> >
> > On Dec 18, 2015, at 11:22 AM, Daan Hoogland <da...@gmail.com>
> wrote:
> >>
> >>> Committers, please keep in mind our quality standards when executing
> your
> >>> liberty to merge.
> >>>
> >>> --
> >>> Daan
> >>
> >>
> >
> >
> > --
> > Daan
>
>


-- 
Daan

Re: 4.7.0 vote passed -> freeze is over

Posted by sebgoa <ru...@gmail.com>.

On Dec 18, 2015, at 11:44 AM, Daan Hoogland <da...@gmail.com> wrote:

> Sebastien,
> 
> On Fri, Dec 18, 2015 at 11:36 AM, sebgoa <ru...@gmail.com> wrote:
> 
>> Releases branches should only be written to by RMs.
>> 
> Knowing how you feel about the process you mean 'master' as much as older
> branches, right?
> 
> I would not want to be responsible for the growing number of PRs as RM.
> (the main reason I will quit this job). At the release of 4.7 the number of
> open PRs grew instead of shrunk. That could be a good sign if it coincided
> with the growth of our development community but it doesn't.
>  
> Our present way of working can not be maintained without people
> volunteering 1 fte.
> 

Mostly agree.

Just wish we could let Christmas pass by without breaking all the good work you guys did.
Then "sit down" and work on our next steps:

- automated CI
- use of github


> 
> On Dec 18, 2015, at 11:22 AM, Daan Hoogland <da...@gmail.com> wrote:
>> 
>>> Committers, please keep in mind our quality standards when executing your
>>> liberty to merge.
>>> 
>>> --
>>> Daan
>> 
>> 
> 
> 
> -- 
> Daan

Re: 4.7.0 vote passed -> freeze is over

Posted by Daan Hoogland <da...@gmail.com>.

Sebastien,

On Fri, Dec 18, 2015 at 11:36 AM, sebgoa <ru...@gmail.com> wrote:

> Releases branches should only be written to by RMs.
>
Knowing how you feel about the process you mean 'master' as much as older
branches, right?

I would not want to be responsible for the growing number of PRs as RM.
(the main reason I will quit this job). At the release of 4.7 the number of
open PRs grew instead of shrunk. That could be a good sign if it coincided
with the growth of our development community but it doesn't.

Our present way of working can not be maintained without people
volunteering 1 fte.

On Dec 18, 2015, at 11:22 AM, Daan Hoogland <da...@gmail.com> wrote:
>
> > Committers, please keep in mind our quality standards when executing your
> > liberty to merge.
> >
> > --
> > Daan
>
>

-- 
Daan

Re: 4.7.0 vote passed -> freeze is over

Posted by sebgoa <ru...@gmail.com>.

Releases branches should only be written to by RMs.



On Dec 18, 2015, at 11:22 AM, Daan Hoogland <da...@gmail.com> wrote:

> Committers, please keep in mind our quality standards when executing your
> liberty to merge.
> 
> -- 
> Daan