You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by SeanTAllen <gi...@git.apache.org> on 2014/08/16 16:46:02 UTC
[GitHub] incubator-storm pull request: Remove out of date comment
GitHub user SeanTAllen opened a pull request:
https://github.com/apache/incubator-storm/pull/229
Remove out of date comment
per worker heartbeating was introduced in Storm 0.8.0
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SeanTAllen/incubator-storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-storm/pull/229.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #229
----
commit a1cf23d81eded0da5183c61912908761226732c9
Author: Sean T Allen <se...@monkeysnatchbanana.com>
Date: 2014-08-16T14:45:31Z
Remove out of date comment
per worker heartbeating was introduced in Storm 0.8.0
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: Remove out of date comment
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/229#issuecomment-52550193
@SeanTAllen
Looks good to me +1. I am happy to merge this in as is, but a lot of our tracking of changes goes through JIRA so if you want fully credit with your name in bright lights for your contribution please file a JIRA for this change and add the JIRA number to the title of this pull request. If you don't care that is fine too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: Remove out of date comment
Posted by SeanTAllen <gi...@git.apache.org>.
Github user SeanTAllen commented on the pull request:
https://github.com/apache/incubator-storm/pull/229#issuecomment-52550895
don't care anywhere near enough to open a jira.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: Remove out of date comment
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-storm/pull/229
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: Remove out of date comment
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/229#issuecomment-52551471
+1 I'll merge this in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---