You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/04/29 20:14:25 UTC
[GitHub] [geode] echobravopapa opened a new pull request #6401: Backport GEODE-9139
echobravopapa opened a new pull request #6401:
URL: https://github.com/apache/geode/pull/6401
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] kamilla1201 commented on pull request #6401: Backport GEODE-9139
Posted by GitBox <gi...@apache.org>.
kamilla1201 commented on pull request #6401:
URL: https://github.com/apache/geode/pull/6401#issuecomment-829642270
Shouldn't the commit message include "cherry picked from..."? Also, it doesn't mention the ticket number and/or title.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #6401: Backport GEODE-9139
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #6401:
URL: https://github.com/apache/geode/pull/6401#issuecomment-832331919
This pull request **fixes 1 alert** when merging 59849b385b4b022bd3701dd9dc1876e897328f51 into bd02d4aa0cba5ba02974feb8aa8bc86164f4159c - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-61ccad9f9ac4b01fb189309f94423846dcec7baf)
**fixed alerts:**
* 1 for Use of externally\-controlled format string
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #6401: Backport GEODE-9139
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #6401:
URL: https://github.com/apache/geode/pull/6401#issuecomment-829691759
This pull request **fixes 1 alert** when merging 92447ced5e1265f7c0e1d21429df4d9bce542fc9 into ecda3f3a55e9ab9bfb3a042378361b08cce11416 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-6ccd1ee4e8203a7d858af0475aeb633a77e19ae4)
**fixed alerts:**
* 1 for Use of externally\-controlled format string
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] nabarunnag merged pull request #6401: Backport GEODE-9139
Posted by GitBox <gi...@apache.org>.
nabarunnag merged pull request #6401:
URL: https://github.com/apache/geode/pull/6401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] echobravopapa commented on pull request #6401: Backport GEODE-9139
Posted by GitBox <gi...@apache.org>.
echobravopapa commented on pull request #6401:
URL: https://github.com/apache/geode/pull/6401#issuecomment-829647546
@kamilla1201 I re-did the cherry-pick and force pushed... lmk how this looks now, thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #6401: Backport GEODE-9139
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #6401:
URL: https://github.com/apache/geode/pull/6401#issuecomment-829591299
This pull request **fixes 1 alert** when merging cf3bfacb079f8ec18b400e022eb8d65971590aeb into c9116432fba590e109f65788b6bc3b2574e7b2a1 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-5ed04546fdd3f89de87b4e2a0d9ad137a21d1b58)
**fixed alerts:**
* 1 for Use of externally\-controlled format string
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] echobravopapa commented on pull request #6401: Backport GEODE-9139
Posted by GitBox <gi...@apache.org>.
echobravopapa commented on pull request #6401:
URL: https://github.com/apache/geode/pull/6401#issuecomment-829644483
@kamilla1201 good catch, I need to redo this cherry-pick, I accidentally did part of it manually...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] nabarunnag merged pull request #6401: Backport GEODE-9139
Posted by GitBox <gi...@apache.org>.
nabarunnag merged pull request #6401:
URL: https://github.com/apache/geode/pull/6401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org