[GitHub] [superset] AAfghahi commented on a change in pull request #15852: feat: add active email toggle and dropdown on dashboard

[GitBox <gi...@apache.org>]

AAfghahi commented on a change in pull request #15852:
URL: https://github.com/apache/superset/pull/15852#discussion_r675844431



##########
File path: superset-frontend/src/dashboard/components/Header/index.jsx
##########
@@ -376,11 +377,27 @@ class Header extends React.PureComponent {
     this.setState({ showingReportModal: false });
   }
 
-  handleReportClick() {
+  reportModal() {
     const attachedReportExists = this.props.report?.count > 0;
-    if (!attachedReportExists) {
-      this.showReportModal();
-    }
+    return !attachedReportExists ? (

Review comment:
       yes, that makes so much sense. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org