You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/08/23 23:55:27 UTC
[kudu-CR](branch-1.17.x) KUDU-3359 Allow multi-JAR cp for Ranger client
Hello Kudu Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/20416
to review the following change.
Change subject: KUDU-3359 Allow multi-JAR cp for Ranger client
......................................................................
KUDU-3359 Allow multi-JAR cp for Ranger client
In order to let Ranger client to write audit to HDFS, Hadoop client
JARs need to be loaded. To make sure this is possible to do, this commit
changes the behavior of the ranger_jar_path to allow colon-separated JAR
classpaths to be passed to Java.
Change-Id: If137b5541b948506372db50e984eeee7e05dfd22
Reviewed-on: http://gerrit.cloudera.org:8080/20346
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 6b1240afc7e7d4c5730ff6fc61927177df607b2a)
---
M src/kudu/ranger/ranger_client-test.cc
M src/kudu/ranger/ranger_client.cc
M src/kudu/ranger/ranger_client.h
3 files changed, 55 insertions(+), 27 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/20416/1
--
To view, visit http://gerrit.cloudera.org:8080/20416
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: If137b5541b948506372db50e984eeee7e05dfd22
Gerrit-Change-Number: 20416
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.17.x) KUDU-3359 Allow multi-JAR cp for Ranger client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20416 )
Change subject: KUDU-3359 Allow multi-JAR cp for Ranger client
......................................................................
Patch Set 1:
> The conflicts are needed to be fixed.
I guess there are no conflicts once the two prior changelists are in there, right?
--
To view, visit http://gerrit.cloudera.org:8080/20416
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: If137b5541b948506372db50e984eeee7e05dfd22
Gerrit-Change-Number: 20416
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Thu, 24 Aug 2023 05:15:39 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) KUDU-3359 Allow multi-JAR cp for Ranger client
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20416 )
Change subject: KUDU-3359 Allow multi-JAR cp for Ranger client
......................................................................
Patch Set 1: Code-Review+2
The conflicts are needed to be fixed.
--
To view, visit http://gerrit.cloudera.org:8080/20416
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: If137b5541b948506372db50e984eeee7e05dfd22
Gerrit-Change-Number: 20416
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Thu, 24 Aug 2023 03:03:44 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) KUDU-3359 Allow multi-JAR cp for Ranger client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20416 )
Change subject: KUDU-3359 Allow multi-JAR cp for Ranger client
......................................................................
KUDU-3359 Allow multi-JAR cp for Ranger client
In order to let Ranger client to write audit to HDFS, Hadoop client
JARs need to be loaded. To make sure this is possible to do, this commit
changes the behavior of the ranger_jar_path to allow colon-separated JAR
classpaths to be passed to Java.
Change-Id: If137b5541b948506372db50e984eeee7e05dfd22
Reviewed-on: http://gerrit.cloudera.org:8080/20346
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 6b1240afc7e7d4c5730ff6fc61927177df607b2a)
Reviewed-on: http://gerrit.cloudera.org:8080/20416
Reviewed-by: Yingchun Lai <la...@apache.org>
---
M src/kudu/ranger/ranger_client-test.cc
M src/kudu/ranger/ranger_client.cc
M src/kudu/ranger/ranger_client.h
3 files changed, 55 insertions(+), 27 deletions(-)
Approvals:
Kudu Jenkins: Verified
Yingchun Lai: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/20416
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: If137b5541b948506372db50e984eeee7e05dfd22
Gerrit-Change-Number: 20416
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>