You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "kfaraz (via GitHub)" <gi...@apache.org> on 2023/01/31 09:36:19 UTC
[GitHub] [druid] kfaraz opened a new pull request, #13725: Make batch segment allocation logs less noisy
kfaraz opened a new pull request, #13725:
URL: https://github.com/apache/druid/pull/13725
## Changes
- Change some batch allocation logs from info to debug as these are noisy and make debugging actual issues difficult
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] kfaraz commented on a diff in pull request #13725: Make batch segment allocation logs less noisy
Posted by "kfaraz (via GitHub)" <gi...@apache.org>.
kfaraz commented on code in PR #13725:
URL: https://github.com/apache/druid/pull/13725#discussion_r1091924583
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/actions/SegmentAllocationQueue.java:
##########
@@ -355,7 +353,7 @@ private boolean processBatch(AllocateRequestBatch requestBatch)
emitBatchMetric("task/action/batch/attempts", 1L, requestKey);
emitBatchMetric("task/action/batch/runTime", (System.currentTimeMillis() - startTimeMillis), requestKey);
- log.info("Successfully processed [%d / %d] requests in batch [%s].", successCount, batchSize, requestKey);
+ log.debug("Successfully processed [%d / %d] requests in batch [%s].", successCount, batchSize, requestKey);
Review Comment:
It is once per batch, so I guess we can go either way with this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] kfaraz merged pull request #13725: Make batch segment allocation logs less noisy
Posted by "kfaraz (via GitHub)" <gi...@apache.org>.
kfaraz merged PR #13725:
URL: https://github.com/apache/druid/pull/13725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 commented on a diff in pull request #13725: Make batch segment allocation logs less noisy
Posted by "abhishekagarwal87 (via GitHub)" <gi...@apache.org>.
abhishekagarwal87 commented on code in PR #13725:
URL: https://github.com/apache/druid/pull/13725#discussion_r1091910208
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/actions/SegmentAllocationQueue.java:
##########
@@ -301,7 +299,7 @@ private void processBatchesDue()
nextScheduleDelay = Math.max(0, maxWaitTimeMillis - timeElapsed);
}
scheduleQueuePoll(nextScheduleDelay);
- log.info("Processed [%d] batches, next execution in [%d ms]", numProcessedBatches, nextScheduleDelay);
+ log.debug("Processed [%d] batches, next execution in [%d ms]", numProcessedBatches, nextScheduleDelay);
Review Comment:
this is the noisy line, right?
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/actions/SegmentAllocationQueue.java:
##########
@@ -601,7 +599,7 @@ synchronized void handleResult(SegmentAllocateResult result, SegmentAllocateRequ
emitTaskMetric("task/action/success/count", 1L, request);
requestToFuture.remove(request).complete(result.getSegmentId());
} else if (request.canRetry()) {
- log.info(
+ log.debug(
Review Comment:
this should still be info.
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/actions/SegmentAllocationQueue.java:
##########
@@ -355,7 +353,7 @@ private boolean processBatch(AllocateRequestBatch requestBatch)
emitBatchMetric("task/action/batch/attempts", 1L, requestKey);
emitBatchMetric("task/action/batch/runTime", (System.currentTimeMillis() - startTimeMillis), requestKey);
- log.info("Successfully processed [%d / %d] requests in batch [%s].", successCount, batchSize, requestKey);
+ log.debug("Successfully processed [%d / %d] requests in batch [%s].", successCount, batchSize, requestKey);
Review Comment:
is it too noisy?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] kfaraz commented on a diff in pull request #13725: Make batch segment allocation logs less noisy
Posted by "kfaraz (via GitHub)" <gi...@apache.org>.
kfaraz commented on code in PR #13725:
URL: https://github.com/apache/druid/pull/13725#discussion_r1091923443
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/actions/SegmentAllocationQueue.java:
##########
@@ -301,7 +299,7 @@ private void processBatchesDue()
nextScheduleDelay = Math.max(0, maxWaitTimeMillis - timeElapsed);
}
scheduleQueuePoll(nextScheduleDelay);
- log.info("Processed [%d] batches, next execution in [%d ms]", numProcessedBatches, nextScheduleDelay);
+ log.debug("Processed [%d] batches, next execution in [%d ms]", numProcessedBatches, nextScheduleDelay);
Review Comment:
Yes, this adds a log line typically every 0.5 s even when not doing anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org