You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "PDavid (via GitHub)" <gi...@apache.org> on 2024/12/18 07:34:27 UTC

[PR] HBASE-29037 Backport missing UI patches to branch-2 [hbase]

PDavid opened a new pull request, #6551:
URL: https://github.com/apache/hbase/pull/6551

   Cherry-picked the following patches which were missing on `branch-2` branch. Most of these applied as a clean cherry-pick (without conflicts). Unfortunately there were some which had conflicts and I manually resolved them.
   Each commit message contains from which commit it was cherry-picked from.
   
   - HBASE-24624 Optimize table.jsp code (#1963) - :warning: This did not apply cleanly - had to resolve conflicts manually
   - HBASE-25402 Sorting order by start key or end key is not considering empty start key/end key (#2955)
   - HBASE-28778 NPE may occur when opening master-status or table.jsp or procedure.jsp while Master is initializing (#6152)
   - HBASE-20452 Master UI: Table merge button should validate required fields before submit
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-29037 Backport missing UI patches to branch-2 [hbase]

Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #6551:
URL: https://github.com/apache/hbase/pull/6551#issuecomment-2556344847

   Reviewing commit by commit:
   1. [HBASE-24624](https://issues.apache.org/jira/browse/HBASE-24624) Optimize table.jsp code: This change is huge wrt to original PR, @PDavid could you summarise what all we changed here? Is this an whitespace issue? Mind fixing it?
   2. [HBASE-25402](https://issues.apache.org/jira/browse/HBASE-25402) Sorting order by start key or end key is not considering empty start key/end key: LGTM
   3. [HBASE-28778](https://issues.apache.org/jira/browse/HBASE-28778) NPE may occur when opening master-status or table.jsp or procedure.jsp while Master is initializing : Apparently this was already backported with original ticket, we just missed a few files back then.! LGTM
   4. [HBASE-20452](https://issues.apache.org/jira/browse/HBASE-20452) Master UI: Table merge button should validate required fields before submit: LGTM
   
   Also could you please summarise how the changes have been tested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-29037 Backport missing UI patches to branch-2 [hbase]

Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #6551:
URL: https://github.com/apache/hbase/pull/6551#issuecomment-2560705066

   Thanks @Apache9 for testing out. We can look if anything needs to be done for whitespace later. Skimmed commit 1, LGTM Merging this to codebase.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-29037 Backport missing UI patches to branch-2 [hbase]

Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6551:
URL: https://github.com/apache/hbase/pull/6551#issuecomment-2551000439

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   0m 24s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  5s |  |  Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
   |||| _ Prechecks _ |
   |||| _ branch-2 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 50s |  |  branch-2 passed  |
   | +1 :green_heart: |  javadoc  |   0m 30s |  |  branch-2 passed  |
   |||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m  0s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 30s |  |  the patch passed  |
   |||| _ Other Tests _ |
   | -1 :x: |  unit  | 175m 12s | [/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6551/1/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt) |  hbase-server in the patch failed.  |
   |  |   | 186m 24s |  |  |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6551/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/6551 |
   | Optional Tests | javac javadoc unit |
   | uname | Linux b01ad179e8c0 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / efc79d09574cc9c15450e7547315807c977dce45 |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   |  Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6551/1/testReport/ |
   | Max. process+thread count | 4550 (vs. ulimit of 30000) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6551/1/console |
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-29037 Backport missing UI patches to branch-2 [hbase]

Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #6551:
URL: https://github.com/apache/hbase/pull/6551#issuecomment-2572868319

   Thanks @PDavid for the response, I think we are good here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-29037 Backport missing UI patches to branch-2 [hbase]

Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6551:
URL: https://github.com/apache/hbase/pull/6551#issuecomment-2551029092

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   0m 49s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  5s |  |  Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
   |||| _ Prechecks _ |
   |||| _ branch-2 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 54s |  |  branch-2 passed  |
   | +1 :green_heart: |  javadoc  |   0m 35s |  |  branch-2 passed  |
   |||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 31s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 25s |  |  the patch passed  |
   |||| _ Other Tests _ |
   | -1 :x: |  unit  | 188m  3s | [/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6551/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt) |  hbase-server in the patch failed.  |
   |  |   | 199m 49s |  |  |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6551/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/6551 |
   | Optional Tests | javac javadoc unit |
   | uname | Linux 619d2d61c4b4 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / efc79d09574cc9c15450e7547315807c977dce45 |
   | Default Java | Temurin-1.8.0_412-b08 |
   |  Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6551/1/testReport/ |
   | Max. process+thread count | 4120 (vs. ulimit of 30000) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6551/1/console |
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-29037 Backport missing UI patches to branch-2 [hbase]

Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6551:
URL: https://github.com/apache/hbase/pull/6551#issuecomment-2550606841

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   1m  0s |  |  Docker mode activated.  |
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain any @author tags.  |
   |||| _ branch-2 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 29s |  |  branch-2 passed  |
   | +1 :green_heart: |  spotless  |   1m  2s |  |  branch has no errors when running spotless:check.  |
   |||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m  7s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks issues.  |
   | +1 :green_heart: |  spotless  |   0m 48s |  |  patch has no errors when running spotless:check.  |
   |||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 14s |  |  The patch does not generate ASF License warnings.  |
   |  |   |  12m 58s |  |  |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6551/1/artifact/yetus-general-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/6551 |
   | Optional Tests | dupname asflicense javac codespell detsecrets spotless |
   | uname | Linux 02aa5827247e 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / efc79d09574cc9c15450e7547315807c977dce45 |
   | Default Java | Eclipse Adoptium-11.0.23+9 |
   | Max. process+thread count | 79 (vs. ulimit of 30000) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6551/1/console |
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-29037 Backport missing UI patches to branch-2 [hbase]

Posted by "PDavid (via GitHub)" <gi...@apache.org>.
PDavid commented on PR #6551:
URL: https://github.com/apache/hbase/pull/6551#issuecomment-2572800297

   Hi @NihalJain and @Apache9,
   
   Many thanks for your reviews and tests. :pray: 
   
   Sorry, I was completely off in the holiday season.
   
   > 1. [HBASE-24624](https://issues.apache.org/jira/browse/HBASE-24624) Optimize table.jsp code: TODO
   >    
   >    * This change is huge wrt to original PR, @PDavid could you summarise what all we changed here? Is there a whitespace issue? Mind fixing it? Or are you doing this to align with Master?
   
   The motivation behind these backport UI changes PR-s (and this specific backport you mention) is to align with master branch so that the Boostrap upgrade can be backported more cleanly.
   
   Here the problem was that - if you check the history of table.jsp on master branch and on branch-2 - that this "Optimize table.jsp code" patch was missing from branch-2 but the newer patches were applied (backported) on branch-2. This made table.jsp quite different than it was when "Optimize table.jsp code" patch was merged to master branch.
   
   So when I backported this change I was extra careful to not to "undo" the changes which newer backported patches did.
   
   
   > Also could you please summarise how the changes have been tested.
   
   Sure. I built the project in dev mode with `mvn clean install -DskipTests -Dhadoop.profile=3.0` then started HBase locally with `bin/start-hbase.sh` in standalone mode. Created some tables with some rows and checked the Master UI, region server UI. 
   Started Thrift server (`bin/hbase thrift start -p 8081`) and REST server (`bin/hbase rest start -p 8080`) and checked their UI respectively. 
   
   To properly verify the REST UI I had to copy the `static` resources folder under `hbase-rest/src/main/resources/hbase-webapps` folder because of the REST UI is broken (static resources are not loaded) https://issues.apache.org/jira/browse/HBASE-28983 issue - but this change I did not committed as there is a separate Jira.
   
   Hope this answers your question.
   
   Any suggestions maybe in regards to testing?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-29037 Backport missing UI patches to branch-2 [hbase]

Posted by "PDavid (via GitHub)" <gi...@apache.org>.
PDavid commented on PR #6551:
URL: https://github.com/apache/hbase/pull/6551#issuecomment-2553086947

   Hi @NihalJain,
   Many thanks, I think this is now ready to review. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-29037 Backport missing UI patches to branch-2 [hbase]

Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6551:
URL: https://github.com/apache/hbase/pull/6551#issuecomment-2551764651

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   0m 23s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  5s |  |  Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
   |||| _ Prechecks _ |
   |||| _ branch-2 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 35s |  |  branch-2 passed  |
   | +1 :green_heart: |  javadoc  |   0m 28s |  |  branch-2 passed  |
   |||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 39s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 27s |  |  the patch passed  |
   |||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 205m  4s |  |  hbase-server in the patch passed.  |
   |  |   | 215m 53s |  |  |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6551/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/6551 |
   | Optional Tests | javac javadoc unit |
   | uname | Linux a81bfaf70127 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / efc79d09574cc9c15450e7547315807c977dce45 |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   |  Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6551/2/testReport/ |
   | Max. process+thread count | 4660 (vs. ulimit of 30000) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6551/2/console |
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-29037 Backport missing UI patches to branch-2 [hbase]

Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #6551:
URL: https://github.com/apache/hbase/pull/6551#issuecomment-2552854848

   Hi @PDavid please let me know once this PR is ready for review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-29037 Backport missing UI patches to branch-2 [hbase]

Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6551:
URL: https://github.com/apache/hbase/pull/6551#issuecomment-2551261130

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   0m 47s |  |  Docker mode activated.  |
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain any @author tags.  |
   |||| _ branch-2 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 39s |  |  branch-2 passed  |
   | +1 :green_heart: |  spotless  |   0m 42s |  |  branch has no errors when running spotless:check.  |
   |||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 36s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks issues.  |
   | +1 :green_heart: |  spotless  |   0m 41s |  |  patch has no errors when running spotless:check.  |
   |||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 11s |  |  The patch does not generate ASF License warnings.  |
   |  |   |   8m 43s |  |  |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6551/2/artifact/yetus-general-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/6551 |
   | Optional Tests | dupname asflicense javac codespell detsecrets spotless |
   | uname | Linux 7874217ca65c 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / efc79d09574cc9c15450e7547315807c977dce45 |
   | Default Java | Eclipse Adoptium-11.0.23+9 |
   | Max. process+thread count | 79 (vs. ulimit of 30000) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6551/2/console |
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-29037 Backport missing UI patches to branch-2 [hbase]

Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6551:
URL: https://github.com/apache/hbase/pull/6551#issuecomment-2551031745

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   0m 45s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  4s |  |  Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
   |||| _ Prechecks _ |
   |||| _ branch-2 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 12s |  |  branch-2 passed  |
   | +1 :green_heart: |  javadoc  |   0m 34s |  |  branch-2 passed  |
   |||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m  6s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 25s |  |  the patch passed  |
   |||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 188m 41s |  |  hbase-server in the patch passed.  |
   |  |   | 201m  6s |  |  |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6551/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/6551 |
   | Optional Tests | javac javadoc unit |
   | uname | Linux 926396d173d6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / efc79d09574cc9c15450e7547315807c977dce45 |
   | Default Java | Eclipse Adoptium-11.0.23+9 |
   |  Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6551/1/testReport/ |
   | Max. process+thread count | 4183 (vs. ulimit of 30000) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6551/1/console |
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-29037 Backport missing UI patches to branch-2 [hbase]

Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6551:
URL: https://github.com/apache/hbase/pull/6551#issuecomment-2551721444

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   0m 50s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  5s |  |  Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
   |||| _ Prechecks _ |
   |||| _ branch-2 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 54s |  |  branch-2 passed  |
   | +1 :green_heart: |  javadoc  |   0m 25s |  |  branch-2 passed  |
   |||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 49s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 24s |  |  the patch passed  |
   |||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 185m  5s |  |  hbase-server in the patch passed.  |
   |  |   | 196m 43s |  |  |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6551/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/6551 |
   | Optional Tests | javac javadoc unit |
   | uname | Linux fd5cfbf53ae2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / efc79d09574cc9c15450e7547315807c977dce45 |
   | Default Java | Eclipse Adoptium-11.0.23+9 |
   |  Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6551/2/testReport/ |
   | Max. process+thread count | 4134 (vs. ulimit of 30000) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6551/2/console |
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-29037 Backport missing UI patches to branch-2 [hbase]

Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6551:
URL: https://github.com/apache/hbase/pull/6551#issuecomment-2551725374

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   0m 50s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  5s |  |  Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
   |||| _ Prechecks _ |
   |||| _ branch-2 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 44s |  |  branch-2 passed  |
   | +1 :green_heart: |  javadoc  |   0m 25s |  |  branch-2 passed  |
   |||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 24s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 24s |  |  the patch passed  |
   |||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 186m 54s |  |  hbase-server in the patch passed.  |
   |  |   | 198m 17s |  |  |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6551/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/6551 |
   | Optional Tests | javac javadoc unit |
   | uname | Linux 2b7d012ee11d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / efc79d09574cc9c15450e7547315807c977dce45 |
   | Default Java | Temurin-1.8.0_412-b08 |
   |  Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6551/2/testReport/ |
   | Max. process+thread count | 4150 (vs. ulimit of 30000) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6551/2/console |
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-29037 Backport missing UI patches to branch-2 [hbase]

Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain merged PR #6551:
URL: https://github.com/apache/hbase/pull/6551


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org