[GitHub] [incubator-superset] etr2460 opened a new pull request #7864: [Profile] Fix 5xx when user not found

[GitBox <gi...@apache.org>]

etr2460 opened a new pull request #7864: [Profile] Fix 5xx when user not found
URL: https://github.com/apache/incubator-superset/pull/7864
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [x] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   When trying to view a user's profile that doesn't exist, we'd return a 5xx. This should be a 404 instead.
   
   Still todo: a more user friendly 404 page
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   Before:
   <img width="829" alt="Screen Shot 2019-07-12 at 11 18 06 AM" src="https://user-images.githubusercontent.com/7409244/61149781-ce9dab80-a496-11e9-8f7f-4f6b9f76df3e.png">
   
   After:
   <img width="758" alt="Screen Shot 2019-07-12 at 11 18 16 AM" src="https://user-images.githubusercontent.com/7409244/61149790-d2c9c900-a496-11e9-87c9-349e958acf01.png">
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   See 404 page at: http://localhost:5000/superset/profile/sddsgdsg/
   See profile page at: http://localhost:5000/superset/profile/admin/
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @john-bodley @michellethomas 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org