You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by sjcorbett <gi...@git.apache.org> on 2017/07/11 10:31:37 UTC
[GitHub] brooklyn-server pull request #760: Add DigitalOcean2 and ProfitBricks featur...
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-server/pull/760
Add DigitalOcean2 and ProfitBricks features to Karaf build
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sjcorbett/brooklyn-server features
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/760.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #760
----
commit 57b1858c96d04bd90754e813ca0b316972708698
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Date: 2017-07-11T10:29:44Z
Add DigitalOcean2 and ProfitBricks features to Karaf build
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #760: Add DigitalOcean2 and ProfitBricks features to K...
Posted by andreaturli <gi...@git.apache.org>.
Github user andreaturli commented on the issue:
https://github.com/apache/brooklyn-server/pull/760
thanks @sjcorbett -- would it be useful to add a comment in the `feature.xml` to remember to use `jclouds-all-compute` from https://github.com/jclouds/jclouds-karaf/blob/master/feature/src/main/feature/feature.xml and `jclouds-labs-all-compute` from https://github.com/jclouds/jclouds-karaf/blob/master/feature-labs/src/main/feature/feature.xml when we bump to `jclouds 2.1.x` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #760: Add DigitalOcean2 and ProfitBricks featur...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/760
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #760: Add DigitalOcean2 and ProfitBricks features to K...
Posted by drigodwin <gi...@git.apache.org>.
Github user drigodwin commented on the issue:
https://github.com/apache/brooklyn-server/pull/760
I think that is a good point but probably outside the scope of this PR @andreaturli so it shouldn't stop this being merged. This looks fine to me, so I'm going to merge now, thanks @sjcorbett.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---