[jira] [Commented] (HADOOP-11452) Make FileSystem.rename(path, path, options) public, specified, tested

["Hadoop QA (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-11452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187078#comment-17187078 ] 

Hadoop QA commented on HADOOP-11452:
------------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  9s{color} | {color:red} HADOOP-11452 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HADOOP-11452 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12955085/HADOOP-14452-004.patch |
| Console output | https://ci-hadoop.apache.org/job/PreCommit-HADOOP-Build/49/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org |


This message was automatically generated.



> Make FileSystem.rename(path, path, options) public, specified, tested
> ---------------------------------------------------------------------
>
>                 Key: HADOOP-11452
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11452
>             Project: Hadoop Common
>          Issue Type: Task
>          Components: fs
>    Affects Versions: 2.7.3
>            Reporter: Yi Liu
>            Assignee: Steve Loughran
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HADOOP-11452-001.patch, HADOOP-11452-002.patch, HADOOP-14452-004.patch, HADOOP-14452-branch-2-003.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently in {{FileSystem}}, {{rename}} with _Rename options_ is protected and with _deprecated_ annotation. And the default implementation is not atomic.
> So this method is not able to be used outside. On the other hand, HDFS has a good and atomic implementation. (Also an interesting thing in {{DFSClient}}, the _deprecated_ annotations for these two methods are opposite).
> It makes sense to make public for {{rename}} with _Rename options_, since it's atomic for rename+overwrite, also it saves RPC calls if user desires rename+overwrite.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org