You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Piotr Nowojski (Jira)" <ji...@apache.org> on 2021/10/04 16:15:00 UTC
[jira] [Issue Comment Deleted] (FLINK-24269) Rename methods around
final checkpoints
[ https://issues.apache.org/jira/browse/FLINK-24269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Piotr Nowojski updated FLINK-24269:
-----------------------------------
Comment: was deleted
(was: This change looks like it caused a benchmark build failure:
{noformat}
15:27:27 ERROR: org.openjdk.jmh.runner.RunnerException: Benchmark caught the exception
15:27:27 at org.openjdk.jmh.runner.Runner.runBenchmarks(Runner.java:570)
15:27:27 at org.openjdk.jmh.runner.Runner.internalRun(Runner.java:313)
15:27:27 at org.openjdk.jmh.runner.Runner.run(Runner.java:206)
15:27:27 at org.openjdk.jmh.Main.main(Main.java:71)
15:27:27 Caused by: org.openjdk.jmh.runner.BenchmarkException: Benchmark error during the run
15:27:27 at org.openjdk.jmh.runner.BenchmarkHandler.runIteration(BenchmarkHandler.java:428)
15:27:27 at org.openjdk.jmh.runner.BaseRunner.runBenchmark(BaseRunner.java:262)
15:27:27 at org.openjdk.jmh.runner.BaseRunner.runBenchmark(BaseRunner.java:234)
15:27:27 at org.openjdk.jmh.runner.BaseRunner.doSingle(BaseRunner.java:139)
15:27:27 at org.openjdk.jmh.runner.BaseRunner.runBenchmarksForked(BaseRunner.java:76)
15:27:27 at org.openjdk.jmh.runner.ForkedRunner.run(ForkedRunner.java:72)
15:27:27 at org.openjdk.jmh.runner.ForkedMain.main(ForkedMain.java:84)
15:27:27 Suppressed: org.apache.flink.runtime.client.JobExecutionException: Job execution failed.
15:27:27 at org.apache.flink.runtime.jobmaster.JobResult.toJobExecutionResult(JobResult.java:144)
15:27:27 at org.apache.flink.runtime.minicluster.MiniClusterJobClient.lambda$getJobExecutionResult$3(MiniClusterJobClient.java:137)
15:27:27 at java.util.concurrent.CompletableFuture.uniApply(CompletableFuture.java:616)
15:27:27 at java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:591)
15:27:27 at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:488)
15:27:27 at java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1975)
15:27:27 at org.apache.flink.runtime.rpc.akka.AkkaInvocationHandler.lambda$invokeRpc$0(AkkaInvocationHandler.java:250)
15:27:27 at java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:774)
15:27:27 at java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:750)
15:27:27 at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:488)
15:27:27 at java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1975)
15:27:27 at org.apache.flink.util.concurrent.FutureUtils.doForward(FutureUtils.java:1389)
15:27:27 at org.apache.flink.runtime.concurrent.akka.ClassLoadingUtils.lambda$null$1(ClassLoadingUtils.java:93)
15:27:27 at org.apache.flink.runtime.concurrent.akka.ClassLoadingUtils.runWithContextClassLoader(ClassLoadingUtils.java:68)
15:27:27 at org.apache.flink.runtime.concurrent.akka.ClassLoadingUtils.lambda$guardCompletionWithContextClassLoader$2(ClassLoadingUtils.java:92)
15:27:27 at java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:774)
15:27:27 at java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:750)
15:27:27 at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:488)
15:27:27 at java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1975)
15:27:27 at org.apache.flink.runtime.concurrent.akka.AkkaFutureUtils$1.onComplete(AkkaFutureUtils.java:47)
15:27:27 at akka.dispatch.OnComplete.internal(Future.scala:300)
15:27:27 at akka.dispatch.OnComplete.internal(Future.scala:297)
15:27:27 at akka.dispatch.japi$CallbackBridge.apply(Future.scala:224)
15:27:27 at akka.dispatch.japi$CallbackBridge.apply(Future.scala:221)
15:27:27 at scala.concurrent.impl.CallbackRunnable.run(Promise.scala:60)
15:27:27 at org.apache.flink.runtime.concurrent.akka.AkkaFutureUtils$DirectExecutionContext.execute(AkkaFutureUtils.java:65)
15:27:27 at scala.concurrent.impl.CallbackRunnable.executeWithValue(Promise.scala:68)
15:27:27 at scala.concurrent.impl.Promise$DefaultPromise.$anonfun$tryComplete$1(Promise.scala:284)
15:27:27 at scala.concurrent.impl.Promise$DefaultPromise.$anonfun$tryComplete$1$adapted(Promise.scala:284)
15:27:27 at scala.concurrent.impl.Promise$DefaultPromise.tryComplete(Promise.scala:284)
15:27:27 at akka.pattern.PromiseActorRef.$bang(AskSupport.scala:621)
15:27:27 at akka.pattern.PipeToSupport$PipeableFuture$$anonfun$pipeTo$1.applyOrElse(PipeToSupport.scala:24)
15:27:27 at akka.pattern.PipeToSupport$PipeableFuture$$anonfun$pipeTo$1.applyOrElse(PipeToSupport.scala:23)
15:27:27 at scala.concurrent.Future.$anonfun$andThen$1(Future.scala:532)
15:27:27 at scala.concurrent.impl.Promise.liftedTree1$1(Promise.scala:29)
15:27:27 at scala.concurrent.impl.Promise.$anonfun$transform$1(Promise.scala:29)
15:27:27 at scala.concurrent.impl.CallbackRunnable.run(Promise.scala:60)
15:27:27 at akka.dispatch.BatchingExecutor$AbstractBatch.processBatch(BatchingExecutor.scala:63)
15:27:27 at akka.dispatch.BatchingExecutor$BlockableBatch.$anonfun$run$1(BatchingExecutor.scala:100)
15:27:27 at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:12)
15:27:27 at scala.concurrent.BlockContext$.withBlockContext(BlockContext.scala:81)
15:27:27 at akka.dispatch.BatchingExecutor$BlockableBatch.run(BatchingExecutor.scala:100)
15:27:27 at akka.dispatch.TaskInvocation.run(AbstractDispatcher.scala:49)
15:27:27 at akka.dispatch.ForkJoinExecutorConfigurator$AkkaForkJoinTask.exec(ForkJoinExecutorConfigurator.scala:48)
15:27:27 at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
15:27:27 at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
15:27:27 at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
15:27:27 at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:175)
15:27:27 Caused by: org.apache.flink.runtime.JobException: Recovery is suppressed by NoRestartBackoffTimeStrategy
15:27:27 at org.apache.flink.runtime.executiongraph.failover.flip1.ExecutionFailureHandler.handleFailure(ExecutionFailureHandler.java:138)
15:27:27 at org.apache.flink.runtime.executiongraph.failover.flip1.ExecutionFailureHandler.getFailureHandlingResult(ExecutionFailureHandler.java:82)
15:27:27 at org.apache.flink.runtime.scheduler.DefaultScheduler.handleTaskFailure(DefaultScheduler.java:228)
15:27:27 at org.apache.flink.runtime.scheduler.DefaultScheduler.maybeHandleTaskFailure(DefaultScheduler.java:218)
15:27:27 at org.apache.flink.runtime.scheduler.DefaultScheduler.updateTaskExecutionStateInternal(DefaultScheduler.java:209)
15:27:27 at org.apache.flink.runtime.scheduler.SchedulerBase.updateTaskExecutionState(SchedulerBase.java:678)
15:27:27 at org.apache.flink.runtime.scheduler.SchedulerNG.updateTaskExecutionState(SchedulerNG.java:79)
15:27:27 at org.apache.flink.runtime.jobmaster.JobMaster.updateTaskExecutionState(JobMaster.java:444)
15:27:27 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
15:27:27 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
15:27:27 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
15:27:27 at java.lang.reflect.Method.invoke(Method.java:498)
15:27:27 at org.apache.flink.runtime.rpc.akka.AkkaRpcActor.lambda$handleRpcInvocation$1(AkkaRpcActor.java:316)
15:27:27 at org.apache.flink.runtime.concurrent.akka.ClassLoadingUtils.runWithContextClassLoader(ClassLoadingUtils.java:83)
15:27:27 at org.apache.flink.runtime.rpc.akka.AkkaRpcActor.handleRpcInvocation(AkkaRpcActor.java:314)
15:27:27 at org.apache.flink.runtime.rpc.akka.AkkaRpcActor.handleRpcMessage(AkkaRpcActor.java:217)
15:27:27 at org.apache.flink.runtime.rpc.akka.FencedAkkaRpcActor.handleRpcMessage(FencedAkkaRpcActor.java:78)
15:27:27 at org.apache.flink.runtime.rpc.akka.AkkaRpcActor.handleMessage(AkkaRpcActor.java:163)
15:27:27 at akka.japi.pf.UnitCaseStatement.apply(CaseStatements.scala:24)
15:27:27 at akka.japi.pf.UnitCaseStatement.apply(CaseStatements.scala:20)
15:27:27 at scala.PartialFunction.applyOrElse(PartialFunction.scala:123)
15:27:27 at scala.PartialFunction.applyOrElse$(PartialFunction.scala:122)
15:27:27 at akka.japi.pf.UnitCaseStatement.applyOrElse(CaseStatements.scala:20)
15:27:27 at scala.PartialFunction$OrElse.applyOrElse(PartialFunction.scala:171)
15:27:27 at scala.PartialFunction$OrElse.applyOrElse(PartialFunction.scala:172)
15:27:27 at scala.PartialFunction$OrElse.applyOrElse(PartialFunction.scala:172)
15:27:27 at akka.actor.Actor.aroundReceive(Actor.scala:537)
15:27:27 at akka.actor.Actor.aroundReceive$(Actor.scala:535)
15:27:27 at akka.actor.AbstractActor.aroundReceive(AbstractActor.scala:220)
15:27:27 at akka.actor.ActorCell.receiveMessage(ActorCell.scala:580)
15:27:27 at akka.actor.ActorCell.invoke(ActorCell.scala:548)
15:27:27 at akka.dispatch.Mailbox.processMailbox(Mailbox.scala:270)
15:27:27 at akka.dispatch.Mailbox.run(Mailbox.scala:231)
15:27:27 at akka.dispatch.Mailbox.exec(Mailbox.scala:243)
15:27:27 ... 4 more
15:27:27 Caused by: java.lang.NoSuchMethodError: org.apache.flink.runtime.state.TaskStateManager.isFinishedOnRestore()Z
15:27:27 at org.apache.flink.streaming.runtime.tasks.StreamTask.restoreInternal(StreamTask.java:666)
15:27:27 at org.apache.flink.streaming.runtime.tasks.StreamTask.restore(StreamTask.java:654)
15:27:27 at org.apache.flink.runtime.taskmanager.Task.runWithSystemExitMonitoring(Task.java:958)
15:27:27 at org.apache.flink.runtime.taskmanager.Task.restoreAndInvoke(Task.java:927)
15:27:27 at org.apache.flink.runtime.taskmanager.Task.doRun(Task.java:754)
15:27:27 at org.apache.flink.runtime.taskmanager.Task.run(Task.java:575)
15:27:27 at java.lang.Thread.run(Thread.java:748)
{noformat}
)
> Rename methods around final checkpoints
> ---------------------------------------
>
> Key: FLINK-24269
> URL: https://issues.apache.org/jira/browse/FLINK-24269
> Project: Flink
> Issue Type: Sub-task
> Components: Runtime / Checkpointing
> Reporter: Dawid Wysakowicz
> Assignee: liwei li
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.15.0
>
>
> We should rename:
> * {{TaskStateSnapshot.isFinishedOnRestore()}} to {{isTaskDeployedAsFinished}}
> * {{TaskStateSnapshot.isOperatorsFinished()}} to {{isTaskFinished}}
> * {{PendingCheckpoint#updateNonFinishedOnRestoreOperatorState}} to {{updateOperatorState}}
> For context see: https://github.com/apache/flink/pull/16655#issuecomment-899603149
--
This message was sent by Atlassian Jira
(v8.3.4#803005)