You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "1996fanrui (via GitHub)" <gi...@apache.org> on 2023/12/01 08:19:23 UTC

[PR] [FLINK-33693][checkpoint] Force aligned barrier works with timeoutable aligned checkpoint barrier [flink]

1996fanrui opened a new pull request, #23850:
URL: https://github.com/apache/flink/pull/23850

   ## What is the purpose of the change
   
   FLINK-21945 will convert the unaligned checkpoint barrier and timeoutable aligned checkpoint barrier to force aligned barrier. However, Force aligned barrier logic doesn't work for  timeoutable aligned checkpoint barrier.
   
   Bug at org.apache.flink.streaming.runtime.io.RecordWriterOutput#broadcastEvent, we will call withUnalignedUnsupported to convert the unaligned checkpoint barrier to FORCED_ALIGNED barrier when the supportsUnalignedCheckpoints is false.
   
   However, the if has one condition: isPriorityEvent. When  aligned checkpoint timeout is enabled, flink will emit one timeoutable barrier. It isn't PriorityEvent.
   
   
   ## Brief change log
   
   [FLINK-33693][checkpoint] Force aligned barrier works with timeoutable aligned checkpoint barrier
   
   - Remove the condition: isPriorityEvent
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
     - `Added test: `RecordWriterOutputTest#testDisableUnalignedCheckpoint`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector:no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-33693][checkpoint] Force aligned barrier works with timeoutable aligned checkpoint barrier [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #23850:
URL: https://github.com/apache/flink/pull/23850#issuecomment-1835672439

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3a9aa8113280285dccb25fc09de3bacdc277b122",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "3a9aa8113280285dccb25fc09de3bacdc277b122",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3a9aa8113280285dccb25fc09de3bacdc277b122 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-33693][checkpoint] Force aligned barrier works with timeoutable aligned checkpoint barrier [flink]

Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui merged PR #23850:
URL: https://github.com/apache/flink/pull/23850


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-33693][checkpoint] Force aligned barrier works with timeoutable aligned checkpoint barrier [flink]

Posted by "pnowojski (via GitHub)" <gi...@apache.org>.
pnowojski commented on PR #23850:
URL: https://github.com/apache/flink/pull/23850#issuecomment-1845016221

   Ops, that's a dangerous bug. Thanks for fixing it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org