[GitHub] [incubator-pegasus] GehaFearless commented on a diff in pull request #1373: refactor(test): add bench type multi set/get

["GehaFearless (via GitHub)" <gi...@apache.org>]

GehaFearless commented on code in PR #1373:
URL: https://github.com/apache/incubator-pegasus/pull/1373#discussion_r1119919909


##########
src/test/bench_test/benchmark.cpp:
##########
@@ -191,6 +235,58 @@ void benchmark::read_random(thread_arg *thread)
     thread->stats.add_message(msg);
 }
 
+void benchmark::multi_get_random(thread_arg *thread)

Review Comment:
   Do you means the count of values for the same hashkey? 
   To reuse params nums for other tests, I gave it a default number of 100. Refactoring is complex, and I think it's enough here to expose some problems



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org