You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/09/30 12:42:02 UTC

[GitHub] [pulsar] congbobo184 opened a new pull request #8170: Redeliver response implement

congbobo184 opened a new pull request #8170:
URL: https://github.com/apache/pulsar/pull/8170


   ## Motivation
   - Redeliver response implement
   - add the tracker for response timeout
   
   ## implement
   
   ### Verifying this change
   Add the tests for it
   
   Does this pull request potentially affect one of the following parts:
   If yes was chosen, please highlight the changes
   
   Dependencies (does it add or upgrade a dependency): (no)
   The public API: (no)
   The schema: (no)
   The default values of configurations: (no)
   The wire protocol: (yes)
   The rest endpoints: (no)
   The admin cli options: (no)
   Anything that affects deployment: (no)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] congbobo184 commented on pull request #8170: Redeliver response implement

Posted by GitBox <gi...@apache.org>.
congbobo184 commented on pull request #8170:
URL: https://github.com/apache/pulsar/pull/8170#issuecomment-705909872






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] congbobo184 commented on pull request #8170: Redeliver response implement

Posted by GitBox <gi...@apache.org>.
congbobo184 commented on pull request #8170:
URL: https://github.com/apache/pulsar/pull/8170#issuecomment-705909872


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] congbobo184 commented on pull request #8170: Redeliver response implement

Posted by GitBox <gi...@apache.org>.
congbobo184 commented on pull request #8170:
URL: https://github.com/apache/pulsar/pull/8170#issuecomment-705923939


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] congbobo184 removed a comment on pull request #8170: Redeliver response implement

Posted by GitBox <gi...@apache.org>.
congbobo184 removed a comment on pull request #8170:
URL: https://github.com/apache/pulsar/pull/8170#issuecomment-704866222


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] congbobo184 commented on pull request #8170: Redeliver response implement

Posted by GitBox <gi...@apache.org>.
congbobo184 commented on pull request #8170:
URL: https://github.com/apache/pulsar/pull/8170#issuecomment-707002427


   This pr will close, because TC will handle the abort logical, then return the response to client. So, we don't need to handle this in client for redeliver response!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] congbobo184 commented on pull request #8170: Redeliver response implement

Posted by GitBox <gi...@apache.org>.
congbobo184 commented on pull request #8170:
URL: https://github.com/apache/pulsar/pull/8170#issuecomment-701430496


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] congbobo184 commented on pull request #8170: Redeliver response implement

Posted by GitBox <gi...@apache.org>.
congbobo184 commented on pull request #8170:
URL: https://github.com/apache/pulsar/pull/8170#issuecomment-705312020


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] congbobo184 commented on pull request #8170: Redeliver response implement

Posted by GitBox <gi...@apache.org>.
congbobo184 commented on pull request #8170:
URL: https://github.com/apache/pulsar/pull/8170#issuecomment-704866222


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] congbobo184 closed pull request #8170: Redeliver response implement

Posted by GitBox <gi...@apache.org>.
congbobo184 closed pull request #8170:
URL: https://github.com/apache/pulsar/pull/8170


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] congbobo184 removed a comment on pull request #8170: Redeliver response implement

Posted by GitBox <gi...@apache.org>.
congbobo184 removed a comment on pull request #8170:
URL: https://github.com/apache/pulsar/pull/8170#issuecomment-704866222


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org