You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2022/07/25 10:36:37 UTC

[GitHub] [zeppelin] HYEEWON commented on a diff in pull request #4426: [ZEPPELIN-5766] Window compilation (.appveyor.yml)

HYEEWON commented on code in PR #4426:
URL: https://github.com/apache/zeppelin/pull/4426#discussion_r928722889


##########
zeppelin-web/karma.conf.js:
##########
@@ -67,6 +67,7 @@ module.exports = function(config) {
       'bower_components/ace-builds/src-noconflict/keybinding-emacs.js',
       'bower_components/ace-builds/src-noconflict/ext-language_tools.js',
       'bower_components/ace-builds/src-noconflict/theme-chrome.js',
+      'bower_components/ace-builds/src-noconflict/mode-javascript.js',

Review Comment:
   It doesn't matter who adds it. But, I added it first, so I want to add it. Is it okay?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org