Re: [PR] HIVE-28899: Make 'get_table_meta' query case-sensitive to use index [hive]

["jiihye (via GitHub)" <gi...@apache.org>]

jiihye commented on code in PR #5793:
URL: https://github.com/apache/hive/pull/5793#discussion_r2149046583


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##########
@@ -1984,14 +1984,28 @@ private StringBuilder appendSimpleCondition(StringBuilder builder,
 
   private StringBuilder appendCondition(StringBuilder builder,
       String fieldName, String[] elements, boolean pattern, List<String> parameters) {
+    return appendCondition(builder, fieldName, elements, pattern, parameters, false);
+  }
+
+  private StringBuilder appendPatternConditionCaseSensitive(StringBuilder builder,
+      String fieldName, String elements, List<String> parameters) {
+    elements = normalizeIdentifier(elements);
+    return appendCondition(builder, fieldName, elements.split("\\|"), true, parameters, true);

Review Comment:
   @deniskuzZ 
   Sorry for the late follow-up. Following the review feedback, I kept the existing functions and removed only the `(?i)` flag from the `appendCondition` function.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org