[GitHub] [beam] arunpandianp commented on a diff in pull request #21879: Adding the BASIC view setting to getTable request

[GitBox <gi...@apache.org>]

arunpandianp commented on code in PR #21879:
URL: https://github.com/apache/beam/pull/21879#discussion_r900486032


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java:
##########
@@ -616,13 +616,24 @@ private DatasetServiceImpl(BigQueryOptions bqOptions) {
     @Override
     public @Nullable Table getTable(TableReference tableRef, List<String> selectedFields)
         throws IOException, InterruptedException {
-      return getTable(tableRef, selectedFields, createDefaultBackoff(), Sleeper.DEFAULT);
+      return getTable(tableRef, selectedFields, TableMetadataView.STORAGE_STATS);

Review Comment:
   are you sure passing STORAGE_STATS will produce the same outputs as not passing anything? If in doubt, it is safe to pass null here and keep the existing behavior as it is.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org