You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "ttttttz (Code Review)" <ge...@cloudera.org> on 2023/04/20 02:13:23 UTC
[Impala-ASF-CR] IMPALA-12066: Avoid catalogd exceptions caused by topic update tbl max wait time ms being set to 1
ttttttz has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19774
Change subject: IMPALA-12066: Avoid catalogd exceptions caused by topic_update_tbl_max_wait_time_ms being set to 1
......................................................................
IMPALA-12066: Avoid catalogd exceptions caused by topic_update_tbl_max_wait_time_ms being set to 1
When we set topic_update_tbl_max_wait_time_ms to 1, the metadata
gathering thread will not work. Because this would cause the
timeout parameter to fail the validity check in the
CatalogServiceCatalog#tryLock() method. This patch avoids
this problem by allowing the timeout parameter to be 0.
Change-Id: I082c55e45e12f80738b090b8b6157a996b57002a
---
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/19774/1
--
To view, visit http://gerrit.cloudera.org:8080/19774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I082c55e45e12f80738b090b8b6157a996b57002a
Gerrit-Change-Number: 19774
Gerrit-PatchSet: 1
Gerrit-Owner: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12073: Avoid catalogd exceptions caused by topic update tbl max wait time ms being set to 1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19774 )
Change subject: IMPALA-12073: Avoid catalogd exceptions caused by topic_update_tbl_max_wait_time_ms being set to 1
......................................................................
Patch Set 4: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9240/
--
To view, visit http://gerrit.cloudera.org:8080/19774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I082c55e45e12f80738b090b8b6157a996b57002a
Gerrit-Change-Number: 19774
Gerrit-PatchSet: 4
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Fri, 21 Apr 2023 04:59:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12073: Avoid catalogd exceptions caused by topic update tbl max wait time ms being set to 1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19774 )
Change subject: IMPALA-12073: Avoid catalogd exceptions caused by topic_update_tbl_max_wait_time_ms being set to 1
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I082c55e45e12f80738b090b8b6157a996b57002a
Gerrit-Change-Number: 19774
Gerrit-PatchSet: 4
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 20 Apr 2023 23:44:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12073: Avoid catalogd exceptions caused by topic update tbl max wait time ms being set to 1
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has removed a vote on this change.
Change subject: IMPALA-12073: Avoid catalogd exceptions caused by topic_update_tbl_max_wait_time_ms being set to 1
......................................................................
Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
--
To view, visit http://gerrit.cloudera.org:8080/19774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I082c55e45e12f80738b090b8b6157a996b57002a
Gerrit-Change-Number: 19774
Gerrit-PatchSet: 4
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12073: Avoid catalogd exceptions caused by topic update tbl max wait time ms being set to 1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19774 )
Change subject: IMPALA-12073: Avoid catalogd exceptions caused by topic_update_tbl_max_wait_time_ms being set to 1
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9240/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/19774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I082c55e45e12f80738b090b8b6157a996b57002a
Gerrit-Change-Number: 19774
Gerrit-PatchSet: 4
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 20 Apr 2023 23:44:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12066: Avoid catalogd exceptions caused by topic update tbl max wait time ms being set to 1
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19774 )
Change subject: IMPALA-12066: Avoid catalogd exceptions caused by topic_update_tbl_max_wait_time_ms being set to 1
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/19774/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19774/1//COMMIT_MSG@7
PS1, Line 7: IMPALA-12066
Please use a new JIRA id
http://gerrit.cloudera.org:8080/#/c/19774/1//COMMIT_MSG@9
PS1, Line 9: metadata
: gathering thread
nit: "metadata gathering thread" -> "topic update thread"
--
To view, visit http://gerrit.cloudera.org:8080/19774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I082c55e45e12f80738b090b8b6157a996b57002a
Gerrit-Change-Number: 19774
Gerrit-PatchSet: 1
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 20 Apr 2023 02:55:07 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12073: Avoid catalogd exceptions caused by topic update tbl max wait time ms being set to 1
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/19774 )
Change subject: IMPALA-12073: Avoid catalogd exceptions caused by topic_update_tbl_max_wait_time_ms being set to 1
......................................................................
Patch Set 3:
(2 comments)
> Patch Set 1:
>
> (2 comments)
done
http://gerrit.cloudera.org:8080/#/c/19774/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19774/1//COMMIT_MSG@7
PS1, Line 7: IMPALA-12073
> Please use a new JIRA id
Ack
http://gerrit.cloudera.org:8080/#/c/19774/1//COMMIT_MSG@9
PS1, Line 9: topic
: update thread wi
> nit: "metadata gathering thread" -> "topic update thread"
Ack
--
To view, visit http://gerrit.cloudera.org:8080/19774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I082c55e45e12f80738b090b8b6157a996b57002a
Gerrit-Change-Number: 19774
Gerrit-PatchSet: 3
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 20 Apr 2023 03:13:10 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12073: Avoid catalogd exceptions caused by topic update tbl max wait time ms being set to 1
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19774
to look at the new patch set (#2).
Change subject: IMPALA-12073: Avoid catalogd exceptions caused by topic_update_tbl_max_wait_time_ms being set to 1
......................................................................
IMPALA-12073: Avoid catalogd exceptions caused by topic_update_tbl_max_wait_time_ms being set to 1
When we set topic_update_tbl_max_wait_time_ms to 1, the topic update
thread will not work. Because this would cause the timeout
parameter to fail the validity check in the
CatalogServiceCatalog#tryLock() method. This patch avoids
this problem by allowing the timeout parameter to be 0.
Change-Id: I082c55e45e12f80738b090b8b6157a996b57002a
---
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/19774/2
--
To view, visit http://gerrit.cloudera.org:8080/19774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I082c55e45e12f80738b090b8b6157a996b57002a
Gerrit-Change-Number: 19774
Gerrit-PatchSet: 2
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-12073: Avoid catalogd exceptions caused by topic update tbl max wait time ms being set to 1
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19774 )
Change subject: IMPALA-12073: Avoid catalogd exceptions caused by topic_update_tbl_max_wait_time_ms being set to 1
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I082c55e45e12f80738b090b8b6157a996b57002a
Gerrit-Change-Number: 19774
Gerrit-PatchSet: 3
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 20 Apr 2023 23:44:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12073: Avoid catalogd exceptions caused by topic update tbl max wait time ms being set to 1
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19774 )
Change subject: IMPALA-12073: Avoid catalogd exceptions caused by topic_update_tbl_max_wait_time_ms being set to 1
......................................................................
IMPALA-12073: Avoid catalogd exceptions caused by topic_update_tbl_max_wait_time_ms being set to 1
When we set topic_update_tbl_max_wait_time_ms to 1, the topic
update thread will not work. Because this would cause the timeout
parameter to fail the validity check in the
CatalogServiceCatalog#tryLock() method. This patch avoids
this problem by allowing the timeout parameter to be 0.
Change-Id: I082c55e45e12f80738b090b8b6157a996b57002a
Reviewed-on: http://gerrit.cloudera.org:8080/19774
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Quanlong Huang <hu...@gmail.com>
---
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved
Quanlong Huang: Verified
--
To view, visit http://gerrit.cloudera.org:8080/19774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I082c55e45e12f80738b090b8b6157a996b57002a
Gerrit-Change-Number: 19774
Gerrit-PatchSet: 5
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-12066: Avoid catalogd exceptions caused by topic update tbl max wait time ms being set to 1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19774 )
Change subject: IMPALA-12066: Avoid catalogd exceptions caused by topic_update_tbl_max_wait_time_ms being set to 1
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12824/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I082c55e45e12f80738b090b8b6157a996b57002a
Gerrit-Change-Number: 19774
Gerrit-PatchSet: 1
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Apr 2023 02:33:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12073: Avoid catalogd exceptions caused by topic update tbl max wait time ms being set to 1
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19774
to look at the new patch set (#3).
Change subject: IMPALA-12073: Avoid catalogd exceptions caused by topic_update_tbl_max_wait_time_ms being set to 1
......................................................................
IMPALA-12073: Avoid catalogd exceptions caused by topic_update_tbl_max_wait_time_ms being set to 1
When we set topic_update_tbl_max_wait_time_ms to 1, the topic
update thread will not work. Because this would cause the timeout
parameter to fail the validity check in the
CatalogServiceCatalog#tryLock() method. This patch avoids
this problem by allowing the timeout parameter to be 0.
Change-Id: I082c55e45e12f80738b090b8b6157a996b57002a
---
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/19774/3
--
To view, visit http://gerrit.cloudera.org:8080/19774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I082c55e45e12f80738b090b8b6157a996b57002a
Gerrit-Change-Number: 19774
Gerrit-PatchSet: 3
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-12073: Avoid catalogd exceptions caused by topic update tbl max wait time ms being set to 1
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19774 )
Change subject: IMPALA-12073: Avoid catalogd exceptions caused by topic_update_tbl_max_wait_time_ms being set to 1
......................................................................
Patch Set 4: Verified+1
> Patch Set 4: Verified-1
>
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9240/
The failure is unrelated to this patch. Filed IMPALA-12083 to track it.
--
To view, visit http://gerrit.cloudera.org:8080/19774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I082c55e45e12f80738b090b8b6157a996b57002a
Gerrit-Change-Number: 19774
Gerrit-PatchSet: 4
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sun, 23 Apr 2023 08:40:00 +0000
Gerrit-HasComments: No