You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/14 15:52:30 UTC
[GitHub] [pulsar] nicoloboschi opened a new pull request #14279: [tests] Enable BookKeeper NativeIO feature in order to make the tests pass
nicoloboschi opened a new pull request #14279:
URL: https://github.com/apache/pulsar/pull/14279
### Motivation
Running a test that require a bookie to be started fails with JDK17, due to the BookKeeper Native IO logic. For example you can run the `PulsarSourceE2ETest` test to see it crash.
https://github.com/apache/bookkeeper/blob/4debbbf84db09f80ffeb4154e8e6feed134be0c0/bookkeeper-server/src/main/java/org/apache/bookkeeper/util/NativeIO.java#L59-L88
BookKeeper expects to be able to access to `FileDescriptor` and it will throw an assertion error if it something goes wrong. To make this possible w/ JDK17 we need to pass the Java runtime option to open the `java.io` package to be accessed.
Surefire add the `-ea` flag [by default](https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#enableAssertions) but the production process is not affected since we don't set the flag on Pulsar scripts.
An alternative could be to skip Java assertions error in the tests but I prefer to open the package as I see it as a more conservative choice.
### Modifications
* Added `--add-opens java.base/java.io=ALL-UNNAMED` to surefire options (only for build w/ jdk11+)
- [x] `no-need-doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on pull request #14279: [tests] Enable BookKeeper NativeIO feature in order to make the tests pass on JDK17
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on pull request #14279:
URL: https://github.com/apache/pulsar/pull/14279#issuecomment-1039540267
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli merged pull request #14279: [tests] Enable BookKeeper NativeIO feature in order to make the tests pass on JDK17
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #14279:
URL: https://github.com/apache/pulsar/pull/14279
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli merged pull request #14279: [tests] Enable BookKeeper NativeIO feature in order to make the tests pass on JDK17
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #14279:
URL: https://github.com/apache/pulsar/pull/14279
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on pull request #14279: [tests] Enable BookKeeper NativeIO feature in order to make the tests pass on JDK17
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on pull request #14279:
URL: https://github.com/apache/pulsar/pull/14279#issuecomment-1039540267
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org