[GitHub] [inlong] vernedeng opened a new pull request, #6479: [INLONG-6467][Manager] Support CLS cluster

[GitBox <gi...@apache.org>]

vernedeng opened a new pull request, #6479:
URL: https://github.com/apache/inlong/pull/6479

   ### Prepare a Pull Request
   *(Change the title refer to the following example)*
   
   - Title Example: [INLONG-XYZ][Component] Title of the pull request
   
   *(The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/inlong/issues) number)*
   
   - Fixes #6467
   
   ### Motivation
   
   *Explain here the context, and why you're making that change. What is the problem you're trying to solve?*
   
   ### Modifications
   
   *Describe the modifications you've done.*
   
   ### Verifying this change
   
   *(Please pick either of the following options)*
   
   - [ ] This change added tests and can be verified as follows:
   SortClusterTest
   
   ### Documentation
   
     - Does this pull request introduce a new feature? yes 
     - If yes, how is the feature documented?  JavaDocs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] dockerzhang closed pull request #6479: [INLONG-6467][Manager] Support CLS cluster

["dockerzhang (via GitHub)" <gi...@apache.org>]

dockerzhang closed pull request #6479: [INLONG-6467][Manager] Support CLS cluster
URL: https://github.com/apache/inlong/pull/6479


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] dockerzhang commented on pull request #6479: [INLONG-6467][Manager] Support CLS cluster

["dockerzhang (via GitHub)" <gi...@apache.org>]

dockerzhang commented on PR #6479:
URL: https://github.com/apache/inlong/pull/6479#issuecomment-1410156404

   there is no CLS user for InLong, all ClS PR and issues will close.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] ciscozhou commented on a diff in pull request #6479: [INLONG-6467][Manager] Support CLS cluster

[GitBox <gi...@apache.org>]

ciscozhou commented on code in PR #6479:
URL: https://github.com/apache/inlong/pull/6479#discussion_r1019203013


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/cluster/ClsClusterOperator.java:
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.service.cluster;
+
+import lombok.extern.slf4j.Slf4j;
+import org.apache.inlong.manager.common.enums.ClusterType;
+import org.apache.inlong.manager.common.enums.ErrorCodeEnum;
+import org.apache.inlong.manager.common.exceptions.BusinessException;
+import org.apache.inlong.manager.common.util.CommonBeanUtils;
+import org.apache.inlong.manager.dao.entity.InlongClusterEntity;
+import org.apache.inlong.manager.pojo.cluster.ClusterInfo;
+import org.apache.inlong.manager.pojo.cluster.ClusterRequest;
+import org.apache.inlong.manager.pojo.cluster.cls.ClsClusterInfo;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.springframework.stereotype.Service;
+
+/**
+ * CLS cluster operator.
+ */
+@Slf4j
+@Service
+public class ClsClusterOperator extends AbstractClusterOperator {
+    private static final Logger LOGGER = LoggerFactory.getLogger(ClsClusterOperator.class);
+
+    @Override
+    public Boolean accept(String clusterType) {
+        return clusterType.equals(ClusterType.CLS);

Review Comment:
   getClusterType().equals(clusterType);
   It might be better to change it this way.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org