[jira] [Resolved] (DISPATCH-1938) Unify .eslintrc settings

["Jiri Daněk (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DISPATCH-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jiri Daněk resolved DISPATCH-1938.
----------------------------------
      Assignee: Jiri Daněk
    Resolution: Fixed

Per discussion w/ [~eallen], nothing from {{.eslintrc.json}} will be recovered. The entire file was deleted by the GitHub PR.

> Unify .eslintrc settings
> ------------------------
>
>                 Key: DISPATCH-1938
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1938
>             Project: Qpid Dispatch
>          Issue Type: Bug
>          Components: Console
>    Affects Versions: 1.14.0
>            Reporter: Jiri Daněk
>            Assignee: Jiri Daněk
>            Priority: Major
>             Fix For: 1.15.0
>
>
> Currently, there are two ESlint config files in the project. There is {{console/.eslintrc.json}} and there is eslint section in {{console/react/package.json}}. The latter is used in a GitHub CI job, the former is not. The former is more strict, actually does not match the codestyle of the project, at this point, and uses legacy syntax (e.g. {{"no-console": "on"}} does not work nowadays).
> The {{.eslintrc.json}}:
> {code}
> {
>   "env": {
>     "browser": true,
>     "node": true,
>     "amd": true,
>     "jquery": true
>   },
>   "extends": ["eslint:recommended", "plugin:patternfly-react/recommended"],
>   "parserOptions": {
>     "ecmaVersion": 6,
>     "sourceType": "module",
>     "ecmaFeatures": {
>       "jsx": true
>     }
>   },
>   "rules": {
>     "indent": [
>       "error",
>       2
>     ],
>     "linebreak-style": [
>       "error",
>       "unix"
>     ],
>     "semi": [
>       "error",
>       "always"
>     ],
>     "no-console": "on",
>     "no-debugger": 1
>   }
> }
> {code}
> Somebody should do something about it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org