You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/04/16 13:14:37 UTC
[GitHub] [incubator-iotdb] wshao08 opened a new pull request #1062: Fix
Nullpointer bug in Previous Fill
wshao08 opened a new pull request #1062: Fix Nullpointer bug in Previous Fill
URL: https://github.com/apache/incubator-iotdb/pull/1062
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request
#1062: Fix Nullpointer bug in Previous Fill
Posted by GitBox <gi...@apache.org>.
qiaojialin commented on a change in pull request #1062: Fix Nullpointer bug in Previous Fill
URL: https://github.com/apache/incubator-iotdb/pull/1062#discussion_r409566192
##########
File path: server/src/main/java/org/apache/iotdb/db/query/fill/PreviousFill.java
##########
@@ -172,36 +171,24 @@ private void UnpackOverlappedUnseqFiles(long lBoundTime) throws IOException {
PriorityQueue<TsFileResource> unseqFileResource =
sortUnSeqFileResourcesInDecendingOrder(dataSource.getUnseqResources());
- while (!unseqFileResource.isEmpty()) {
- // The very end time of unseq files is smaller than lBoundTime,
- // then skip all the rest unseq files
- if (unseqFileResource.peek().getEndTimeMap().get(seriesPath.getDevice()) < lBoundTime) {
- return;
- }
- TimeseriesMetadata timeseriesMetadata =
- FileLoaderUtils.loadTimeSeriesMetadata(
- unseqFileResource.poll(), seriesPath, context, timeFilter, allSensors);
- if (timeseriesMetadata != null && timeseriesMetadata.getStatistics().canUseStatistics()
- && lBoundTime <= timeseriesMetadata.getStatistics().getEndTime()) {
- // The last timeseriesMetadata will be used as a pivot to filter the rest unseq files.
- // Update lBoundTime with the last timeseriesMetadata's start time
- lBoundTime = Math.max(lBoundTime, timeseriesMetadata.getStatistics().getStartTime());
- unseqTimeseriesMetadataList.add(timeseriesMetadata);
- break;
- }
- }
-
- // unpack all overlapped unseq files and fill unseqTimeseriesMetadata list
while (!unseqFileResource.isEmpty()
- && (lBoundTime <= unseqFileResource.peek().getEndTimeMap().get(seriesPath.getDevice()))) {
+ && (lBoundTime <= unseqFileResource.peek().getEndTimeMap().get(seriesPath.getDevice())))
+ {
Review comment:
```suggestion
&& (lBoundTime <= unseqFileResource.peek().getEndTimeMap().get(seriesPath.getDevice()))) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] qiaojialin merged pull request #1062: Fix
Nullpointer bug in Previous Fill
Posted by GitBox <gi...@apache.org>.
qiaojialin merged pull request #1062: Fix Nullpointer bug in Previous Fill
URL: https://github.com/apache/incubator-iotdb/pull/1062
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services