You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/14 14:55:40 UTC
[GitHub] [incubator-superset] kgabryje opened a new pull request #10866: ESLint: Re-enable rule control-has-associated-label
kgabryje opened a new pull request #10866:
URL: https://github.com/apache/incubator-superset/pull/10866
### SUMMARY
Re-enable ESLint rule `jsx-a11y/control-has-associated-label`, which was disabled in PR #10839. Code was refactored to fix the errors raised by the rule.
### TEST PLAN
Run `npm run lint`, verify that there are no new Javascript/Typescript errors.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #10866: ESLint: Re-enable rule control-has-associated-label
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #10866:
URL: https://github.com/apache/incubator-superset/pull/10866#discussion_r488118154
##########
File path: superset-frontend/src/explore/components/controls/DatasourceControl.jsx
##########
@@ -179,6 +179,7 @@ class DatasourceControl extends React.PureComponent {
<a href="#">
<i
role="button"
+ aria-label="Toggle show datasource"
Review comment:
Maybe this wording is a little clearer?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #10866: ESLint: Re-enable rule control-has-associated-label
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #10866:
URL: https://github.com/apache/incubator-superset/pull/10866#discussion_r488118010
##########
File path: superset-frontend/src/explore/components/controls/DatasourceControl.jsx
##########
@@ -179,6 +179,7 @@ class DatasourceControl extends React.PureComponent {
<a href="#">
<i
role="button"
+ aria-label="Toggle show datasource"
Review comment:
```suggestion
aria-label="Toggle datasource visibility"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas merged pull request #10866: ESLint: Re-enable rule control-has-associated-label
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #10866:
URL: https://github.com/apache/incubator-superset/pull/10866
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org