You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "kevinjqliu (via GitHub)" <gi...@apache.org> on 2026/09/14 20:47:50 UTC

Re: [PR] Fix constructor signatures and test annotations for ty [iceberg-python]

kevinjqliu commented on code in PR #3965:
URL: https://github.com/apache/iceberg-python/pull/3965#discussion_r4009444480


##########
pyiceberg/expressions/literals.py:
##########
@@ -174,6 +174,9 @@ def literal(value: L) -> Literal[L]:
 
 
 class AboveMax(Literal[L]):
+    def __init__(self, value: Any, value_type: type[Any], /, **data: Any) -> None:

Review Comment:
   ```suggestion
       def __init__(self, value: L, value_type: type[L], /, **data: Any) -> None:
   ```



##########
pyiceberg/expressions/literals.py:
##########
@@ -184,6 +187,9 @@ def __str__(self) -> str:
 
 
 class BelowMin(Literal[L]):
+    def __init__(self, value: Any, value_type: type[Any], /, **data: Any) -> None:

Review Comment:
   ```suggestion
       def __init__(self, value: L, value_type: type[L], /, **data: Any) -> None:
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org