You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by neykov <gi...@git.apache.org> on 2014/07/11 12:57:36 UTC
[GitHub] incubator-brooklyn pull request: Move catalog YAML test from rest-...
GitHub user neykov opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/65
Move catalog YAML test from rest-server to brooklyn-camp.
The test doesn't rely on REST in any way.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/neykov/incubator-brooklyn move-yaml-test-to-camp
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/65.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #65
----
commit aff8601aebb86c8225d7c1e875a73fb38dce59c5
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2014-07-11T10:56:02Z
Move catalog YAML test from rest-server to brooklyn-camp.
The test doesn't rely on REST in any way.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Move catalog YAML test from rest-...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/65#issuecomment-48898091
agree - merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Move catalog YAML test from rest-...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/65#issuecomment-48747452
We already have those tests in ApplicationResourceTest, CatalogResourceTest, don't we?
CatalogBundleResourceTest was created to test the osgi work and the rest tests were the most close thing I've found at the time to use as a base.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Move catalog YAML test from rest-...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/65#issuecomment-48734796
it's good to have these tests in brooklyn-camp but we've now lost the tests which exercise the `/v1/applications` and `/v1/catalog` REST endpoints. can this be structured so that we have the REST tests but delegating to the `brooklyn-camp` test for things like yaml creation and asserts (with just a few methods subclassed) ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Move catalog YAML test from rest-...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/65
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---