You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hugegraph.apache.org by GitBox <gi...@apache.org> on 2022/04/27 13:48:02 UTC
[GitHub] [incubator-hugegraph] seagle-yuan opened a new pull request, #1855: fix checkstyle core-util issue
seagle-yuan opened a new pull request, #1855:
URL: https://github.com/apache/incubator-hugegraph/pull/1855
fix checkstyle issue
com.baidu.hugegraph.traversal.algorithm.HugeTraverser.java
com.baidu.hugegraph.traversal.algorithm.JaccardSimilarTraverser.java
com.baidu.hugegraph.traversal.algorithm.OltpTraverser.java
com.baidu.hugegraph.traversal.algorithm.ShortestPathTraverser.java
com.baidu.hugegraph.traversal.algorithm.records.ShortestPathRecords.java
com.baidu.hugegraph.traversal.optimize.HugeScriptTraversal.java
com.baidu.hugegraph.traversal.optimize.TraversalUtil.java
com.baidu.hugegraph.type.HugeType.java
com.baidu.hugegraph.type.define.SerialEnum.java
com.baidu.hugegraph.util.ConfigUtil.java
com.baidu.hugegraph.util.Consumers.java
com.baidu.hugegraph.util.GZipUtil.java
com.baidu.hugegraph.util.KryoUtil.java
com.baidu.hugegraph.util.Reflection.java
com.baidu.hugegraph.util.collection.IntMap.java
com.baidu.hugegraph.util.collection.IntSet.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] javeme commented on a diff in pull request #1855: fix checkstyle core-util issue
Posted by GitBox <gi...@apache.org>.
javeme commented on code in PR #1855:
URL: https://github.com/apache/incubator-hugegraph/pull/1855#discussion_r867949213
##########
hugegraph-core/src/main/java/com/baidu/hugegraph/util/Reflection.java:
##########
@@ -69,7 +69,7 @@ public class Reflection {
try {
registerMethodsToFilterMethodTemp =
REFLECTION_CLAZZ.getMethod("registerMethodsToFilter",
- Class.class, String[].class);
+ Class.class, String[].class);
Review Comment:
also update alignment of registerFieldsToFilter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] javeme commented on pull request #1855: fix checkstyle core-util issue
Posted by GitBox <gi...@apache.org>.
javeme commented on PR #1855:
URL: https://github.com/apache/incubator-hugegraph/pull/1855#issuecomment-1120216563
@seagle-yuan there are still comments~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] codecov[bot] commented on pull request #1855: fix checkstyle core-util issue
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #1855:
URL: https://github.com/apache/incubator-hugegraph/pull/1855#issuecomment-1116929820
# [Codecov](https://codecov.io/gh/apache/incubator-hugegraph/pull/1855?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1855](https://codecov.io/gh/apache/incubator-hugegraph/pull/1855?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4543b29) into [master](https://codecov.io/gh/apache/incubator-hugegraph/commit/044a15e569fe674bad0f8190aa31e2c4905c8887?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (044a15e) will **decrease** coverage by `16.18%`.
> The diff coverage is `52.63%`.
```diff
@@ Coverage Diff @@
## master #1855 +/- ##
=============================================
- Coverage 66.96% 50.77% -16.19%
+ Complexity 982 659 -323
=============================================
Files 447 447
Lines 38045 37988 -57
Branches 5391 5369 -22
=============================================
- Hits 25476 19290 -6186
- Misses 10065 16589 +6524
+ Partials 2504 2109 -395
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hugegraph/pull/1855?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...h/traversal/algorithm/JaccardSimilarTraverser.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1855/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL3RyYXZlcnNhbC9hbGdvcml0aG0vSmFjY2FyZFNpbWlsYXJUcmF2ZXJzZXIuamF2YQ==) | `49.03% <ø> (ø)` | |
| [...u/hugegraph/traversal/algorithm/OltpTraverser.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1855/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL3RyYXZlcnNhbC9hbGdvcml0aG0vT2x0cFRyYXZlcnNlci5qYXZh) | `64.17% <ø> (ø)` | |
| [...egraph/traversal/optimize/HugeScriptTraversal.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1855/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL3RyYXZlcnNhbC9vcHRpbWl6ZS9IdWdlU2NyaXB0VHJhdmVyc2FsLmphdmE=) | `85.36% <ø> (ø)` | |
| [...c/main/java/com/baidu/hugegraph/util/GZipUtil.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1855/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL3V0aWwvR1ppcFV0aWwuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...c/main/java/com/baidu/hugegraph/util/KryoUtil.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1855/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL3V0aWwvS3J5b1V0aWwuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | :arrow_down: |
| [...va/com/baidu/hugegraph/util/collection/IntMap.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1855/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL3V0aWwvY29sbGVjdGlvbi9JbnRNYXAuamF2YQ==) | `45.78% <ø> (-26.62%)` | :arrow_down: |
| [...du/hugegraph/traversal/optimize/TraversalUtil.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1855/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL3RyYXZlcnNhbC9vcHRpbWl6ZS9UcmF2ZXJzYWxVdGlsLmphdmE=) | `50.85% <16.66%> (-11.97%)` | :arrow_down: |
| [...main/java/com/baidu/hugegraph/util/ConfigUtil.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1855/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL3V0aWwvQ29uZmlnVXRpbC5qYXZh) | `32.75% <33.33%> (-1.14%)` | :arrow_down: |
| [.../main/java/com/baidu/hugegraph/util/Consumers.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1855/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL3V0aWwvQ29uc3VtZXJzLmphdmE=) | `56.16% <50.00%> (ø)` | |
| [...va/com/baidu/hugegraph/util/collection/IntSet.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1855/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL3V0aWwvY29sbGVjdGlvbi9JbnRTZXQuamF2YQ==) | `43.82% <50.00%> (-31.18%)` | :arrow_down: |
| ... and [180 more](https://codecov.io/gh/apache/incubator-hugegraph/pull/1855/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hugegraph/pull/1855?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hugegraph/pull/1855?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [044a15e...4543b29](https://codecov.io/gh/apache/incubator-hugegraph/pull/1855?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] javeme commented on a diff in pull request #1855: fix checkstyle core-util issue
Posted by GitBox <gi...@apache.org>.
javeme commented on code in PR #1855:
URL: https://github.com/apache/incubator-hugegraph/pull/1855#discussion_r864425201
##########
hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/HugeTraverser.java:
##########
@@ -360,10 +360,9 @@ public static void checkCapacity(long capacity, long access,
public static void checkSkipDegree(long skipDegree, long degree,
long capacity) {
- E.checkArgument(skipDegree >= 0L &&
- skipDegree <= Query.DEFAULT_CAPACITY ,
- "The skipped degree must be in [0, %s], but got '%s'",
- Query.DEFAULT_CAPACITY, skipDegree);
+ E.checkArgument(skipDegree >= 0L && skipDegree <= Query.DEFAULT_CAPACITY,
+ "The skipped degree must be in [0, %s], but got '%s'",
Review Comment:
can keep the old alignment style
##########
hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/JaccardSimilarTraverser.java:
##########
@@ -41,9 +41,8 @@ public JaccardSimilarTraverser(HugeGraph graph) {
super(graph);
}
-
public double jaccardSimilarity(Id vertex, Id other, Directions dir,
- String label, long degree) {
+ String label, long degree) {
Review Comment:
prefer to keep the old style
##########
hugegraph-core/src/main/java/com/baidu/hugegraph/util/collection/IntMap.java:
##########
@@ -67,7 +72,7 @@ public static final class IntMapBySegments implements IntMap {
private static final int DEFAULT_SEGMENTS = IntSet.CPUS * 100;
private static final Function<Integer, IntMap> DEFAULT_CREATOR =
- size -> new IntMapByFixedAddr(size);
+ size -> new IntMapByFixedAddr(size);
Review Comment:
prefer to keep old style
##########
hugegraph-core/src/main/java/com/baidu/hugegraph/util/Reflection.java:
##########
@@ -55,39 +55,39 @@ public class Reflection {
}
}
- reflectionClazz = reflectionClazzTemp;
+ REFLECTION_CLAZZ = reflectionClazzTemp;
- if (reflectionClazz != null) {
+ if (REFLECTION_CLAZZ != null) {
try {
registerFieldsToFilterMethodTemp =
- reflectionClazz.getMethod("registerFieldsToFilter",
+ REFLECTION_CLAZZ.getMethod("registerFieldsToFilter",
Class.class, String[].class);
} catch (Throwable e) {
LOG.error("Can't find registerFieldsToFilter method", e);
}
try {
registerMethodsToFilterMethodTemp =
- reflectionClazz.getMethod("registerMethodsToFilter",
+ REFLECTION_CLAZZ.getMethod("registerMethodsToFilter",
Review Comment:
also update alignment
##########
hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/HugeTraverser.java:
##########
@@ -378,10 +377,9 @@ public static void checkSkipDegree(long skipDegree, long degree,
}
}
- public static <K, V extends Comparable<? super V>> Map<K, V> topN(
- Map<K, V> map,
- boolean sorted,
- long limit) {
+ public static <K, V extends Comparable<? super V>> Map<K, V> topN(Map<K,
+ V> map, boolean sorted, long limit) {
Review Comment:
can we don't wrap a line inside a parameter
##########
hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/OltpTraverser.java:
##########
@@ -38,9 +38,7 @@
import com.baidu.hugegraph.iterator.FilterIterator;
import com.baidu.hugegraph.util.Consumers;
-
-public abstract class OltpTraverser extends HugeTraverser
- implements AutoCloseable {
+public abstract class OltpTraverser extends HugeTraverser implements AutoCloseable {
Review Comment:
prefer to keep the old style
##########
hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/optimize/TraversalUtil.java:
##########
@@ -902,7 +904,10 @@ private static Number predicateNumber(String value) {
value = JsonUtil.fromJson(value, String.class);
}
return DateUtil.parse(value).getTime();
- } catch (Exception ignored) {}
+ } catch (Exception ignored) {
+ // @todo
Review Comment:
"TODO: improve to throw a exception here"
##########
hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/ShortestPathTraverser.java:
##########
@@ -177,8 +177,7 @@ public PathSet forward(boolean all) {
Id target = edge.id().otherVertexId();
PathSet paths = this.record.findPath(target,
- t -> !this.superNode(t, this.direction),
- all, false);
+ t -> !this.superNode(t, this.direction), all, false);
Review Comment:
prefer to keep the old style
##########
hugegraph-core/src/main/java/com/baidu/hugegraph/util/Reflection.java:
##########
@@ -55,39 +55,39 @@ public class Reflection {
}
}
- reflectionClazz = reflectionClazzTemp;
+ REFLECTION_CLAZZ = reflectionClazzTemp;
- if (reflectionClazz != null) {
+ if (REFLECTION_CLAZZ != null) {
try {
registerFieldsToFilterMethodTemp =
- reflectionClazz.getMethod("registerFieldsToFilter",
+ REFLECTION_CLAZZ.getMethod("registerFieldsToFilter",
Class.class, String[].class);
} catch (Throwable e) {
LOG.error("Can't find registerFieldsToFilter method", e);
}
try {
registerMethodsToFilterMethodTemp =
- reflectionClazz.getMethod("registerMethodsToFilter",
+ REFLECTION_CLAZZ.getMethod("registerMethodsToFilter",
Class.class, String[].class);
} catch (NoSuchMethodException e) {
LOG.error("Can't find registerMethodsToFilter method", e);
}
}
- registerFieldsToFilterMethod = registerFieldsToFilterMethodTemp;
- registerMethodsToFilterMethod = registerMethodsToFilterMethodTemp;
+ REGISTER_FILEDS_TO_FILTER_METHOD = registerFieldsToFilterMethodTemp;
+ REGISTER_METHODS_TO_FILTER_MOTHOD = registerMethodsToFilterMethodTemp;
}
public static void registerFieldsToFilter(Class<?> containingClass,
String... fieldNames) {
- if (registerFieldsToFilterMethod == null) {
+ if (REGISTER_FILEDS_TO_FILTER_METHOD == null) {
throw new NotSupportException(
"Reflection.registerFieldsToFilter()");
}
try {
- registerFieldsToFilterMethod.setAccessible(true);
- registerFieldsToFilterMethod.invoke(reflectionClazz,
+ REGISTER_FILEDS_TO_FILTER_METHOD.setAccessible(true);
+ REGISTER_FILEDS_TO_FILTER_METHOD.invoke(REFLECTION_CLAZZ,
Review Comment:
also update alignment
##########
hugegraph-core/src/main/java/com/baidu/hugegraph/util/Reflection.java:
##########
@@ -98,14 +98,14 @@ public static void registerFieldsToFilter(Class<?> containingClass,
public static void registerMethodsToFilter(Class<?> containingClass,
String... methodNames) {
- if (registerMethodsToFilterMethod == null) {
+ if (REGISTER_METHODS_TO_FILTER_MOTHOD == null) {
throw new NotSupportException(
"Reflection.registerMethodsToFilterMethod()");
}
try {
- registerMethodsToFilterMethod.setAccessible(true);
- registerMethodsToFilterMethod.invoke(reflectionClazz,
+ REGISTER_METHODS_TO_FILTER_MOTHOD.setAccessible(true);
+ REGISTER_METHODS_TO_FILTER_MOTHOD.invoke(REFLECTION_CLAZZ,
Review Comment:
also update alignment
##########
hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/ShortestPathTraverser.java:
##########
@@ -217,8 +216,7 @@ public PathSet backward(boolean all) {
Id target = edge.id().otherVertexId();
PathSet paths = this.record.findPath(target,
- t -> !this.superNode(t, opposite),
- all, false);
+ t -> !this.superNode(t, opposite), all,false);
Review Comment:
prefer to keep the old style
##########
hugegraph-core/src/main/java/com/baidu/hugegraph/util/collection/IntSet.java:
##########
@@ -58,7 +61,7 @@ public static final class IntSetBySegments implements IntSet {
private static final int DEFAULT_SEGMENTS = IntSet.CPUS * 100;
private static final Function<Integer, IntSet> DEFAULT_CREATOR =
- size -> new IntSetByFixedAddr4Unsigned(size);
+ size -> new IntSetByFixedAddr4Unsigned(size);
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] javeme commented on a diff in pull request #1855: fix checkstyle core-util issue
Posted by GitBox <gi...@apache.org>.
javeme commented on code in PR #1855:
URL: https://github.com/apache/incubator-hugegraph/pull/1855#discussion_r865546918
##########
hugegraph-core/src/main/java/com/baidu/hugegraph/util/Reflection.java:
##########
@@ -55,39 +55,39 @@ public class Reflection {
}
}
- reflectionClazz = reflectionClazzTemp;
+ REFLECTION_CLAZZ = reflectionClazzTemp;
- if (reflectionClazz != null) {
+ if (REFLECTION_CLAZZ != null) {
try {
registerFieldsToFilterMethodTemp =
- reflectionClazz.getMethod("registerFieldsToFilter",
+ REFLECTION_CLAZZ.getMethod("registerFieldsToFilter",
Class.class, String[].class);
} catch (Throwable e) {
LOG.error("Can't find registerFieldsToFilter method", e);
}
try {
registerMethodsToFilterMethodTemp =
- reflectionClazz.getMethod("registerMethodsToFilter",
+ REFLECTION_CLAZZ.getMethod("registerMethodsToFilter",
Review Comment:
also update alignment of line 72
##########
hugegraph-core/src/main/java/com/baidu/hugegraph/util/Reflection.java:
##########
@@ -55,39 +55,39 @@ public class Reflection {
}
}
- reflectionClazz = reflectionClazzTemp;
+ REFLECTION_CLAZZ = reflectionClazzTemp;
- if (reflectionClazz != null) {
+ if (REFLECTION_CLAZZ != null) {
try {
registerFieldsToFilterMethodTemp =
- reflectionClazz.getMethod("registerFieldsToFilter",
+ REFLECTION_CLAZZ.getMethod("registerFieldsToFilter",
Class.class, String[].class);
} catch (Throwable e) {
LOG.error("Can't find registerFieldsToFilter method", e);
}
try {
registerMethodsToFilterMethodTemp =
- reflectionClazz.getMethod("registerMethodsToFilter",
+ REFLECTION_CLAZZ.getMethod("registerMethodsToFilter",
Class.class, String[].class);
} catch (NoSuchMethodException e) {
LOG.error("Can't find registerMethodsToFilter method", e);
}
}
- registerFieldsToFilterMethod = registerFieldsToFilterMethodTemp;
- registerMethodsToFilterMethod = registerMethodsToFilterMethodTemp;
+ REGISTER_FILEDS_TO_FILTER_METHOD = registerFieldsToFilterMethodTemp;
+ REGISTER_METHODS_TO_FILTER_MOTHOD = registerMethodsToFilterMethodTemp;
}
public static void registerFieldsToFilter(Class<?> containingClass,
String... fieldNames) {
- if (registerFieldsToFilterMethod == null) {
+ if (REGISTER_FILEDS_TO_FILTER_METHOD == null) {
throw new NotSupportException(
"Reflection.registerFieldsToFilter()");
}
try {
- registerFieldsToFilterMethod.setAccessible(true);
- registerFieldsToFilterMethod.invoke(reflectionClazz,
+ REGISTER_FILEDS_TO_FILTER_METHOD.setAccessible(true);
+ REGISTER_FILEDS_TO_FILTER_METHOD.invoke(REFLECTION_CLAZZ,
Review Comment:
also update alignment of line 91
##########
hugegraph-core/src/main/java/com/baidu/hugegraph/util/Reflection.java:
##########
@@ -98,14 +98,14 @@ public static void registerFieldsToFilter(Class<?> containingClass,
public static void registerMethodsToFilter(Class<?> containingClass,
String... methodNames) {
- if (registerMethodsToFilterMethod == null) {
+ if (REGISTER_METHODS_TO_FILTER_MOTHOD == null) {
throw new NotSupportException(
"Reflection.registerMethodsToFilterMethod()");
}
try {
- registerMethodsToFilterMethod.setAccessible(true);
- registerMethodsToFilterMethod.invoke(reflectionClazz,
+ REGISTER_METHODS_TO_FILTER_MOTHOD.setAccessible(true);
+ REGISTER_METHODS_TO_FILTER_MOTHOD.invoke(REFLECTION_CLAZZ,
Review Comment:
also update alignment of line 109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] imbajin merged pull request #1855: fix checkstyle core-util issue
Posted by GitBox <gi...@apache.org>.
imbajin merged PR #1855:
URL: https://github.com/apache/incubator-hugegraph/pull/1855
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org