You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/25 09:26:45 UTC
[GitHub] [incubator-nuttx] zhuyanlinzyl opened a new pull request #5337: tcbinfo: Update tcbinfo struct, Fix the compile warning
zhuyanlinzyl opened a new pull request #5337:
URL: https://github.com/apache/incubator-nuttx/pull/5337
## Summary
Update tcbinfo struct, Fix the compile warning
## Impact
No
## Testing
Testing on m55 with jtag enable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5337: tcbinfo: Update tcbinfo struct, Fix the compile warning
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5337:
URL: https://github.com/apache/incubator-nuttx/pull/5337#discussion_r791687694
##########
File path: arch/arm/src/arm/arm_tcbinfo.c
##########
@@ -63,6 +54,22 @@ const struct tcbinfo_s g_tcbinfo =
TCB_REG_OFF(REG_CPSR),
};
+/****************************************************************************
+ * Public Data
+ ****************************************************************************/
+
+const struct tcbinfo_s g_tcbinfo =
+{
+ TCB_PID_OFF,
+ TCB_STATE_OFF,
+ TCB_PRI_OFF,
+ TCB_NAME_OFF,
+ XCPTCONTEXT_REGS,
+ {
+ .p = g_reg_offs,
Review comment:
arm arch already has many similar construct, so we relax the check until we do the final decision?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5337: tcbinfo: Update tcbinfo struct, Fix the compile warning
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5337:
URL: https://github.com/apache/incubator-nuttx/pull/5337#discussion_r793307884
##########
File path: arch/arm/src/arm/arm_tcbinfo.c
##########
@@ -63,6 +54,22 @@ const struct tcbinfo_s g_tcbinfo =
TCB_REG_OFF(REG_CPSR),
};
+/****************************************************************************
+ * Public Data
+ ****************************************************************************/
+
+const struct tcbinfo_s g_tcbinfo =
+{
+ TCB_PID_OFF,
+ TCB_STATE_OFF,
+ TCB_PRI_OFF,
+ TCB_NAME_OFF,
+ XCPTCONTEXT_REGS,
+ {
+ .p = g_reg_offs,
Review comment:
@pkarashchenko do you think it's reasonable to ignore this in the current state?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5337: tcbinfo: Update tcbinfo struct, Fix the compile warning
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #5337:
URL: https://github.com/apache/incubator-nuttx/pull/5337
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5337: tcbinfo: Update tcbinfo struct, Fix the compile warning
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5337:
URL: https://github.com/apache/incubator-nuttx/pull/5337#discussion_r791687694
##########
File path: arch/arm/src/arm/arm_tcbinfo.c
##########
@@ -63,6 +54,22 @@ const struct tcbinfo_s g_tcbinfo =
TCB_REG_OFF(REG_CPSR),
};
+/****************************************************************************
+ * Public Data
+ ****************************************************************************/
+
+const struct tcbinfo_s g_tcbinfo =
+{
+ TCB_PID_OFF,
+ TCB_STATE_OFF,
+ TCB_PRI_OFF,
+ TCB_NAME_OFF,
+ XCPTCONTEXT_REGS,
+ {
+ .p = g_reg_offs,
Review comment:
arm arch already has many similar construct, so we relax the check until we do the final decision?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5337: tcbinfo: Update tcbinfo struct, Fix the compile warning
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5337:
URL: https://github.com/apache/incubator-nuttx/pull/5337#discussion_r791528634
##########
File path: arch/arm/src/arm/arm_tcbinfo.c
##########
@@ -63,6 +54,22 @@ const struct tcbinfo_s g_tcbinfo =
TCB_REG_OFF(REG_CPSR),
};
+/****************************************************************************
+ * Public Data
+ ****************************************************************************/
+
+const struct tcbinfo_s g_tcbinfo =
+{
+ TCB_PID_OFF,
+ TCB_STATE_OFF,
+ TCB_PRI_OFF,
+ TCB_NAME_OFF,
+ XCPTCONTEXT_REGS,
+ {
+ .p = g_reg_offs,
Review comment:
uncompliant with C89, but since this is arch specific, I'm not sure if we need to care about it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5337: tcbinfo: Update tcbinfo struct, Fix the compile warning
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5337:
URL: https://github.com/apache/incubator-nuttx/pull/5337#discussion_r791528634
##########
File path: arch/arm/src/arm/arm_tcbinfo.c
##########
@@ -63,6 +54,22 @@ const struct tcbinfo_s g_tcbinfo =
TCB_REG_OFF(REG_CPSR),
};
+/****************************************************************************
+ * Public Data
+ ****************************************************************************/
+
+const struct tcbinfo_s g_tcbinfo =
+{
+ TCB_PID_OFF,
+ TCB_STATE_OFF,
+ TCB_PRI_OFF,
+ TCB_NAME_OFF,
+ XCPTCONTEXT_REGS,
+ {
+ .p = g_reg_offs,
Review comment:
uncompliant with C89, but since this is arch specific, I'm not sure if we need to care about it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5337: tcbinfo: Update tcbinfo struct, Fix the compile warning
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5337:
URL: https://github.com/apache/incubator-nuttx/pull/5337#discussion_r793312864
##########
File path: arch/arm/src/arm/arm_tcbinfo.c
##########
@@ -63,6 +54,22 @@ const struct tcbinfo_s g_tcbinfo =
TCB_REG_OFF(REG_CPSR),
};
+/****************************************************************************
+ * Public Data
+ ****************************************************************************/
+
+const struct tcbinfo_s g_tcbinfo =
+{
+ TCB_PID_OFF,
+ TCB_STATE_OFF,
+ TCB_PRI_OFF,
+ TCB_NAME_OFF,
+ XCPTCONTEXT_REGS,
+ {
+ .p = g_reg_offs,
Review comment:
Yes. Of course
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org