You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by bo...@apache.org on 2013/12/20 18:36:32 UTC
svn commit: r1552755 -
/commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/jar/JarArchiveEntry.java
Author: bodewig
Date: Fri Dec 20 17:36:32 2013
New Revision: 1552755
URL: http://svn.apache.org/r1552755
Log:
explain why JarArchiveEntry overrides equals/hashCode
Modified:
commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/jar/JarArchiveEntry.java
Modified: commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/jar/JarArchiveEntry.java
URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/jar/JarArchiveEntry.java?rev=1552755&r1=1552754&r2=1552755&view=diff
==============================================================================
--- commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/jar/JarArchiveEntry.java (original)
+++ commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/jar/JarArchiveEntry.java Fri Dec 20 17:36:32 2013
@@ -87,6 +87,12 @@ public class JarArchiveEntry extends Zip
return null;
}
+ /*
+ * We can chose between Findbugs complaining about
+ * http://findbugs.sourceforge.net/bugDescriptions.html#EQ_DOESNT_OVERRIDE_EQUALS
+ * or PMD stating "Overriding method merely calls super" - so far
+ * the choice is to make Findbugs happy.
+ */
@Override
public boolean equals(Object o) {
return super.equals(o);